Skip to content

Commit af01de9

Browse files
authored
ReScript 11, ReScript Core 1.2.0 etc. (#47)
* ReScript 11, ReScript Core 1.2.0 etc. * Take "esmodule" vs. "es6" into account
1 parent 024eaad commit af01de9

File tree

16 files changed

+1019
-514
lines changed

16 files changed

+1019
-514
lines changed

package-lock.json

Lines changed: 107 additions & 66 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,12 @@
3737
},
3838
"devDependencies": {
3939
"@clack/prompts": "0.7.0",
40-
"@rescript/core": "^0.6.0",
40+
"@rescript/core": "^1.2.0",
4141
"@rollup/plugin-commonjs": "^25.0.7",
4242
"@rollup/plugin-node-resolve": "^15.2.3",
4343
"@rollup/plugin-terser": "^0.4.4",
4444
"compare-versions": "^6.1.0",
45-
"rescript": "^11.0.1",
46-
"rollup": "^4.9.1"
45+
"rescript": "^11.1.0",
46+
"rollup": "^4.14.3"
4747
}
48-
}
48+
}

rescript.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"subdirs": true
66
},
77
"package-specs": {
8-
"module": "es6",
8+
"module": "esmodule",
99
"in-source": true
1010
},
1111
"suffix": ".res.mjs",

src/ExistingJsProject.res

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,19 +40,19 @@ let updateRescriptJson = async (~projectName, ~sourceDir, ~moduleSystem, ~suffix
4040

4141
let getSuffixForModuleSystem = moduleSystem =>
4242
switch moduleSystem {
43-
| "es6" => ".res.mjs"
43+
| "esmodule" | "es6" | "es6-global" => ".res.mjs"
4444
| _ => ".res.js"
4545
}
4646

47-
let moduleSystemOptions = [
47+
let getModuleSystemOptions = (~versions) => [
4848
{
4949
P.value: "commonjs",
5050
label: "CommonJS",
5151
hint: "Use require syntax and .res.js extension",
5252
},
5353
{
54-
value: "es6",
55-
label: "ES6",
54+
value: RescriptVersions.esmModuleSystemName(versions),
55+
label: "ES Modules",
5656
hint: "Use import syntax and .res.mjs extension",
5757
},
5858
]
@@ -69,7 +69,7 @@ let addToExistingProject = async (~projectName) => {
6969

7070
let moduleSystem = await P.select({
7171
message: "What module system will you use?",
72-
options: moduleSystemOptions,
72+
options: getModuleSystemOptions(~versions),
7373
})->P.resultOrRaise
7474

7575
let suffix = moduleSystem->getSuffixForModuleSystem

src/JsonUtils.res

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ let updateJsonFile = (filename, updateFn) =>
1515
updateFile(filename, contents => {
1616
let json = JSON.parseExn(contents)
1717
updateFn(json)
18-
JSON.stringifyWithIndent(json, 2)
18+
JSON.stringify(json, ~space=2)
1919
})
2020

2121
let getStringValue = (json: JSON.t, ~fieldName) =>

0 commit comments

Comments
 (0)