Fix/monorepo root compilerlog watch #1174
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alyze from workspace root - Server: restrict .compiler.log watching to ROOT/lib/bs/.compiler.log per workspace folder to avoid event floods from packages/** and node_modules/**.\n- Server: fix Start Build spawning for v12 layouts by preferring rescript.exe and falling back to rescript (also respects rescript.settings.binaryPath).\n- Client: anchor Start Code Analysis to the VSCode workspace folder root rather than the active file directory.\n- Client: resolve code-analysis binary relative to the chosen cwd (workspace root) to avoid subpackage-anchored tool lookup.\n\nFiles: server/src/server.ts, client/src/extension.ts, client/src/commands/code_analysis.ts
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: adbe7c6010
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cknitt
reviewed
Jan 15, 2026
Collaborator
Author
|
@cknitt changed the PR to move the logic which finds binaries to be shared between client and server. |
cristianoc
force-pushed
the
fix/monorepo-root-compilerlog-watch
branch
from
5c6b12d to
bcbe65a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix monorepo build detection: watch only root .compiler.log; run reanalyze from root