Skip to content

Commit 09f1172

Browse files
committed
change and deprecate
1 parent fa53810 commit 09f1172

File tree

2 files changed

+6
-17
lines changed

2 files changed

+6
-17
lines changed

runtime/Stdlib_ArrayBuffer.res

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,6 @@ type t
44
@new external make: int => t = "ArrayBuffer"
55
@get external byteLength: t => int = "byteLength"
66

7-
@send external slice: (t, ~start: int, ~end: int) => t = "slice"
8-
@send external sliceToEnd: (t, ~start: int) => t = "slice"
7+
@send external slice: (t, ~start: int=?, ~end: int=?) => t = "slice"
8+
9+
@deprecated("Use `slice` instead.") @send external sliceToEnd: (t, ~start: int) => t = "slice"

runtime/Stdlib_ArrayBuffer.resi

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -47,22 +47,10 @@ See [`ArrayBuffer.slice`](https://developer.mozilla.org/en-US/docs/Web/JavaScrip
4747
4848
```rescript
4949
let buffer = ArrayBuffer.make(16)
50-
let sliced = ArrayBuffer.slice(buffer, ~start=4, ~end=12)
50+
let sliced = buffer->ArrayBuffer.slice(~start=4, ~end=12)
5151
ArrayBuffer.byteLength(sliced) == 8
5252
```
5353
*/
54-
@send external slice: (t, ~start: int, ~end: int) => t = "slice"
54+
@send external slice: (t, ~start: int=?, ~end: int=?) => t = "slice"
5555

56-
/**
57-
`sliceToEnd(arrayBuffer, ~start)` returns a new ArrayBuffer whose contents are a copy of this ArrayBuffer's bytes from `start` to the end of the buffer.
58-
See [`ArrayBuffer.slice`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer/slice) on MDN.
59-
60-
## Examples
61-
62-
```rescript
63-
let buffer = ArrayBuffer.make(16)
64-
let sliced = ArrayBuffer.sliceToEnd(buffer, ~start=8)
65-
ArrayBuffer.byteLength(sliced) == 8
66-
```
67-
*/
68-
@send external sliceToEnd: (t, ~start: int) => t = "slice"
56+
@deprecated("Use `slice` instead.") @send external sliceToEnd: (t, ~start: int) => t = "slice"

0 commit comments

Comments
 (0)