Skip to content

Commit 0f8dec5

Browse files
authored
Merge pull request #4299 from BuckleScript/tweak
tweak
2 parents 909fda9 + 53237db commit 0f8dec5

File tree

6 files changed

+26
-12
lines changed

6 files changed

+26
-12
lines changed

jscomp/syntax/bs_builtin_ppx.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ let local_module_name =
344344
let expand_reverse (stru : Ast_structure.t) (acc : Ast_structure.t) : Ast_structure.t =
345345
if stru = [] then acc
346346
else begin
347-
Ext_list.iter stru Typemod_hide.check;
347+
Typemod_hide.check stru;
348348
let local_module_name = local_module_name () in
349349
let last_loc = (List.hd stru).pstr_loc in
350350
let stru = List.rev stru in

jscomp/syntax/typemod_hide.ml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,17 @@ let should_hide ( x : Typedtree.module_binding) =
3333
let attrs : Parsetree.attributes =
3434
[{txt = "internal.local";loc = Location.none}, PStr []]
3535

36-
let check (x : Parsetree.structure_item) =
36+
let check (x : Parsetree.structure) =
37+
Ext_list.iter x (fun x ->
3738
match x.pstr_desc with
3839
| Pstr_eval _
3940
| Pstr_value _
4041
| Pstr_primitive _
4142
| Pstr_typext _
4243
| Pstr_exception _
44+
(* | Pstr_module {pmb_expr = {pmod_desc = Pmod_ident _} } *)
4345
-> ()
46+
4447
| _ ->
4548
Location.raise_errorf ~loc:x.pstr_loc
46-
"the structure is not supported in local extension"
49+
"the structure is not supported in local extension")

jscomp/test/internal_unused_test.ml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,4 +49,6 @@ end
4949

5050
;; Js.log (h 1 2 [@bs])
5151

52+
(* module%private X = Arg
53+
type x = X.spec *)
5254
(* [%%debugger.chrome] *)

lib/4.06.1/unstable/js_compiler.ml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -315028,17 +315028,20 @@ let should_hide ( x : Typedtree.module_binding) =
315028315028
let attrs : Parsetree.attributes =
315029315029
[{txt = "internal.local";loc = Location.none}, PStr []]
315030315030

315031-
let check (x : Parsetree.structure_item) =
315031+
let check (x : Parsetree.structure) =
315032+
Ext_list.iter x (fun x ->
315032315033
match x.pstr_desc with
315033315034
| Pstr_eval _
315034315035
| Pstr_value _
315035315036
| Pstr_primitive _
315036315037
| Pstr_typext _
315037315038
| Pstr_exception _
315039+
(* | Pstr_module {pmb_expr = {pmod_desc = Pmod_ident _} } *)
315038315040
-> ()
315041+
315039315042
| _ ->
315040315043
Location.raise_errorf ~loc:x.pstr_loc
315041-
"the structure is not supported in local extension"
315044+
"the structure is not supported in local extension")
315042315045
end
315043315046
module Bs_builtin_ppx : sig
315044315047
(* Copyright (C) 2015-2016 Bloomberg Finance L.P.
@@ -315460,7 +315463,7 @@ let local_module_name =
315460315463
let expand_reverse (stru : Ast_structure.t) (acc : Ast_structure.t) : Ast_structure.t =
315461315464
if stru = [] then acc
315462315465
else begin
315463-
Ext_list.iter stru Typemod_hide.check;
315466+
Typemod_hide.check stru;
315464315467
let local_module_name = local_module_name () in
315465315468
let last_loc = (List.hd stru).pstr_loc in
315466315469
let stru = List.rev stru in

lib/4.06.1/unstable/js_refmt_compiler.ml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -315028,17 +315028,20 @@ let should_hide ( x : Typedtree.module_binding) =
315028315028
let attrs : Parsetree.attributes =
315029315029
[{txt = "internal.local";loc = Location.none}, PStr []]
315030315030

315031-
let check (x : Parsetree.structure_item) =
315031+
let check (x : Parsetree.structure) =
315032+
Ext_list.iter x (fun x ->
315032315033
match x.pstr_desc with
315033315034
| Pstr_eval _
315034315035
| Pstr_value _
315035315036
| Pstr_primitive _
315036315037
| Pstr_typext _
315037315038
| Pstr_exception _
315039+
(* | Pstr_module {pmb_expr = {pmod_desc = Pmod_ident _} } *)
315038315040
-> ()
315041+
315039315042
| _ ->
315040315043
Location.raise_errorf ~loc:x.pstr_loc
315041-
"the structure is not supported in local extension"
315044+
"the structure is not supported in local extension")
315042315045
end
315043315046
module Bs_builtin_ppx : sig
315044315047
(* Copyright (C) 2015-2016 Bloomberg Finance L.P.
@@ -315460,7 +315463,7 @@ let local_module_name =
315460315463
let expand_reverse (stru : Ast_structure.t) (acc : Ast_structure.t) : Ast_structure.t =
315461315464
if stru = [] then acc
315462315465
else begin
315463-
Ext_list.iter stru Typemod_hide.check;
315466+
Typemod_hide.check stru;
315464315467
let local_module_name = local_module_name () in
315465315468
let last_loc = (List.hd stru).pstr_loc in
315466315469
let stru = List.rev stru in

lib/4.06.1/whole_compiler.ml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -361324,17 +361324,20 @@ let should_hide ( x : Typedtree.module_binding) =
361324361324
let attrs : Parsetree.attributes =
361325361325
[{txt = "internal.local";loc = Location.none}, PStr []]
361326361326

361327-
let check (x : Parsetree.structure_item) =
361327+
let check (x : Parsetree.structure) =
361328+
Ext_list.iter x (fun x ->
361328361329
match x.pstr_desc with
361329361330
| Pstr_eval _
361330361331
| Pstr_value _
361331361332
| Pstr_primitive _
361332361333
| Pstr_typext _
361333361334
| Pstr_exception _
361335+
(* | Pstr_module {pmb_expr = {pmod_desc = Pmod_ident _} } *)
361334361336
-> ()
361337+
361335361338
| _ ->
361336361339
Location.raise_errorf ~loc:x.pstr_loc
361337-
"the structure is not supported in local extension"
361340+
"the structure is not supported in local extension")
361338361341
end
361339361342
module Bs_conditional_initial : sig
361340361343
(* Copyright (C) 2015-2016 Bloomberg Finance L.P.
@@ -412940,7 +412943,7 @@ let local_module_name =
412940412943
let expand_reverse (stru : Ast_structure.t) (acc : Ast_structure.t) : Ast_structure.t =
412941412944
if stru = [] then acc
412942412945
else begin
412943-
Ext_list.iter stru Typemod_hide.check;
412946+
Typemod_hide.check stru;
412944412947
let local_module_name = local_module_name () in
412945412948
let last_loc = (List.hd stru).pstr_loc in
412946412949
let stru = List.rev stru in

0 commit comments

Comments
 (0)