Merge pull request #1024 from bloomberg/clean_up

add a sanitizer to check the invariant of each pass for quality control

Author: bobzhang

jscomp/Makefile

@@ -10,10 +10,10 @@ BYTE=ocamlc.opt$(EXE)
 OCAMLLEX=ocamllex.opt$(EXE)
 CAMLP4OF=camlp4of
 CAMLDEP=ocamldep.opt$(EXE)
-COMPFLAGS= -g -w +6-40-30 -warn-error +a-40-30
+COMPFLAGS= -g -w +6-40-30 -warn-error +a-40-30-23
 
 
-.SUFFIXES: .mli .ml .cmi .cmx .mll
+.SUFFIXES: .mli .ml .cmi .cmx .mll .c .o
 
 print-%  : ; @echo $* = $($*)
 
@@ -187,8 +187,10 @@ SYNTAX_SRCS=ast_derive_constructor ast_derive_util ast_exp ast_external ast_lift
 SYNTAX_CMXS=$(addprefix syntax/, $(addsuffix .cmx, $(SYNTAX_SRCS)))
 DEPENDS_SRCS= depends_post_process bs_exception ast_extract binary_ast  
 DEPENDS_CMXS=$(addprefix depends/, $(addsuffix .cmx, $(DEPENDS_SRCS)))
-CORE_SRCS= type_int_to_string type_util  ocaml_stdlib_slots ident_util bs_conditional_initial ocaml_options ocaml_parse lam\
-	lam_print lam_beta_reduce_util lam_inline_util lam_analysis js_cmj_format js_fun_env js_call_info js_closure js_op js_number js_cmj_datasets\
+CORE_SRCS= type_int_to_string type_util  ocaml_stdlib_slots bs_conditional_initial ocaml_options ocaml_parse lam\
+	lam_print lam_beta_reduce_util lam_inline_util lam_analysis\
+	lam_closure\
+	js_cmj_format js_fun_env js_call_info js_closure js_op js_number js_cmj_datasets\
 	lam_exit_code j lam_module_ident lam_compile_util lam_stats config_util lam_compile_defs js_map js_fold js_fold_basic js_pass_scope\
 	js_op_util js_analyzer js_shake js_exp_make js_long js_of_lam_exception js_of_lam_module js_of_lam_array js_of_lam_block js_of_lam_string\
 	js_of_lam_tuple js_of_lam_record js_of_lam_float_record js_arr lam_compile_const \
@@ -458,6 +460,6 @@ clean:
 	rm -f bsb/bs_json.ml bsb/sexp_lexer.ml core/js_fold.ml core/js_map.ml
 	rm -f common/bs_version.ml
 	rm -rf bin/config_whole_compiler.ml
-	git clean -dfx ext common syntax depends core bsb
+	git clean -dfx stubs ext common syntax depends core bsb
 
 .PHONY: release   releasebuild libs snapshotml force-snapshotml

jscomp/all.depend

@@ -216,7 +216,8 @@ core/lam.cmi : ext/ident_set.cmi
 core/lam_print.cmi : core/lam.cmi
 core/lam_beta_reduce_util.cmi : core/lam.cmi
 core/lam_inline_util.cmi : core/lam.cmi
-core/lam_analysis.cmi : core/lam.cmi ext/ident_set.cmi ext/ident_map.cmi
+core/lam_analysis.cmi : core/lam.cmi
+core/lam_closure.cmi : core/lam.cmi ext/ident_set.cmi ext/ident_map.cmi
 core/js_cmj_format.cmi : ext/string_map.cmi core/lam.cmi \
     common/js_config.cmi
 core/js_fun_env.cmi : ext/ident_set.cmi
@@ -276,7 +277,7 @@ core/js_output.cmi : core/lam_compile_defs.cmi core/lam.cmi core/j.cmx
 core/lam_compile_global.cmi : core/lam_compile_env.cmi core/lam.cmi \
     core/j.cmx
 core/lam_dispatch_primitive.cmi : core/j.cmx
-core/lam_beta_reduce.cmi : core/lam_stats.cmi core/lam_analysis.cmi \
+core/lam_beta_reduce.cmi : core/lam_stats.cmi core/lam_closure.cmi \
     core/lam.cmi ext/ident_map.cmi
 core/lam_compile_external_call.cmi : core/lam_compile_defs.cmi core/j.cmx
 core/lam_compile_primitive.cmi : core/lam_compile_defs.cmi core/lam.cmi \
@@ -293,22 +294,22 @@ core/type_int_to_string.cmx :
 core/type_util.cmx : core/type_int_to_string.cmx common/ext_log.cmx \
     core/type_util.cmi
 core/ocaml_stdlib_slots.cmx :
-core/ident_util.cmx : common/ext_log.cmx
 core/bs_conditional_initial.cmx : common/bs_version.cmx \
     core/bs_conditional_initial.cmi
 core/ocaml_options.cmx : common/bs_version.cmx core/ocaml_options.cmi
 core/ocaml_parse.cmx : syntax/ppx_entry.cmx common/js_config.cmx \
     core/ocaml_parse.cmi
 core/lam.cmx : ext/ordered_hash_map_local_ident.cmx \
     core/ocaml_stdlib_slots.cmx ext/literals.cmx common/js_config.cmx \
-    ext/int_vec_vec.cmx ext/int_vec.cmx ext/ident_set.cmx ext/ext_string.cmx \
-    ext/ext_scc.cmx core/lam.cmi
+    ext/int_vec_vec.cmx ext/int_vec.cmx ext/ident_set.cmx \
+    ext/ident_hash_set.cmx ext/ext_string.cmx ext/ext_scc.cmx core/lam.cmi
 core/lam_print.cmx : core/lam.cmx core/lam_print.cmi
 core/lam_beta_reduce_util.cmx : core/lam.cmx ext/ident_hashtbl.cmx \
     core/lam_beta_reduce_util.cmi
 core/lam_inline_util.cmx : core/lam.cmx core/lam_inline_util.cmi
-core/lam_analysis.cmx : core/lam.cmx ext/ident_set.cmx ext/ident_map.cmx \
-    core/lam_analysis.cmi
+core/lam_analysis.cmx : core/lam.cmx core/lam_analysis.cmi
+core/lam_closure.cmx : core/lam_analysis.cmx core/lam.cmx ext/ident_set.cmx \
+    ext/ident_map.cmx core/lam_closure.cmi
 core/js_cmj_format.cmx : ext/string_map.cmx core/lam.cmx \
     common/js_config.cmx ext/ext_pervasives.cmx core/js_cmj_format.cmi
 core/js_fun_env.cmx : ext/ident_set.cmx ext/ext_list.cmx core/js_fun_env.cmi
@@ -410,11 +411,12 @@ core/lam_stats_util.cmx : core/lam_stats.cmx core/lam_compile_env.cmx \
     core/lam_stats_util.cmi
 core/lam_stats_export.cmx : ext/string_map.cmx core/lam_stats_util.cmx \
     core/lam_stats.cmx core/lam_module_ident.cmx core/lam_inline_util.cmx \
-    core/lam_compile_env.cmx core/lam_analysis.cmx core/lam.cmx \
-    common/js_config.cmx core/js_cmj_format.cmx ext/ident_set.cmx \
-    ext/ident_map.cmx ext/ext_string.cmx ext/ext_pervasives.cmx \
-    ext/ext_option.cmx common/ext_log.cmx ext/ext_list.cmx ext/ext_ident.cmx \
-    ext/ext_filename.cmx core/lam_stats_export.cmi
+    core/lam_compile_env.cmx core/lam_closure.cmx core/lam_analysis.cmx \
+    core/lam.cmx common/js_config.cmx core/js_cmj_format.cmx \
+    ext/ident_set.cmx ext/ident_map.cmx ext/ext_string.cmx \
+    ext/ext_pervasives.cmx ext/ext_option.cmx common/ext_log.cmx \
+    ext/ext_list.cmx ext/ext_ident.cmx ext/ext_filename.cmx \
+    core/lam_stats_export.cmi
 core/lam_pass_alpha_conversion.cmx : core/lam_util.cmx \
     core/lam_stats_util.cmx core/lam_stats.cmx core/lam.cmx ext/ext_list.cmx \
     core/lam_pass_alpha_conversion.cmi
@@ -449,9 +451,9 @@ core/lam_dispatch_primitive.cmx : core/js_stmt_make.cmx \
     core/js_exp_make.cmx common/js_config.cmx core/js_analyzer.cmx core/j.cmx \
     common/ext_log.cmx ext/ext_list.cmx core/lam_dispatch_primitive.cmi
 core/lam_beta_reduce.cmx : core/lam_util.cmx core/lam_stats.cmx \
-    core/lam_compile_global.cmx core/lam_beta_reduce_util.cmx \
-    core/lam_analysis.cmx core/lam.cmx ext/ident_map.cmx \
-    ext/ident_hashtbl.cmx core/lam_beta_reduce.cmi
+    core/lam_compile_global.cmx core/lam_closure.cmx \
+    core/lam_beta_reduce_util.cmx core/lam_analysis.cmx core/lam.cmx \
+    ext/ident_map.cmx ext/ident_hashtbl.cmx core/lam_beta_reduce.cmi
 core/lam_compile_external_call.cmx : core/lam_dispatch_primitive.cmx \
     core/lam_compile_env.cmx core/lam_compile_defs.cmx core/js_op.cmx \
     core/js_of_lam_variant.cmx core/js_of_lam_option.cmx core/js_exp_make.cmx \
@@ -470,13 +472,13 @@ core/lam_compile.cmx : ext/literals.cmx core/lam_util.cmx \
     common/lam_methname.cmx core/lam_exit_code.cmx \
     core/lam_compile_primitive.cmx core/lam_compile_global.cmx \
     core/lam_compile_env.cmx core/lam_compile_defs.cmx \
-    core/lam_compile_const.cmx core/lam_beta_reduce.cmx core/lam_analysis.cmx \
-    core/lam.cmx core/js_stmt_make.cmx core/js_output.cmx \
-    core/js_of_lam_record.cmx core/js_of_lam_array.cmx core/js_exp_make.cmx \
-    common/js_config.cmx core/js_call_info.cmx core/js_ast_util.cmx \
-    core/js_arr.cmx core/js_analyzer.cmx core/j.cmx ext/ident_set.cmx \
-    ext/ident_map.cmx ext/ext_string.cmx ext/ext_list.cmx ext/ext_ident.cmx \
-    core/lam_compile.cmi
+    core/lam_compile_const.cmx core/lam_closure.cmx core/lam_beta_reduce.cmx \
+    core/lam_analysis.cmx core/lam.cmx core/js_stmt_make.cmx \
+    core/js_output.cmx core/js_of_lam_record.cmx core/js_of_lam_array.cmx \
+    core/js_exp_make.cmx common/js_config.cmx core/js_call_info.cmx \
+    core/js_ast_util.cmx core/js_arr.cmx core/js_analyzer.cmx core/j.cmx \
+    ext/ident_set.cmx ext/ident_map.cmx ext/ext_string.cmx ext/ext_list.cmx \
+    ext/ext_ident.cmx core/lam_compile.cmi
 core/lam_pass_exits.cmx : core/lam_util.cmx core/lam_beta_reduce.cmx \
     core/lam_analysis.cmx core/lam.cmx ext/int_hashtbl.cmx ext/ident_map.cmx \
     core/lam_pass_exits.cmi
@@ -485,9 +487,9 @@ core/lam_pass_lets_dce.cmx : core/lam_util.cmx core/lam_beta_reduce.cmx \
     ext/ident_hashtbl.cmx ext/ext_list.cmx core/lam_pass_lets_dce.cmi
 core/lam_pass_remove_alias.cmx : core/lam_util.cmx core/lam_stats.cmx \
     core/lam_module_ident.cmx core/lam_inline_util.cmx \
-    core/lam_compile_env.cmx core/lam_beta_reduce.cmx core/lam_analysis.cmx \
-    core/lam.cmx ext/ident_set.cmx ext/ident_hashtbl.cmx ext/ext_list.cmx \
-    core/lam_pass_remove_alias.cmi
+    core/lam_compile_env.cmx core/lam_closure.cmx core/lam_beta_reduce.cmx \
+    core/lam_analysis.cmx core/lam.cmx ext/ident_set.cmx \
+    ext/ident_hashtbl.cmx ext/ext_list.cmx core/lam_pass_remove_alias.cmi
 core/lam_compile_group.cmx : ext/string_hash_set.cmx core/lam_util.cmx \
     core/lam_stats_export.cmx core/lam_stats.cmx \
     core/lam_pass_remove_alias.cmx core/lam_pass_lets_dce.cmx \

jscomp/bin/whole_compiler.d

@@ -167,6 +167,8 @@ bin/whole_compiler.ml : ext/int_vec_vec.ml
 bin/whole_compiler.ml : ext/int_vec_vec.mli
 bin/whole_compiler.ml : ext/ext_scc.ml
 bin/whole_compiler.ml : ext/ext_scc.mli
+bin/whole_compiler.ml : ext/ident_hash_set.ml
+bin/whole_compiler.ml : ext/ident_hash_set.mli
 bin/whole_compiler.ml : core/ocaml_stdlib_slots.ml
 bin/whole_compiler.ml : ext/ordered_hash_map_gen.ml
 bin/whole_compiler.ml : ext/ordered_hash_map_local_ident.ml
@@ -254,6 +256,8 @@ bin/whole_compiler.ml : core/js_of_lam_record.ml
 bin/whole_compiler.ml : core/js_of_lam_record.mli
 bin/whole_compiler.ml : core/lam_beta_reduce_util.ml
 bin/whole_compiler.ml : core/lam_beta_reduce_util.mli
+bin/whole_compiler.ml : core/lam_closure.ml
+bin/whole_compiler.ml : core/lam_closure.mli
 bin/whole_compiler.ml : core/js_of_lam_module.ml
 bin/whole_compiler.ml : core/js_of_lam_module.mli
 bin/whole_compiler.ml : core/lam_compile_global.ml
@@ -304,8 +308,6 @@ bin/whole_compiler.ml : core/lam_exit_code.ml
 bin/whole_compiler.ml : core/lam_exit_code.mli
 bin/whole_compiler.ml : core/lam_compile.ml
 bin/whole_compiler.ml : core/lam_compile.mli
-bin/whole_compiler.ml : ext/ident_hash_set.ml
-bin/whole_compiler.ml : ext/ident_hash_set.mli
 bin/whole_compiler.ml : core/lam_group.ml
 bin/whole_compiler.ml : core/lam_group.mli
 bin/whole_compiler.ml : core/lam_dce.ml