Skip to content

Commit 22d6299

Browse files
authored
Merge pull request #4943 from rescript-lang/reduce_caml_int32_compare
absorb caml_int32_compare into caml_int_compare
2 parents c915873 + 0457327 commit 22d6299

File tree

10 files changed

+16
-22
lines changed

10 files changed

+16
-22
lines changed

jscomp/core/js_exp_make.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -996,7 +996,7 @@ let rec int_comp (cmp : Lam_compat.comparison) ?comment (e0 : t) (e1 : t) =
996996
expression_desc =
997997
Var (Qualified
998998
({kind = Runtime},
999-
Some ("caml_int_compare" | "caml_int32_compare"))); _},
999+
Some ("caml_int_compare"))); _},
10001000
[l;r], _),
10011001
Number (Int {i = 0l})
10021002
-> int_comp cmp l r (* = 0 > 0 < 0 *)

jscomp/core/lam_dispatch_primitive.ml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ let args_const_unbox_approx_int_two (args : J.expression list) =
5959
*)
6060
let translate loc (prim_name : string)
6161
(args : J.expression list) : J.expression =
62-
let call m =
62+
let [@inline] call m =
6363
E.runtime_call m prim_name args in
6464
begin match prim_name with
6565
| "caml_add_float" ->
@@ -347,9 +347,9 @@ let translate loc (prim_name : string)
347347
end
348348
| "caml_int_compare"
349349
| "caml_int32_compare"
350-
350+
-> E.runtime_call Js_runtime_modules.caml_primitive
351+
"caml_int_compare" args
351352
| "caml_float_compare"
352-
353353
| "caml_string_compare"
354354
->
355355
call Js_runtime_modules.caml_primitive

jscomp/runtime/caml_primitive.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ let caml_bool_compare (x : bool) (y : bool): int =
3131
| true, false -> 1
3232
| false, true -> -1
3333

34-
let caml_int32_compare = caml_int_compare
34+
3535

3636
let caml_float_compare (x : float) (y : float ) =
3737
if x = y then 0

jscomp/runtime/caml_primitive.mli

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ val caml_bool_compare : bool -> bool -> int
3838
val caml_float_compare : float -> float -> int
3939

4040
val caml_string_compare : string -> string -> int
41-
val caml_int32_compare : int -> int -> int
41+
4242

4343

4444
val caml_bool_min : bool selector

lib/4.06.1/unstable/js_compiler.ml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88926,7 +88926,7 @@ let rec int_comp (cmp : Lam_compat.comparison) ?comment (e0 : t) (e1 : t) =
8892688926
expression_desc =
8892788927
Var (Qualified
8892888928
({kind = Runtime},
88929-
Some ("caml_int_compare" | "caml_int32_compare"))); _},
88929+
Some ("caml_int_compare"))); _},
8893088930
[l;r], _),
8893188931
Number (Int {i = 0l})
8893288932
-> int_comp cmp l r (* = 0 > 0 < 0 *)
@@ -109187,7 +109187,7 @@ let args_const_unbox_approx_int_two (args : J.expression list) =
109187109187
*)
109188109188
let translate loc (prim_name : string)
109189109189
(args : J.expression list) : J.expression =
109190-
let call m =
109190+
let [@inline] call m =
109191109191
E.runtime_call m prim_name args in
109192109192
begin match prim_name with
109193109193
| "caml_add_float" ->
@@ -109475,9 +109475,9 @@ let translate loc (prim_name : string)
109475109475
end
109476109476
| "caml_int_compare"
109477109477
| "caml_int32_compare"
109478-
109478+
-> E.runtime_call Js_runtime_modules.caml_primitive
109479+
"caml_int_compare" args
109479109480
| "caml_float_compare"
109480-
109481109481
| "caml_string_compare"
109482109482
->
109483109483
call Js_runtime_modules.caml_primitive

lib/4.06.1/whole_compiler.ml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -378845,7 +378845,7 @@ let rec int_comp (cmp : Lam_compat.comparison) ?comment (e0 : t) (e1 : t) =
378845378845
expression_desc =
378846378846
Var (Qualified
378847378847
({kind = Runtime},
378848-
Some ("caml_int_compare" | "caml_int32_compare"))); _},
378848+
Some ("caml_int_compare"))); _},
378849378849
[l;r], _),
378850378850
Number (Int {i = 0l})
378851378851
-> int_comp cmp l r (* = 0 > 0 < 0 *)
@@ -391593,7 +391593,7 @@ let args_const_unbox_approx_int_two (args : J.expression list) =
391593391593
*)
391594391594
let translate loc (prim_name : string)
391595391595
(args : J.expression list) : J.expression =
391596-
let call m =
391596+
let [@inline] call m =
391597391597
E.runtime_call m prim_name args in
391598391598
begin match prim_name with
391599391599
| "caml_add_float" ->
@@ -391881,9 +391881,9 @@ let translate loc (prim_name : string)
391881391881
end
391882391882
| "caml_int_compare"
391883391883
| "caml_int32_compare"
391884-
391884+
-> E.runtime_call Js_runtime_modules.caml_primitive
391885+
"caml_int_compare" args
391885391886
| "caml_float_compare"
391886-
391887391887
| "caml_string_compare"
391888391888
->
391889391889
call Js_runtime_modules.caml_primitive

lib/es6/caml_primitive.mjs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,14 +129,11 @@ function caml_int32_max(x, y) {
129129
}
130130
}
131131

132-
var caml_int32_compare = caml_int_compare;
133-
134132
export {
135133
caml_int_compare ,
136134
caml_bool_compare ,
137135
caml_float_compare ,
138136
caml_string_compare ,
139-
caml_int32_compare ,
140137
caml_bool_min ,
141138
caml_int_min ,
142139
caml_float_min ,

lib/es6/int32.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ function of_string_opt(s) {
4141
}
4242
}
4343

44-
var compare = Caml_primitive.caml_int32_compare;
44+
var compare = Caml_primitive.caml_int_compare;
4545

4646
function equal(x, y) {
4747
return x === y;

lib/js/caml_primitive.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,13 +129,10 @@ function caml_int32_max(x, y) {
129129
}
130130
}
131131

132-
var caml_int32_compare = caml_int_compare;
133-
134132
exports.caml_int_compare = caml_int_compare;
135133
exports.caml_bool_compare = caml_bool_compare;
136134
exports.caml_float_compare = caml_float_compare;
137135
exports.caml_string_compare = caml_string_compare;
138-
exports.caml_int32_compare = caml_int32_compare;
139136
exports.caml_bool_min = caml_bool_min;
140137
exports.caml_int_min = caml_int_min;
141138
exports.caml_float_min = caml_float_min;

lib/js/int32.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ function of_string_opt(s) {
4141
}
4242
}
4343

44-
var compare = Caml_primitive.caml_int32_compare;
44+
var compare = Caml_primitive.caml_int_compare;
4545

4646
function equal(x, y) {
4747
return x === y;

0 commit comments

Comments
 (0)