Skip to content

Commit 23d80f9

Browse files
committed
Use assertEqual instead of Console.log
1 parent c40bf36 commit 23d80f9

File tree

3 files changed

+30
-31
lines changed

3 files changed

+30
-31
lines changed

runtime/Stdlib_Array.res

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ let last = a => a->get(a->length - 1)
289289
external ignore: array<'a> => unit = "%ignore"
290290

291291
@send
292-
external entries: array<'a> => Stdlib_Iterator.t<'a> = "entries"
292+
external entries: array<'a> => Stdlib_Iterator.t<(int, 'a)> = "entries"
293293

294294
@send
295295
external values: array<'a> => Stdlib_Iterator.t<'a> = "values"

runtime/Stdlib_Array.resi

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1397,13 +1397,13 @@ See [Array.prototype.entries](https://developer.mozilla.org/en-US/docs/Web/JavaS
13971397
13981398
```rescript
13991399
let array = [5, 6, 7]
1400-
let iterator : Iterator.t<int> = array->Array.entries
1401-
Console.log(iterator->Iterator.next) // {done: false, value: [0,5]}
1402-
Console.log(iterator->Iterator.next) // {done: false, value: [1,6]}
1400+
let iterator : Iterator.t<(int, int)> = array->Array.entries
1401+
iterator->Iterator.next->assertEqual({done: false, value: Some((0, 5))})
1402+
iterator->Iterator.next->assertEqual({done: false, value: Some((1, 6))})
14031403
```
14041404
*/
14051405
@send
1406-
external entries: array<'a> => Stdlib_Iterator.t<'a> = "entries"
1406+
external entries: array<'a> => Stdlib_Iterator.t<(int, 'a)> = "entries"
14071407

14081408
/**
14091409
`values(array)` returns a new array iterator object that contains the values for each index in the array.
@@ -1415,8 +1415,8 @@ See [Array.prototype.values](https://developer.mozilla.org/en-US/docs/Web/JavaSc
14151415
```rescript
14161416
let array = [5, 6, 7]
14171417
let iterator : Iterator.t<int> = array->Array.values
1418-
Console.log(iterator->Iterator.next) // {done: false, value: 5}
1419-
Console.log(iterator->Iterator.next) // {done: false, value: 6}
1418+
iterator->Iterator.next->assertEqual({done: false, value: Some(5)})
1419+
iterator->Iterator.next->assertEqual({done: false, value: Some(6)})
14201420
```
14211421
*/
14221422
@send

runtime/Stdlib_Iterator.resi

Lines changed: 23 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ map->Map.set("someKey2", "someValue2")
6161
// `Map.keys` returns all keys of the map as an iterator.
6262
let mapKeysAsArray = map->Map.keys->Iterator.toArray
6363
64-
Console.log(mapKeysAsArray) // Logs ["someKey", "someKey2"] to the console.
64+
mapKeysAsArray->assertEqual(["someKey", "someKey2"])
6565
```
6666
*/
6767
@send
@@ -84,7 +84,7 @@ let mapKeysAsArray = map
8484
->Map.keys
8585
->Iterator.toArrayWithMapper(key => key->String.length)
8686
87-
Console.log(mapKeysAsArray) // Logs [7, 8] to the console.
87+
mapKeysAsArray->assertEqual([7, 8])
8888
```
8989
*/
9090
external toArrayWithMapper: (t<'a>, 'a => 'b) => array<'b> = "Array.from"
@@ -97,13 +97,12 @@ See [iterator protocols](https://developer.mozilla.org/en-US/docs/Web/JavaScript
9797
## Examples
9898
```rescript
9999
let iterator: Iterator.t<string> = ["a", "b", "c"]->Array.values
100+
let acc = ref("")
100101
iterator->Iterator.forEach(v => {
101-
Console.log(v)
102+
acc := acc.contents ++ v
102103
})
103104
104-
// "a"
105-
// "b"
106-
// "c"
105+
acc.contents->assertEqual("abc")
107106
```
108107
*/
109108
@send
@@ -124,11 +123,11 @@ See [Iterator.prototype.drop](https://developer.mozilla.org/en-US/docs/Web/JavaS
124123
125124
## Examples
126125
```rescript
127-
let fibonacci: Iterator.t<int> = [ 1, 1, 2, 3, 5, 8, 13, 21 ]->Array.entries
126+
let fibonacci: Iterator.t<int> = [ 1, 1, 2, 3, 5, 8, 13, 21 ]->Array.values
128127
129128
let seq = fibonacci->Iterator.drop(2)
130-
Console.log(seq->Iterator.next) // {done: false, value: Some(2)}
131-
Console.log(seq->Iterator.next) // {done: false, value: Some(3)}
129+
seq->Iterator.next->assertEqual({done: false, value: Some(2)})
130+
seq->Iterator.next->assertEqual({done: false, value: Some(3)})
132131
```
133132
*/
134133
@send
@@ -141,10 +140,10 @@ See [Iterator.prototype.every](https://developer.mozilla.org/en-US/docs/Web/Java
141140
142141
## Examples
143142
```rescript
144-
let fibonacci: Iterator.t<int> = [ 1, 1, 2, 3, 5, 8, 13, 21 ]->Array.entries
143+
let fibonacci: Iterator.t<int> = [ 1, 1, 2, 3, 5, 8, 13, 21 ]->Array.values
145144
146145
let areAllEven = fibonacci->Iterator.every(n => n % 2 == 0)
147-
Console.log(areAllEven) // false
146+
areAllEven->assertEqual(false)
148147
```
149148
*/
150149
@send
@@ -157,11 +156,11 @@ See [Iterator.prototype.filter](https://developer.mozilla.org/en-US/docs/Web/Jav
157156
158157
## Examples
159158
```rescript
160-
let fibonacci: Iterator.t<int> = [ 1, 1, 2, 3, 5, 8, 13, 21 ]->Array.entries
159+
let fibonacci: Iterator.t<int> = [ 1, 1, 2, 3, 5, 8, 13, 21 ]->Array.values
161160
162161
let seq = fibonacci->Iterator.filter(n => n % 2 == 0)
163-
Console.log(seq->Iterator.next) // {done: false, value: Some(2)}
164-
Console.log(seq->Iterator.next) // {done: false, value: Some(8)}
162+
seq->Iterator.next->assertEqual({done: false, value: Some(2)})
163+
seq->Iterator.next->assertEqual({done: false, value: Some(8)})
165164
```
166165
*/
167166
@send
@@ -174,10 +173,10 @@ See [Iterator.prototype.find](https://developer.mozilla.org/en-US/docs/Web/JavaS
174173
175174
## Examples
176175
```rescript
177-
let fibonacci: Iterator.t<int> = [ 1, 1, 2, 3, 5, 8, 13, 21 ]->Array.entries
176+
let fibonacci: Iterator.t<int> = [ 1, 1, 2, 3, 5, 8, 13, 21 ]->Array.values
178177
179178
let seq = fibonacci->Iterator.find(n => n % 2 == 0)
180-
Console.log(seq) // Some(2)
179+
seq->assertEqual(Some(2))
181180
```
182181
*/
183182
@send
@@ -198,7 +197,7 @@ let letters =
198197
->Array.values
199198
->Iterator.flatMap(m => Map.keys(m))
200199
->Array.fromIterator
201-
Console.log(letters) // ["a", "b", "c", "d", "e", "f"]
200+
letters->assertEqual(["a", "b", "c", "d", "e", "f"])
202201
```
203202
*/
204203
@send
@@ -213,7 +212,7 @@ See [Iterator.prototype.map](https://developer.mozilla.org/en-US/docs/Web/JavaSc
213212
```rescript
214213
let map = Map.fromArray([("a", 1), ("b", 2), ("c", 3)])
215214
let letters = map->Map.keys->Iterator.map(v => v->String.toUpperCase)->Array.fromIterator
216-
Console.log(letters) // ["A", "B", "C"]
215+
letters->assertEqual(["A", "B", "C"])
217216
```
218217
*/
219218
@send
@@ -226,10 +225,10 @@ See [Iterator.prototype.reduce](https://developer.mozilla.org/en-US/docs/Web/Jav
226225
227226
## Examples
228227
```rescript
229-
let numbers: Iterator.t<int> = [ 1, 2, 3 ]->Array.entries
228+
let numbers: Iterator.t<int> = [ 1, 2, 3 ]->Array.values
230229
231230
let sum = numbers->Iterator.reduce((acc, n) => acc + n, ~initialValue=0)
232-
Console.log(sum) // 6
231+
sum->assertEqual(6)
233232
```
234233
*/
235234
@send
@@ -247,7 +246,7 @@ See [Iterator.prototype.some](https://developer.mozilla.org/en-US/docs/Web/JavaS
247246
let numbers: Iterator.t<int> = [ 1, 2, 3 ]->Array.values
248247
249248
let hasEven = numbers->Iterator.some(n => n % 2 == 0)
250-
Console.log(hasEven) // true
249+
hasEven->assertEqual(true)
251250
```
252251
*/
253252
@send
@@ -263,9 +262,9 @@ See [Iterator.prototype.take](https://developer.mozilla.org/en-US/docs/Web/JavaS
263262
let fibonacci: Iterator.t<int> = [ 1, 1, 2, 3, 5, 8, 13, 21 ]->Array.values
264263
265264
let seq = fibonacci->Iterator.take(2)
266-
Console.log(seq->Iterator.next) // {done: false, value: Some(1)}
267-
Console.log(seq->Iterator.next) // {done: false, value: Some(1)}
268-
Console.log(seq->Iterator.next) // {done: true, value: None}
265+
seq->Iterator.next->assertEqual({done: false, value: Some(1)})
266+
seq->Iterator.next->assertEqual({done: false, value: Some(1)})
267+
seq->Iterator.next->assertEqual({done: true, value: None})
269268
```
270269
*/
271270
@send

0 commit comments

Comments
 (0)