Skip to content

Commit 2dbc809

Browse files
committed
Fix comments
1 parent 208edcf commit 2dbc809

File tree

2 files changed

+17
-7
lines changed

2 files changed

+17
-7
lines changed

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ git -C ocaml checkout 4.06.1+BS && node ./scripts/buildocaml.js
7171

7272
Note: clean up is necessary since the binary artifacts between versions of compiler may be incompatible.
7373

74-
### Using esy in development
74+
### Using esy in development (experimental)
7575

7676
You can use [esy](https://esy.sh) to develop bucklescript. By default esy will do "out of source builds" which means that all the changes will happen outside the current directory. To be able to bspack the needed files and get sources that you can commit you will have to change the following in the `esy.json`.
7777

@@ -241,7 +241,7 @@ Since BuckleScript is distributed under the terms of the [LGPL Version 3](LICENS
241241
are licensed under the same terms. In order for us to be able to accept your contributions,
242242
we will need explicit confirmation from you that you are able and willing to provide them under
243243
these terms, and the mechanism we use to do this is called a Developer's Certificate of Origin
244-
[DCO](DCO.md). This is very similar to the process used by the Linux(R) kernel, Samba, and many
244+
[DCO](DCO.md). This is very similar to the process used by the Linux(R) kernel, Samba, and many
245245
other major open source projects.
246246

247247
To participate under these terms, all that you must do is include a line like the following as the

scripts/ninja.js

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ var othersTarget = pseudoTarget("others");
2828
var stdlibTarget = pseudoTarget("$stdlib");
2929

3030
var vendorNinjaPath = path.join(
31+
__dirname,
3132
"..",
3233
"vendor",
3334
"ninja",
@@ -1752,7 +1753,7 @@ function main() {
17521753
switch (subcommand) {
17531754
case "build":
17541755
try {
1755-
cp.execFileSync(path.resolve(jscompDir, vendorNinjaPath), {
1756+
cp.execFileSync(vendorNinjaPath, {
17561757
encoding: "utf8",
17571758
cwd: jscompDir,
17581759
stdio: [0, 1, 2]
@@ -1784,10 +1785,19 @@ function main() {
17841785

17851786
break;
17861787
case "cleanbuild":
1787-
console.log(`run cleaning first`)
1788-
cp.execSync(`node ${__filename} clean`,{cwd:__dirname,stdio:[0,1,2]})
1789-
cp.execSync(`node ${__filename} config`,{cwd:__dirname,stdio:[0,1,2]})
1790-
cp.execSync(`node ${__filename} build`,{cwd:__dirname,stdio:[0,1,2]})
1788+
console.log(`run cleaning first`);
1789+
cp.execSync(`node ${__filename} clean`, {
1790+
cwd: __dirname,
1791+
stdio: [0, 1, 2]
1792+
});
1793+
cp.execSync(`node ${__filename} config`, {
1794+
cwd: __dirname,
1795+
stdio: [0, 1, 2]
1796+
});
1797+
cp.execSync(`node ${__filename} build`, {
1798+
cwd: __dirname,
1799+
stdio: [0, 1, 2]
1800+
});
17911801
break;
17921802
case "docs":
17931803
console.log(`building docs`);

0 commit comments

Comments
 (0)