adding a few user experience enhancments (#5072)

* make CI error easier to spot

* add some note

* remove unused code

* adapt the error message

* fix a few small regressions (include syntax/ocaml repo)

* updates

Author: bobzhang

jscomp/bsb/bsb_exception.ml

@@ -68,7 +68,7 @@ let print (fmt : Format.formatter) (x : error) =
         "File \"bsconfig.json\", line 1\n\
          @{<error>Error:@} package @{<error>%s@} not found or built %s\n\
          - Did you install it?\n\
-         - If you did, did you run `bsb -make-world`?"
+         - If you did, did you run `rescript build -with-deps`?"
         name
         in_json
 

jscomp/build_tests/super_errors/expected/modules1.re.expected

@@ -8,6 +8,6 @@
   The module or file Foo can't be found.
   - If it's a third-party dependency:
     - Did you list it in bsconfig.json?
-    - Did you run `bsb` instead of `bsb -make-world`
+    - Did you run `rescript build` instead of `rescript build -with-deps`
       (latter builds third-parties)?
   - Did you include the file's directory in bsconfig.json?

jscomp/build_tests/super_errors/expected/syntaxErrors1.re.expected

@@ -1,4 +1,4 @@
-File "/.../fixtures/syntaxErrors1.re", line 1, characters 10-12:
+File "/.../fixtures/syntaxErrors1.re", line 1, characters 11-13:
 Error: syntax error, consider adding a `;' before
 
   We've found a bug for you!

jscomp/build_tests/super_errors/expected/syntaxErrors2.re.expected

@@ -1,4 +1,4 @@
-File "/.../fixtures/syntaxErrors2.re", line 2, characters 40-41:
+File "/.../fixtures/syntaxErrors2.re", line 2, characters 41-42:
 Error: Syntax error
 
   We've found a bug for you!

jscomp/build_tests/super_errors/expected/syntaxErrors3.re.expected

@@ -1,4 +1,4 @@
-File "/.../fixtures/syntaxErrors3.re", line 1, characters 19-20:
+File "/.../fixtures/syntaxErrors3.re", line 1, characters 20-21:
 Error: Unclosed "(" (opened line 1, column 18)
 
   We've found a bug for you!

jscomp/build_tests/super_errors/expected/syntaxErrors5.re.expected

@@ -1,4 +1,4 @@
-File "/.../fixtures/syntaxErrors5.re", line 2, characters 0-0:
+File "/.../fixtures/syntaxErrors5.re", line 2, characters 1-1:
 Error: Unclosed "(" (opened line 1, column 8)
 
   We've found a bug for you!

jscomp/main/builtin_cmj_datasets.ml

@@ -69,7 +69,7 @@ let report_error env ppf = function
                               @{<info>The module or file %a can't be found.@}@,\
                               @[<v 2>- If it's a third-party dependency:@,\
                               - Did you list it in bsconfig.json?@,\
-                              - @[Did you run `bsb` instead of `bsb -make-world`@ (latter builds third-parties)@]?\
+                              - @[Did you run `rescript build` instead of `rescript build -with-deps`@ (latter builds third-parties)@]?\
                               @]@,\
                               - Did you include the file's directory in bsconfig.json?@]\
                               @]"

jscomp/super_errors/super_typetexp.ml

@@ -18,8 +18,8 @@ function f(x, y) {
   return x + y | 0;
 }
 
-function add(prim, prim$1) {
-  return prim + prim$1 | 0;
+function add(prim0, prim1) {
+  return prim0 + prim1 | 0;
 }
 
 function h(u) {

jscomp/test/arity.js

@@ -250,8 +250,8 @@ var array_suites_1 = {
                                 26,
                                 27,
                                 28
-                              ], (function (prim, prim$1) {
-                                  return prim === prim$1;
+                              ], (function (prim0, prim1) {
+                                  return prim0 === prim1;
                                 }))
                         };
                 })
@@ -294,8 +294,8 @@ var array_suites_1 = {
                                   18,
                                   19,
                                   20
-                                ], (function (prim, prim$1) {
-                                    return prim === prim$1;
+                                ], (function (prim0, prim1) {
+                                    return prim0 === prim1;
                                   }))
                           };
                   })