[Belt] Change ofArray to fromArray, and ofFoo to fromFoo in general (#2590)

* [Belt] Change ofArray to fromArray, and ofFoo to fromFoo in general

Discussed offline. Easier API to guess. Only changed the externally visible APIs.

Didn't check in the JS files; too much noise for now.

* Change internal ofFoo to fromFoo too

* One last ofArray*

* Update tests

* Check in js artifacts to make tests pass

Author: chenglou

jscomp/others/belt_HashMap.ml

@@ -201,7 +201,7 @@ let make (type key) (type identity) ~hintSize ~(id : (key,identity) id) =
   C.make ~hash:M.hash ~eq:M.eq  ~hintSize
 
 
-let ofArray (type a) (type identity) arr ~id:(id:(a,identity) id) =     
+let fromArray (type a) (type identity) arr ~id:(id:(a,identity) id) =     
   let module M = (val id) in
   let hash, eq = M.hash, M.eq in  
   let len = A.length arr in 
@@ -212,6 +212,8 @@ let ofArray (type a) (type identity) arr ~id:(id:(a,identity) id) =
     set0 ~eq ~hash v key value
   done ;
   v
+
+let ofArray = fromArray
 
 let mergeMany h arr = 
   let hash, eq = Belt_Id.getHashInternal ( C.hash h) , Belt_Id.getEqInternal (C.eq h) in 

jscomp/others/belt_HashMap.mli

@@ -149,9 +149,11 @@ val size: _ t -> int
 val toArray: ('key, 'value, 'id ) t -> ('key * 'value) array 
 val keysToArray: ('key, _, _) t -> 'key array    
 val valuesToArray: (_,'value,_) t -> 'value array    
-val ofArray: ('key * 'value) array -> id:('key,'id) id -> ('key, 'value, 'id ) t    
+val fromArray: ('key * 'value) array -> id:('key,'id) id -> ('key, 'value, 'id ) t    
 val mergeMany: ('key, 'value, 'id ) t -> ('key * 'value) array -> unit
 val getBucketHistogram: _ t -> int array
 val logStats: _ t -> unit
 
+val ofArray: ('key * 'value) array -> id:('key,'id) id -> ('key, 'value, 'id ) t    
+[@@ocaml.deprecated "Use fromArray instead"]
 

jscomp/others/belt_HashMapInt.ml

@@ -187,7 +187,7 @@ let valuesToArray = N.valuesToArray
 let getBucketHistogram = N.getBucketHistogram 
 let isEmpty = C.isEmpty
 
-let ofArray arr  = 
+let fromArray arr = 
   let len = A.length arr in 
   let v = make len in 
   for i = 0 to len - 1 do 
@@ -196,6 +196,8 @@ let ofArray arr  =
   done ;
   v
 
+let ofArray = fromArray
+
 (* TOOD: optimize heuristics for resizing *)  
 let mergeMany h arr =   
   let len = A.length arr in 

jscomp/others/belt_HashMapInt.mli

@@ -42,7 +42,10 @@ val size: _ t -> int
 val toArray: 'a t -> (key * 'a) array
 val keysToArray: 'a t -> key array
 val valuesToArray: 'a t -> 'a array
-val ofArray: (key * 'a) array -> 'a t
+val fromArray: (key * 'a) array -> 'a t
 val mergeMany: 'a t -> (key * 'a) array -> unit
 val getBucketHistogram: _ t -> int array
 val logStats: _ t -> unit
+
+val ofArray: (key * 'a) array -> 'a t
+[@@ocaml.deprecated "Use fromArray instead"]

jscomp/others/belt_HashMapString.ml

@@ -187,7 +187,7 @@ let valuesToArray = N.valuesToArray
 let getBucketHistogram = N.getBucketHistogram 
 let isEmpty = C.isEmpty
 
-let ofArray arr  = 
+let fromArray arr = 
   let len = A.length arr in 
   let v = make len in 
   for i = 0 to len - 1 do 
@@ -196,6 +196,8 @@ let ofArray arr  =
   done ;
   v
 
+let ofArray = fromArray
+
 (* TOOD: optimize heuristics for resizing *)  
 let mergeMany h arr =   
   let len = A.length arr in 

jscomp/others/belt_HashMapString.mli

@@ -42,7 +42,10 @@ val size: _ t -> int
 val toArray: 'a t -> (key * 'a) array
 val keysToArray: 'a t -> key array
 val valuesToArray: 'a t -> 'a array
-val ofArray: (key * 'a) array -> 'a t
+val fromArray: (key * 'a) array -> 'a t
 val mergeMany: 'a t -> (key * 'a) array -> unit
 val getBucketHistogram: _ t -> int array
 val logStats: _ t -> unit
+
+val ofArray: (key * 'a) array -> 'a t
+[@@ocaml.deprecated "Use fromArray instead"]

jscomp/others/belt_HashSet.ml

@@ -176,7 +176,7 @@ let copy = N.copy
 let getBucketHistogram  = N.getBucketHistogram 
 let isEmpty  = C.isEmpty
 
-let ofArray (type a) (type identity) arr ~(id:(a,identity) id)  =     
+let fromArray (type a) (type identity) arr ~(id:(a,identity) id)  =     
   let module M = (val id) in 
   let eq, hash = M.eq , M.hash in 
     let len = A.length arr in 
@@ -186,6 +186,7 @@ let ofArray (type a) (type identity) arr ~(id:(a,identity) id)  =
   done ;
   v
 
+let ofArray = fromArray
 
 let mergeMany h arr = 
   let eq, hash = C.eq h, C.hash h in 

jscomp/others/belt_HashSet.mli

@@ -117,6 +117,9 @@ val logStats: _ t -> unit
 val toArray: ('a,'id) t -> 'a array 
 
 val ofArray: 'a array -> id:('a,'id) id -> ('a,'id) t 
+[@@ocaml.deprecated "Use fromArray instead"]
+
+val fromArray: 'a array -> id:('a,'id) id -> ('a,'id) t 
 
 val mergeMany: ('a,'id) t -> 'a array -> unit
 

jscomp/others/belt_HashSetInt.ml

@@ -138,14 +138,16 @@ let copy = N.copy
 let getBucketHistogram = N.getBucketHistogram 
 let isEmpty = C.isEmpty
 
-let ofArray arr  = 
+let fromArray arr = 
   let len = A.length arr in 
   let v = C.make ~hintSize:len ~hash:() ~eq:() in 
   for i = 0 to len - 1 do 
     add v (A.getUnsafe arr i)
   done ;
   v
 
+let ofArray = fromArray
+
 (* TOOD: optimize heuristics for resizing *)  
 let mergeMany h arr =   
   let len = A.length arr in 

jscomp/others/belt_HashSetInt.mli

@@ -67,6 +67,9 @@ val logStats: t -> unit
 val toArray: t -> key array 
 
 val ofArray: key array -> t 
+[@@ocaml.deprecated "Use fromArray instead"]
+
+val fromArray: key array -> t 
 
 val mergeMany: t -> key array -> unit