Clean up dump logs

Author: nojaf

analysis/src/CompletionBackEnd.ml

@@ -352,9 +352,7 @@ let findAllCompletions ~(env : QueryEnv.t) ~prefix ~exact ~namesUsed
 
 let processLocalValue name loc contextPath scope ~prefix ~exact ~env
     ~(localTables : LocalTables.t) =
-  if Utils.checkName name ~prefix ~exact then (
-    print_endline
-      ("processLocalValue name: " ^ name ^ " loc: " ^ Loc.toString loc);
+  if Utils.checkName name ~prefix ~exact then
     match Hashtbl.find_opt localTables.valueTable (name, Loc.start loc) with
     | Some declared ->
       if not (Hashtbl.mem localTables.namesUsed name) then (
@@ -381,7 +379,7 @@ let processLocalValue name loc contextPath scope ~prefix ~exact ~env
                 (Ctype.newconstr
                    (Path.Pident (Ident.create "Type Not Known"))
                    []))
-        :: localTables.resultRev)
+        :: localTables.resultRev
 
 let processLocalConstructor name loc ~prefix ~exact ~env
     ~(localTables : LocalTables.t) =
@@ -564,13 +562,12 @@ let findLocalCompletionsForModules ~(localTables : LocalTables.t) ~env ~prefix
 let findLocalCompletionsWithOpens ~pos ~(env : QueryEnv.t) ~prefix ~exact ~opens
     ~scope ~(completionContext : Completable.completionContext) =
   (* TODO: handle arbitrary interleaving of opens and local bindings correctly *)
-  print_endline
+  Log.log
     ("findLocalCompletionsWithOpens uri:" ^ Uri.toString env.file.uri ^ " pos:"
    ^ Pos.toString pos);
   let localTables = LocalTables.create () in
   match completionContext with
   | Value | ValueOrField ->
-    print_endline "Value or Field";
     findLocalCompletionsForValuesAndConstructors ~localTables ~env ~prefix
       ~exact ~opens ~scope
   | Type ->
@@ -616,16 +613,6 @@ let getCompletionsForPath ~debug ~opens ~full ~pos ~exact ~scope
       findLocalCompletionsWithOpens ~pos ~env ~prefix ~exact ~opens ~scope
         ~completionContext
     in
-    print_endline
-      ("localCompletionsWithOpens: "
-      ^ (List.map
-           (fun c ->
-             match c.Completion.sortText with
-             | None -> c.Completion.name
-             | Some insertText -> c.Completion.name ^ " " ^ insertText)
-           localCompletionsWithOpens
-        |> String.concat ","));
-
     let fileModules =
       allFiles |> FileSet.elements
       |> Utils.filterMap (fun name ->
@@ -789,7 +776,7 @@ let completionsGetCompletionType ~full completions =
   | _ -> None
 
 (**
-  Returns completions from the current module where `include OtherModule` is present.
+  Returns completions from the current module where `include OtherModule()` is present.
 *)
 let completionsFromIncludedModule ~full ~env ~pos =
   (* Get the path of the module where the cursor is.*)
@@ -808,10 +795,8 @@ let completionsFromIncludedModule ~full ~env ~pos =
            let ownerPath =
              ModulePath.toPathWithPrefix ownerPath full.file.File.moduleName
            in
-           Format.printf "ownerPath: %s \n" (ownerPath |> String.concat ".");
-           if ownerPath = ownModule then (
-             print_endline "hit";
-             Some (Completion.create name.txt ~env ~kind:(Value item)))
+           if ownerPath = ownModule then
+             Some (Completion.create name.txt ~env ~kind:(Value item))
            else None
          | _ -> None)
 

tests/analysis_tests/tests/src/expected/DotPipeCompleteFromCurrentModule.res.txt

@@ -30,3 +30,77 @@ Path
       }]
   }]
 
+Complete src/DotPipeCompleteFromCurrentModule.res 60:17
+posCursor:[60:17] posNoWhite:[60:16] Found expr:[58:15->63:5]
+posCursor:[60:17] posNoWhite:[60:16] Found expr:[59:8->62:9]
+posCursor:[60:17] posNoWhite:[60:16] Found expr:[60:15->60:17]
+Pexp_field [60:15->60:16] _:[62:8->60:17]
+Completable: Cpath Value[k].""
+Package opens Stdlib.place holder Pervasives.JsxModules.place holder
+Resolved opens 1 Stdlib
+ContextPath Value[k].""
+ContextPath Value[k]
+Path k
+ContextPath Value[k]->
+ContextPath Value[k]
+Path k
+CPPipe pathFromEnv:Types found:true
+Path Types.
+Path 
+[{
+    "label": "->addPosFromVec2",
+    "kind": 12,
+    "tags": [],
+    "detail": "(Types.context, Types.vec2) => Types.comp",
+    "documentation": null,
+    "sortText": "addPosFromVec2",
+    "insertText": "->addPosFromVec2",
+    "additionalTextEdits": [{
+      "range": {"start": {"line": 60, "character": 16}, "end": {"line": 60, "character": 17}},
+      "newText": ""
+      }]
+  }, {
+    "label": "->addPos",
+    "kind": 12,
+    "tags": [],
+    "detail": "(Types.context, float, float) => Types.comp",
+    "documentation": null,
+    "sortText": "addPos",
+    "insertText": "->addPos",
+    "additionalTextEdits": [{
+      "range": {"start": {"line": 60, "character": 16}, "end": {"line": 60, "character": 17}},
+      "newText": ""
+      }]
+  }]
+
+Complete src/DotPipeCompleteFromCurrentModule.res 72:21
+posCursor:[72:21] posNoWhite:[72:20] Found expr:[70:19->75:9]
+posCursor:[72:21] posNoWhite:[72:20] Found expr:[71:12->74:13]
+posCursor:[72:21] posNoWhite:[72:20] Found expr:[72:19->72:21]
+Pexp_field [72:19->72:20] _:[74:12->72:21]
+Completable: Cpath Value[k].""
+Package opens Stdlib.place holder Pervasives.JsxModules.place holder
+Resolved opens 1 Stdlib
+ContextPath Value[k].""
+ContextPath Value[k]
+Path k
+ContextPath Value[k]->
+ContextPath Value[k]
+Path k
+CPPipe pathFromEnv:Types found:true
+Path Types.
+Path 
+[{
+    "label": "->addSprite",
+    "kind": 12,
+    "tags": [],
+    "detail": "(Types.context, string) => Types.comp",
+    "documentation": null,
+    "sortText": "addSprite",
+    "insertText": "->addSprite",
+    "additionalTextEdits": [{
+      "range": {"start": {"line": 72, "character": 20}, "end": {"line": 72, "character": 21}},
+      "newText": ""
+      }]
+  }]
+