Don't use ghost location in jsx transform (#7533)

* Don't use ghost location in jsx transform

* Add changelog

* Update analysis snapshot

Author: nojaf

CHANGELOG.md

@@ -25,6 +25,7 @@
 - Treat `throw` like `raise` in analysis. https://github.com/rescript-lang/rescript/pull/7521
 - Fix `index out of bounds` exception thrown in rare cases by `rescript-editor-analysis.exe codeAction` command. https://github.com/rescript-lang/rescript/pull/7523
 - Don't produce duplicate type definitions for recursive types on hover. https://github.com/rescript-lang/rescript/pull/7524
+- Prop punning when types don't match results in I/O error: _none_: No such file or directory. https://github.com/rescript-lang/rescript/pull/7533
 
 #### :nail_care: Polish
 

compiler/syntax/src/jsx_v4.ml

@@ -1131,7 +1131,7 @@ let mk_record_from_props mapper (jsx_expr_loc : Location.t) (props : jsx_props)
       {
         loc_start = first_item.loc_start;
         loc_end = last_item.loc_end;
-        loc_ghost = true;
+        loc_ghost = false;
       }
   in
   (* key should be filtered out *)
@@ -1156,7 +1156,7 @@ let mk_record_from_props mapper (jsx_expr_loc : Location.t) (props : jsx_props)
          | JSXPropPunning (is_optional, name) ->
            {
              lid = {txt = Lident name.txt; loc = name.loc};
-             x = Exp.ident {txt = Lident name.txt; loc = name.loc};
+             x = Exp.ident ~loc:name.loc {txt = Lident name.txt; loc = name.loc};
              opt = is_optional;
            }
          | JSXPropValue (name, is_optional, value) ->
@@ -1303,7 +1303,6 @@ let expr ~(config : Jsx_common.jsx_config) mapper expression =
    pexp_loc = loc;
    pexp_attributes = attrs;
   } -> (
-    let loc = {loc with loc_ghost = true} in
     match jsx_element with
     | Jsx_fragment {jsx_fragment_children = children} ->
       let fragment =

tests/analysis_tests/tests/src/expected/Fragment.res.txt

@@ -2,9 +2,5 @@ Hover src/Fragment.res 6:19
 {"contents": {"kind": "markdown", "value": "```rescript\nReact.component<SectionHeader.props<React.element>>\n```\n\n---\n\n```\n \n```\n```rescript\ntype React.component<'props> = Jsx.component<'props>\n```\nGo to: [Type definition](command:rescript-vscode.go_to_location?%5B%22React.res%22%2C12%2C0%5D)\n\n\n---\n\n```\n \n```\n```rescript\ntype SectionHeader.props<'children> = {children: 'children}\n```\nGo to: [Type definition](command:rescript-vscode.go_to_location?%5B%22Fragment.res%22%2C1%2C2%5D)\n\n\n---\n\n```\n \n```\n```rescript\ntype React.element = Jsx.element\n```\nGo to: [Type definition](command:rescript-vscode.go_to_location?%5B%22React.res%22%2C0%2C0%5D)\n"}}
 
 Hover src/Fragment.res 9:56
-Nothing at that position. Now trying to use completion.
-posCursor:[9:56] posNoWhite:[9:55] Found expr:[9:9->9:70]
-posCursor:[9:56] posNoWhite:[9:55] Found expr:[9:12->9:66]
-JSX <SectionHeader:[9:13->9:26] > _children:9:29
-null
+{"contents": {"kind": "markdown", "value": "```rescript\nReact.component<React.fragmentProps>\n```\n\n---\n\n```\n \n```\n```rescript\ntype React.component<'props> = Jsx.component<'props>\n```\nGo to: [Type definition](command:rescript-vscode.go_to_location?%5B%22React.res%22%2C12%2C0%5D)\n\n\n---\n\n```\n \n```\n```rescript\ntype React.fragmentProps = {children?: element}\n```\nGo to: [Type definition](command:rescript-vscode.go_to_location?%5B%22React.res%22%2C41%2C0%5D)\n"}}
 

tests/build_tests/super_errors/expected/wrong_type_prop_punning.res.expected

@@ -0,0 +1,12 @@
+
+  We've found a bug for you!
+  /.../fixtures/wrong_type_prop_punning.res:21:13-20
+
+  19 │   @react.component
+  20 │   let make = (~someProp: array<int>) => {
+  21 │     <Level2 someProp />
+  22 │   }
+  23 │ }
+
+  This has type: array<int>
+  But it's expected to have type: float

tests/build_tests/super_errors/fixtures/wrong_type_prop_punning.res

@@ -0,0 +1,23 @@
+module React = {
+  type element = Jsx.element
+  @val external null: element = "null"
+  type componentLike<'props, 'return> = Jsx.componentLike<'props, 'return>
+  type component<'props> = Jsx.component<'props>
+  external component: componentLike<'props, element> => component<'props> = "%identity"
+  @module("react/jsx-runtime")
+  external jsx: (component<'props>, 'props) => element = "jsx"
+}
+
+module Level2 = {
+  @react.component
+  let make = (~someProp: float) => {
+    React.null
+  }
+}
+
+module Level1 = {
+  @react.component
+  let make = (~someProp: array<int>) => {
+    <Level2 someProp />
+  }
+}