Skip to content

Commit 5aa5ca5

Browse files
cknittcristianoc
authored andcommitted
Fix dependency in Jsx module
1 parent 81849d9 commit 5aa5ca5

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

jscomp/others/jsx.ml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,7 @@ external component : ('props, element) componentLike -> 'props component
3939
= "%identity"
4040

4141
let addKeyProp (o : 't) (k : string) =
42-
Obj.magic (Js.Obj.assign (Obj.magic o) [%obj { key = k }])
42+
(* Use Js_obj.assign, not Js.Obj.assign, otherwise the dependency will not be picked up correctly
43+
in the ninja file. *)
44+
Obj.magic (Js_obj.assign (Obj.magic o) [%obj { key = k }])
4345
[@@inline]

jscomp/others/release.ninja

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ o others/js_vector.cmj : cc_cmi others/js_vector.ml | others/belt_internals.cmi
6363
o others/js_vector.cmi : cc others/js_vector.mli | others/belt_internals.cmi others/js.cmi $bsc
6464
o others/js_weakmap.cmi others/js_weakmap.cmj : cc others/js_weakmap.ml | others/belt_internals.cmi others/js.cmi $bsc
6565
o others/js_weakset.cmi others/js_weakset.cmj : cc others/js_weakset.ml | others/belt_internals.cmi others/js.cmi $bsc
66-
o others/jsx.cmi others/jsx.cmj : cc others/jsx.ml | others/belt_internals.cmi others/js.cmi others/js.cmj $bsc
66+
o others/jsx.cmi others/jsx.cmj : cc others/jsx.ml | others/belt_internals.cmi others/js.cmi others/js_obj.cmj $bsc
6767
o others/jsxDOM.cmi others/jsxDOM.cmj : cc others/jsxDOM.ml | others/belt_internals.cmi others/js.cmi others/jsx.cmj others/jsxDOMStyle.cmj others/jsxEvent.cmj $bsc
6868
o others/jsxDOMStyle.cmi others/jsxDOMStyle.cmj : cc others/jsxDOMStyle.ml | others/belt_internals.cmi others/js.cmi $bsc
6969
o others/jsxEvent.cmi others/jsxEvent.cmj : cc others/jsxEvent.ml | others/belt_internals.cmi others/js.cmi $bsc

0 commit comments

Comments
 (0)