Skip to content

Commit 6121f26

Browse files
committed
remove bsb_dir_group
1 parent f99a4b4 commit 6121f26

File tree

4 files changed

+13
-12
lines changed

4 files changed

+13
-12
lines changed

jscomp/bsb/bsb_build_schemas.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ let dev = "dev"
6161
let export_all = "all"
6262
let export_none = "none"
6363

64-
let bsb_dir_group = "bsb_dir_group"
64+
6565
let g_lib_incls = "g_lib_incls"
6666
let use_stdlib = "use-stdlib"
6767
let reason = "reason"

jscomp/bsb/bsb_ninja_file_groups.ml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -110,12 +110,7 @@ let emit_module_build
110110
oc
111111
~outputs:[output_d]
112112
~inputs:(if has_intf_file then [output_mlast;output_mliast] else [output_mlast] )
113-
~rule:rules.build_bin_deps
114-
?shadows:(if is_dev then
115-
Some [{Bsb_ninja_targets.key = Bsb_build_schemas.bsb_dir_group ;
116-
op =
117-
Overwrite "-g" }]
118-
else None)
113+
~rule:(if is_dev then rules.build_bin_deps_dev else rules.build_bin_deps)
119114
;
120115
if has_intf_file then begin
121116
Bsb_ninja_targets.output_build oc

jscomp/bsb/bsb_ninja_rule.ml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ type builtin = {
9494
copy_resources : t;
9595
(** Rules below all need restat *)
9696
build_bin_deps : t ;
97-
97+
build_bin_deps_dev : t;
9898
ml_cmj_js : t;
9999
ml_cmj_js_dev : t;
100100
ml_cmj_cmi_js : t ;
@@ -194,8 +194,14 @@ let make_custom_rules
194194
define
195195
~restat:()
196196
~command:
197-
("$bsdep -hash " ^ digest ^" $g_ns $bsb_dir_group $in")
198-
"build_deps" in
197+
("$bsdep -hash " ^ digest ^" $g_ns $in")
198+
"mk_deps" in
199+
let build_bin_deps_dev =
200+
define
201+
~restat:()
202+
~command:
203+
("$bsdep -g -hash " ^ digest ^" $g_ns $in")
204+
"mk_deps_dev" in
199205
let aux ~name ~read_cmi ~postbuild =
200206
let postbuild = has_postbuild && postbuild in
201207
define
@@ -239,7 +245,7 @@ let make_custom_rules
239245
copy_resources;
240246
(** Rules below all need restat *)
241247
build_bin_deps ;
242-
248+
build_bin_deps_dev;
243249
ml_cmj_js ;
244250
ml_cmj_js_dev ;
245251
ml_cmj_cmi_js ;

jscomp/bsb/bsb_ninja_rule.mli

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ type builtin = {
4545
copy_resources : t;
4646
(** Rules below all need restat *)
4747
build_bin_deps : t ;
48-
48+
build_bin_deps_dev : t ;
4949
ml_cmj_js : t;
5050
ml_cmj_js_dev : t;
5151
ml_cmj_cmi_js : t ;

0 commit comments

Comments
 (0)