Skip to content

Commit 6670169

Browse files
authored
Merge pull request #1039 from bloomberg/clean_up
clean up the logic of coercion handling and export identifiers calculation
2 parents 19aac2f + 07eebae commit 6670169

File tree

7 files changed

+341
-290
lines changed

7 files changed

+341
-290
lines changed

jscomp/.merlin

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,4 @@ S depends
2424
B depends
2525
PKG compiler-libs.common
2626
B +compiler-libs
27-
FLG -w -40-30+6
27+
FLG -w -40-30+6-23

jscomp/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ BYTE=ocamlc.opt$(EXE)
1010
OCAMLLEX=ocamllex.opt$(EXE)
1111
CAMLP4OF=camlp4of
1212
CAMLDEP=ocamldep.opt$(EXE)
13-
COMPFLAGS= -g -w +6-40-30 -warn-error +a-40-30-23
13+
COMPFLAGS= -g -w +6-40-30-23 -warn-error +a-40-30-23
1414

1515

1616
.SUFFIXES: .mli .ml .cmi .cmx .mll .c .o

jscomp/all.depend

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -511,25 +511,24 @@ core/lam_pass_remove_alias.cmx : core/lam_util.cmx core/lam_stats.cmx \
511511
core/lam_compile_env.cmx core/lam_closure.cmx core/lam_beta_reduce.cmx \
512512
core/lam_analysis.cmx core/lam.cmx ext/ident_set.cmx \
513513
ext/ident_hashtbl.cmx ext/ext_list.cmx core/lam_pass_remove_alias.cmi
514-
core/lam_coercion.cmx : core/lam_group.cmx core/lam_dce.cmx core/lam.cmx \
515-
ext/ident_set.cmx ext/ident_map.cmx core/lam_coercion.cmi
516-
core/lam_compile_group.cmx : ext/string_hash_set.cmx core/lam_util.cmx \
517-
core/lam_stats_export.cmx core/lam_stats.cmx \
518-
core/lam_pass_remove_alias.cmx core/lam_pass_lets_dce.cmx \
519-
core/lam_pass_exits.cmx core/lam_pass_deep_flatten.cmx \
520-
core/lam_pass_collect.cmx core/lam_pass_alpha_conversion.cmx \
521-
core/lam_module_ident.cmx core/lam_group.cmx core/lam_compile_env.cmx \
522-
core/lam_compile_defs.cmx core/lam_compile.cmx core/lam_coercion.cmx \
523-
core/lam_analysis.cmx core/lam.cmx core/js_stmt_make.cmx \
524-
core/js_shake.cmx core/js_program_loader.cmx \
525-
core/js_pass_tailcall_inline.cmx core/js_pass_scope.cmx \
526-
core/js_pass_flatten_and_mark_dead.cmx core/js_pass_flatten.cmx \
527-
core/js_pass_debug.cmx core/js_output.cmx core/js_fold_basic.cmx \
528-
core/js_exp_make.cmx core/js_dump.cmx common/js_config.cmx \
529-
core/js_cmj_format.cmx core/j.cmx ext/ident_set.cmx \
514+
core/lam_coercion.cmx : ext/string_hash_set.cmx core/lam_group.cmx \
515+
core/lam_dce.cmx core/lam.cmx ext/ident_set.cmx ext/ident_map.cmx \
516+
depends/bs_exception.cmx core/lam_coercion.cmi
517+
core/lam_compile_group.cmx : core/lam_util.cmx core/lam_stats_export.cmx \
518+
core/lam_stats.cmx core/lam_pass_remove_alias.cmx \
519+
core/lam_pass_lets_dce.cmx core/lam_pass_exits.cmx \
520+
core/lam_pass_deep_flatten.cmx core/lam_pass_collect.cmx \
521+
core/lam_pass_alpha_conversion.cmx core/lam_module_ident.cmx \
522+
core/lam_group.cmx core/lam_compile_env.cmx core/lam_compile_defs.cmx \
523+
core/lam_compile.cmx core/lam_coercion.cmx core/lam_analysis.cmx \
524+
core/lam.cmx core/js_stmt_make.cmx core/js_shake.cmx \
525+
core/js_program_loader.cmx core/js_pass_tailcall_inline.cmx \
526+
core/js_pass_scope.cmx core/js_pass_flatten_and_mark_dead.cmx \
527+
core/js_pass_flatten.cmx core/js_pass_debug.cmx core/js_output.cmx \
528+
core/js_fold_basic.cmx core/js_exp_make.cmx core/js_dump.cmx \
529+
common/js_config.cmx core/js_cmj_format.cmx core/j.cmx ext/ident_set.cmx \
530530
ext/ext_pervasives.cmx common/ext_log.cmx ext/ext_list.cmx \
531-
ext/ext_ident.cmx ext/ext_filename.cmx depends/bs_exception.cmx \
532-
core/lam_compile_group.cmi
531+
ext/ext_ident.cmx ext/ext_filename.cmx core/lam_compile_group.cmi
533532
core/js_implementation.cmx : core/ocaml_parse.cmx ext/literals.cmx \
534533
core/lam_compile_group.cmx core/lam_compile_env.cmx common/js_config.cmx \
535534
ext/ext_pervasives.cmx common/ext_log.cmx syntax/bs_ast_invariant.cmx \

0 commit comments

Comments
 (0)