tweak

Author: bobzhang

jscomp/core/js_pass_scope.ml

@@ -119,20 +119,20 @@ let scope_pass  =
     (** check if in loop or not *)    
     val in_loop = false 
 
-    method get_in_loop = in_loop
+    (* method get_in_loop = in_loop *)
 
     method get_defined_idents = defined_idents
 
     method get_used_idents = used_idents
 
     method get_loop_mutable_values = loop_mutable_values 
 
-    method get_mutable_values = mutable_values 
+    (* method get_mutable_values = mutable_values  *)
 
     method get_closured_idents = closured_idents 
 
     method with_in_loop b = 
-      if b = self#get_in_loop then self
+      if b = in_loop then self
       else {< in_loop = b >}
      (* Since it's loop mutable variable, for sure
          it is mutable variable
@@ -207,7 +207,7 @@ let scope_pass  =
       match x with
       | { ident ; value; property  }  -> 
         let obj = 
-          (match self#get_in_loop, property with 
+          (match in_loop, property with 
            | true, Variable 
              -> 
              self#add_loop_mutable_variable ident 
@@ -296,7 +296,7 @@ let scope_pass  =
 
       | While (_label,pred,body, _env) ->  
           (((self#expression pred)#with_in_loop true) # block  body )
-            #with_in_loop (self#get_in_loop)
+            #with_in_loop (in_loop)
       | _ -> 
           super#statement x 
 

lib/4.06.1/unstable/js_compiler.ml

@@ -102393,20 +102393,20 @@ let scope_pass  =
     (** check if in loop or not *)    
     val in_loop = false 
 
-    method get_in_loop = in_loop
+    (* method get_in_loop = in_loop *)
 
     method get_defined_idents = defined_idents
 
     method get_used_idents = used_idents
 
     method get_loop_mutable_values = loop_mutable_values 
 
-    method get_mutable_values = mutable_values 
+    (* method get_mutable_values = mutable_values  *)
 
     method get_closured_idents = closured_idents 
 
     method with_in_loop b = 
-      if b = self#get_in_loop then self
+      if b = in_loop then self
       else {< in_loop = b >}
      (* Since it's loop mutable variable, for sure
          it is mutable variable
@@ -102481,7 +102481,7 @@ let scope_pass  =
       match x with
       | { ident ; value; property  }  -> 
         let obj = 
-          (match self#get_in_loop, property with 
+          (match in_loop, property with 
            | true, Variable 
              -> 
              self#add_loop_mutable_variable ident 
@@ -102570,7 +102570,7 @@ let scope_pass  =
 
       | While (_label,pred,body, _env) ->  
           (((self#expression pred)#with_in_loop true) # block  body )
-            #with_in_loop (self#get_in_loop)
+            #with_in_loop (in_loop)
       | _ -> 
           super#statement x 
 

lib/4.06.1/unstable/js_refmt_compiler.ml

@@ -102393,20 +102393,20 @@ let scope_pass  =
     (** check if in loop or not *)    
     val in_loop = false 
 
-    method get_in_loop = in_loop
+    (* method get_in_loop = in_loop *)
 
     method get_defined_idents = defined_idents
 
     method get_used_idents = used_idents
 
     method get_loop_mutable_values = loop_mutable_values 
 
-    method get_mutable_values = mutable_values 
+    (* method get_mutable_values = mutable_values  *)
 
     method get_closured_idents = closured_idents 
 
     method with_in_loop b = 
-      if b = self#get_in_loop then self
+      if b = in_loop then self
       else {< in_loop = b >}
      (* Since it's loop mutable variable, for sure
          it is mutable variable
@@ -102481,7 +102481,7 @@ let scope_pass  =
       match x with
       | { ident ; value; property  }  -> 
         let obj = 
-          (match self#get_in_loop, property with 
+          (match in_loop, property with 
            | true, Variable 
              -> 
              self#add_loop_mutable_variable ident 
@@ -102570,7 +102570,7 @@ let scope_pass  =
 
       | While (_label,pred,body, _env) ->  
           (((self#expression pred)#with_in_loop true) # block  body )
-            #with_in_loop (self#get_in_loop)
+            #with_in_loop (in_loop)
       | _ -> 
           super#statement x 
 

lib/4.06.1/whole_compiler.ml

@@ -384887,20 +384887,20 @@ let scope_pass  =
     (** check if in loop or not *)    
     val in_loop = false 
 
-    method get_in_loop = in_loop
+    (* method get_in_loop = in_loop *)
 
     method get_defined_idents = defined_idents
 
     method get_used_idents = used_idents
 
     method get_loop_mutable_values = loop_mutable_values 
 
-    method get_mutable_values = mutable_values 
+    (* method get_mutable_values = mutable_values  *)
 
     method get_closured_idents = closured_idents 
 
     method with_in_loop b = 
-      if b = self#get_in_loop then self
+      if b = in_loop then self
       else {< in_loop = b >}
      (* Since it's loop mutable variable, for sure
          it is mutable variable
@@ -384975,7 +384975,7 @@ let scope_pass  =
       match x with
       | { ident ; value; property  }  -> 
         let obj = 
-          (match self#get_in_loop, property with 
+          (match in_loop, property with 
            | true, Variable 
              -> 
              self#add_loop_mutable_variable ident 
@@ -385064,7 +385064,7 @@ let scope_pass  =
 
       | While (_label,pred,body, _env) ->  
           (((self#expression pred)#with_in_loop true) # block  body )
-            #with_in_loop (self#get_in_loop)
+            #with_in_loop (in_loop)
       | _ -> 
           super#statement x 
 

ocaml-tree/record_fold.js

@@ -133,7 +133,8 @@ function mkStructuralTy(def, allNames) {
       return {
         eta: `(fun _self st ${snippet})`,
         beta(x) {
-          return `let st = (fun ${snippet}) ${x} in `; // TODO: could be inlined futher
+          // This code path seems to be not hit
+          return `let st = (fun ${snippet}) ${x} in `; 
         },
       };
     default: