Skip to content

Commit 712b87d

Browse files
authored
Merge pull request #2553 from BuckleScript/remove_refmt_v2
remove refmt version 2
2 parents 5a83c41 + a899f96 commit 712b87d

File tree

7 files changed

+4
-78334
lines changed

7 files changed

+4
-78334
lines changed

jscomp/bsb/bsb_config_parse.ml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -165,9 +165,8 @@ let interpret_json
165165
match String_map.find_opt Bsb_build_schemas.refmt map with
166166
| Some (Flo {flo} as config) ->
167167
begin match flo with
168-
| "2" -> Bsb_config_types.Refmt_v2
169-
| "3" -> Refmt_v3
170-
| _ -> Bsb_exception.config_error config "expect version 2 or 3"
168+
| "3" -> Bsb_config_types.Refmt_v3
169+
| _ -> Bsb_exception.config_error config "expect version 3 only"
171170
end
172171
| Some (Str {str})
173172
->

jscomp/bsb/bsb_config_types.ml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ type reason_react_jsx = string option
3737

3838
type refmt =
3939
| Refmt_none
40-
| Refmt_v2
4140
| Refmt_v3
4241
| Refmt_custom of string
4342
type t =

jscomp/bsb/bsb_ninja_gen.ml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,6 @@ let output_ninja_and_namespace_map
124124
[|
125125
Bsb_ninja_global_vars.refmt,
126126
(match refmt with
127-
| Refmt_v2 ->
128-
Bsb_log.warn "@{<warning>Warning:@} ReasonSyntax V2 is deprecated, please upgrade to V3.@.";
129-
bsc_dir // "refmt.exe"
130127
| Refmt_none ->
131128
Bsb_log.warn "@{<warning>Warning:@} refmt version missing. Please set it explicitly, since we may change the default in the future.@.";
132129
bsc_dir // "refmt.exe"

lib/Makefile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ bsb.exe: bsb.mli bsb.ml
1919
bsb_helper.exe: bsb_helper.mli bsb_helper.ml
2020
$(NATIVE) $(OCAMLOPT_FLAGS) unix.cmxa -w -a $^ -o $@
2121

22-
refmt.exe: refmt_main.mli refmt_main.ml
23-
$(NATIVE) -w -40-30 -no-alias-deps -I +compiler-libs ocamlcommon.cmxa $^ -o $@
2422

2523
refmt3.exe: refmt_main3.mli refmt_main3.ml
2624
$(NATIVE) -w -40-30 -no-alias-deps -I +compiler-libs ocamlcommon.cmxa $^ -o $@

lib/bsb.ml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10098,7 +10098,6 @@ type reason_react_jsx = string option
1009810098

1009910099
type refmt =
1010010100
| Refmt_none
10101-
| Refmt_v2
1010210101
| Refmt_v3
1010310102
| Refmt_custom of string
1010410103
type t =
@@ -10730,9 +10729,8 @@ let interpret_json
1073010729
match String_map.find_opt Bsb_build_schemas.refmt map with
1073110730
| Some (Flo {flo} as config) ->
1073210731
begin match flo with
10733-
| "2" -> Bsb_config_types.Refmt_v2
10734-
| "3" -> Refmt_v3
10735-
| _ -> Bsb_exception.config_error config "expect version 2 or 3"
10732+
| "3" -> Bsb_config_types.Refmt_v3
10733+
| _ -> Bsb_exception.config_error config "expect version 3 only"
1073610734
end
1073710735
| Some (Str {str})
1073810736
->
@@ -12496,9 +12494,6 @@ let output_ninja_and_namespace_map
1249612494
[|
1249712495
Bsb_ninja_global_vars.refmt,
1249812496
(match refmt with
12499-
| Refmt_v2 ->
12500-
Bsb_log.warn "@{<warning>Warning:@} ReasonSyntax V2 is deprecated, please upgrade to V3.@.";
12501-
bsc_dir // "refmt.exe"
1250212497
| Refmt_none ->
1250312498
Bsb_log.warn "@{<warning>Warning:@} refmt version missing. Please set it explicitly, since we may change the default in the future.@.";
1250412499
bsc_dir // "refmt.exe"

0 commit comments

Comments
 (0)