Exploring problem space

Author: nojaf

compiler/syntax/src/jsx_v4.ml

@@ -1185,7 +1185,7 @@ let map_binding ~config ~empty_loc ~pstr_loc ~file_name ~rec_flag binding =
     in
     (Some props_record_type, binding, new_binding))
   else if Jsx_common.has_attr_on_binding Jsx_common.has_attr_with_props binding
-  then
+  then (
     let modified_binding =
       {
         binding with
@@ -1198,6 +1198,8 @@ let map_binding ~config ~empty_loc ~pstr_loc ~file_name ~rec_flag binding =
       make_module_name file_name config.nested_modules fn_name
     in
 
+    Format.printf "Yow %s\n" full_module_name;
+
     let is_async =
       Ast_async.dig_async_payload_from_function modified_binding.pvb_expr
     in
@@ -1283,7 +1285,7 @@ let map_binding ~config ~empty_loc ~pstr_loc ~file_name ~rec_flag binding =
         binding with
         pvb_attributes = binding.pvb_attributes |> List.filter other_attrs_pure;
       },
-      new_binding )
+      new_binding ))
   else (None, binding, None)
 
 let transform_structure_item ~config item =

tests/syntax_tests/data/ppx/react/expected/sharedPropsWithProps.res.txt

@@ -131,3 +131,17 @@ module V4A6 = {
     \"SharedPropsWithProps$V4A6"
   }
 }
+
+module V4A7 = {
+  type props = {count: int}
+
+  let make =
+    @directive("'use memo'")
+    props => {
+      React.int(props.count)
+    }
+  let make = {
+    let \"SharedPropsWithProps$V4A7" = props => make(props)
+    \"SharedPropsWithProps$V4A7"
+  }
+}

tests/syntax_tests/data/ppx/react/sharedPropsWithProps.res

@@ -91,3 +91,13 @@ module V4A6 = {
     }
   }
 }
+
+module V4A7 = {
+  type props = {count: int}
+
+  @react.componentWithProps
+  let make = @directive("'use memo'")
+  props => {
+    React.int(props.count)
+  }
+}

tests/tests/src/alias_default_value_test.mjs

@@ -82,6 +82,17 @@ let C7 = {
   make: Alias_default_value_test$C7
 };
 
+function make(props) {
+  'use memo';
+  return props.count;
+}
+
+let Alias_default_value_test$C8 = make;
+
+let C8 = {
+  make: Alias_default_value_test$C8
+};
+
 export {
   C0,
   C1,
@@ -90,5 +101,6 @@ export {
   C4,
   C6,
   C7,
+  C8,
 }
 /* No side effect */

tests/tests/src/alias_default_value_test.res

@@ -64,3 +64,14 @@ module C7 = {
       React.string(`Hello ${name}, you clicked me ` ++ times)
     }
 }
+
+module C8 = {
+  type props = {count: int}
+
+  @react.componentWithProps
+  let make =
+    @directive("'use memo'")
+    props => {
+      React.int(props.count)
+    }
+}