Remove symbol bindings

Author: nojaf

CHANGELOG.md

@@ -12,6 +12,12 @@
 
 # 12.0.0-alpha.15 (Unreleased)
 
+#### :boom: Breaking Change
+
+- Remove `String.getSymbol` from standard library.
+- Remove `String.getSymbolUnsafe` from standard library.
+- Remove `String.setSymbol` from standard library.
+
 #### :bug: Bug fix
 
 - Ignore inferred arity in functions inside `%raw` functions, leaving to `%ffi` the responsibility to check the arity since it gives an error in case of mismatch. https://github.com/rescript-lang/rescript/pull/7542

runtime/Stdlib_String.res

@@ -164,10 +164,6 @@ external splitByRegExpAtMost: (string, Stdlib_RegExp.t, ~limit: int) => array<op
 @send external padStart: (string, int, string) => string = "padStart"
 @send external padEnd: (string, int, string) => string = "padEnd"
 
-@get_index external getSymbol: (string, Stdlib_Symbol.t) => option<'a> = ""
-@get_index external getSymbolUnsafe: (string, Stdlib_Symbol.t) => 'a = ""
-@set_index external setSymbol: (string, Stdlib_Symbol.t, 'a) => unit = ""
-
 @send external localeCompare: (string, string) => float = "localeCompare"
 
 external ignore: string => unit = "%ignore"

runtime/Stdlib_String.resi

@@ -1112,50 +1112,6 @@ String.padEnd("abc", 1, "") == "abc"
 @send
 external padEnd: (string, int, string) => string = "padEnd"
 
-/**
-`getSymbol(str, symbol)` returns the value associated with the given symbol on the string as an `option<'a>`.
-Returns `None` if the symbol property doesn't exist.
-
-## Examples
-
-```rescript
-let h = String.make("hello")
-let symbol = String.getSymbol(h, Symbol.iterator)
-Option.isSome(symbol) == true
-```
-*/
-@get_index external getSymbol: (string, Stdlib_Symbol.t) => option<'a> = ""
-
-/**
-`getSymbolUnsafe(str, symbol)` returns the value associated with the given symbol on the string. 
-
-This is _unsafe_, meaning it will return `undefined` if the symbol property doesn't exist.
-
-## Examples
-
-```rescript
-let h = String.make("hello")
-// This does required direct access to the symbol property
-// Storing the iterator in a variable first, will not work.
-String.getSymbolUnsafe(h, Symbol.iterator)()->Iterator.toArray->Array.length == 5
-```
-*/
-@get_index external getSymbolUnsafe: (string, Stdlib_Symbol.t) => 'a = ""
-
-/**
-`setSymbol(str, symbol, value)` sets the given symbol property on the string to the specified value.
-
-## Examples
-
-```rescript
-let mySymbol = Symbol.make("test")
-let h = %raw(`new String("hello")`)
-String.setSymbol(h, mySymbol, 42)
-String.getSymbol(h, mySymbol) == Some(42)
-```
-*/
-@set_index external setSymbol: (string, Stdlib_Symbol.t, 'a) => unit = ""
-
 /**
 `localeCompare(referenceStr, compareStr)` returns a float than indicatings
 whether a reference string comes before or after, or is the same as the given

tests/tests/src/core/Core_TempTests.mjs

@@ -249,10 +249,6 @@ let x = Symbol.for("Foo");
 
 console.log(x);
 
-let array$1 = "foo"[Symbol.iterator]().toArray();
-
-console.log(array$1);
-
 console.info("");
 
 console.info("Global namespace");
@@ -338,6 +334,7 @@ export {
   _formatter,
   formatter,
   segments,
+  array,
   date,
   dict,
   dict2,
@@ -354,7 +351,6 @@ export {
   set,
   regexp,
   x,
-  array$1 as array,
   timeout,
   z,
   intFromBigInt,

tests/tests/src/core/Core_TempTests.res

@@ -160,8 +160,6 @@ Console.info("Symbol")
 Console.info("---")
 let x = Symbol.getFor("Foo")
 Console.log(x)
-let array: array<string> = String.getSymbolUnsafe("foo", Symbol.iterator)()->Iterator.toArray
-Console.log(array)
 
 Console.info("")
 Console.info("Global namespace")

tests/tests/src/core/Test.mjs

@@ -15,7 +15,7 @@ function print(value) {
   } else if (match === "string") {
     return Stdlib_Option.getExn(JSON.stringify(value), undefined);
   } else {
-    return new String(value);
+    return String(value);
   }
 }