Remove not_found callback, handle cmj not found case in a graceful way later

Author: bobzhang

jscomp/core/lam_compile_env.ml

@@ -153,12 +153,15 @@ type _ t =
   | Has_env : Env.t  -> bool t (* Indicate it is pure or not *)
 
 
-(* -FIXME: 
-  Here [not_found] only means cmi not found, not cmj not found *)
+(* 
+  FIXME: 
+  Here [not_found] only means cmi not found, not cmj not found
+  We do need handle cases when [not_found] hit in a graceful way
+*)
 let query_and_add_if_not_exist 
     (type u)
     (oid : Lam_module_ident.t) 
-    (env : u t) ~not_found ~(found: bool -> _) =
+    (env : u t)  ~(found: bool -> _) =
   match Lam_module_ident.Hash.find_opt cached_tbl oid with 
   | None -> 
     begin match oid.kind with
@@ -171,17 +174,8 @@ let query_and_add_if_not_exist
         -> 
         let (cmj_path, cmj_table) as cmj_info = 
           Js_cmj_load.find_cmj_exn (Lam_module_ident.name oid ^ Literals.suffix_cmj) in           
-        ( match env with 
-          | Has_env env -> 
-            begin match 
-                Ocaml_types.find_serializable_signatures_by_path  oid.id env with 
-            | None -> not_found () (* actually when [not_found] in the call site, we throw... *)
-            | Some _ -> 
-              oid +> Ml {cmj_table;cmj_path } ;
-              found  (Js_cmj_format.is_pure cmj_table)
-            end
-          | No_env -> 
-            found (Js_cmj_format.is_pure cmj_table))        
+        oid +> Ml {cmj_table;cmj_path } ;
+        found (Js_cmj_format.is_pure cmj_table)
       | External _  -> 
         oid +> External;
         (** This might be wrong, if we happen to expand  an js module
@@ -247,7 +241,6 @@ let add = Lam_module_ident.Hash_set.add
 let is_pure_module (id : Lam_module_ident.t)  = 
   id.kind = Runtime ||
   query_and_add_if_not_exist id No_env
-    ~not_found:(fun _ -> false) 
     ~found:(fun x ->  x)
 
 let get_required_modules 

jscomp/core/lam_compile_env.mli

@@ -98,7 +98,7 @@ val query_external_id_info :
 
 val query_and_add_if_not_exist : 
   Lam_module_ident.t ->
-  'a t -> not_found:(unit -> 'b) ->
+  'a t -> 
   found:(bool -> 'b) -> 'b
 
 val is_pure_module : Lam_module_ident.t -> bool

jscomp/core/lam_stats_export.ml

@@ -112,7 +112,6 @@ let get_dependent_module_effect
            id.kind = Runtime ||
            Lam_compile_env.query_and_add_if_not_exist id 
              (Has_env meta.env )
-             ~not_found:(fun _ -> false ) 
              ~found:(fun pure -> pure)
         ) in 
     Ext_option.map  non_pure_module (fun x -> Lam_module_ident.name x)