skip windows

Author: aspeddro

.github/workflows/ci.yml

@@ -93,7 +93,6 @@ jobs:
             # Run the slower tasks on the fastest runner only
             build_playground: true
             benchmarks: true
-            # docstring_tests: true
           - os: buildjet-2vcpu-ubuntu-2204-arm # ARM
             ocaml_compiler: ocaml-variants.5.2.1+options,ocaml-option-static
             upload_binaries: true
@@ -313,10 +312,6 @@ jobs:
       - name: Run tests
         run: node scripts/test.js -all
 
-      - name: Docstrings tests
-        # if: matrix.docstring_tests
-        run: node scripts/test.js -docstrings
-
       - name: Check for diffs in tests folder
         run: git diff --ignore-cr-at-eol --exit-code tests
 

scripts/test.js

@@ -34,12 +34,12 @@ if (process.argv.includes("-docstrings")) {
   runtimeDocstrings = true;
 }
 
-// -all dont include runtimeDocstrings
 if (process.argv.includes("-all")) {
   ounitTest = true;
   mochaTest = true;
   bsbTest = true;
   formatTest = true;
+  runtimeDocstrings = true;
 }
 
 async function runTests() {
@@ -128,27 +128,37 @@ async function runTests() {
   }
 
   if (runtimeDocstrings) {
-    // if (process.platform === "win32") {
-    //   console.log(`Skipping docstrings tests on ${process.platform}`);
-    // } else {
-    console.log("Running runtime docstrings tests");
-    cp.execSync(`${rescript_exe} build`, {
-      cwd: path.join(__dirname, "..", "tests/docstrings_examples"),
-      stdio: [0, 1, 2],
-    });
+    if (process.platform === "win32") {
+      console.log(`Skipping docstrings tests on ${process.platform}`);
+    } else {
+      console.log("Running runtime docstrings tests");
+      cp.execSync(`${rescript_exe} build`, {
+        cwd: path.join(__dirname, "..", "tests/docstrings_examples"),
+        stdio: [0, 1, 2],
+      });
 
-    console.log("Formatting mocha_full_test.res")
-    cp.execSync(`${path.resolve("./cli/rescript")} format ${path.join("tests", "docstrings_examples", "mocha_full_test.res")}`, {
-      cwd: path.join(__dirname, ".."),
-      stdio: [0, 1, 2],
-    })
+      cp.execSync(`node ${path.join("tests", "docstrings_examples", "DocTest.res.mjs")}`, {
+        cwd: path.join(__dirname, ".."),
+        stdio: [0, 1, 2],
+      })
 
-    console.log("Run mocha test")
-    cp.execSync(`npx mocha ${path.join("tests", "docstrings_examples", "mocha_full_test.res.mjs")}`, {
-      cwd: path.join(__dirname, ".."),
-      stdio: [0, 1, 2],
-    });
-    // }
+      cp.execSync(`${rescript_exe} build`, {
+        cwd: path.join(__dirname, "..", "tests/docstrings_examples"),
+        stdio: [0, 1, 2],
+      });
+
+      console.log("Formatting generated_mocha_test.res")
+      cp.execSync(`./cli/rescript format ${path.join("tests", "docstrings_examples", "generated_mocha_test.res")}`, {
+        cwd: path.join(__dirname, ".."),
+        stdio: [0, 1, 2],
+      })
+
+      console.log("Run mocha test")
+      cp.execSync(`npx mocha ${path.join("tests", "docstrings_examples", "generated_mocha_test.res.mjs")}`, {
+        cwd: path.join(__dirname, ".."),
+        stdio: [0, 1, 2],
+      });
+    }
   }
 }
 

tests/docstrings_examples/DocTest.res

@@ -182,7 +182,7 @@ let main = async () => {
     ->Array.join("\n\n")
 
   let dirname = url->URL.fileURLToPath->Path.dirname
-  let filepath = Path.join([dirname, "mocha_full_test.res"])
+  let filepath = Path.join([dirname, "generated_mocha_test.res"])
   let fileContent = `open Mocha
 @@warning("-32-34-60-37-109-3-44")
 

tests/docstrings_examples/DocTest.res.mjs

@@ -224,7 +224,7 @@ async function main() {
     }
   }).join("\n\n");
   let dirname = Path.dirname(Url.fileURLToPath(import.meta.url));
-  let filepath = Path.join(dirname, "mocha_full_test.res");
+  let filepath = Path.join(dirname, "generated_mocha_test.res");
   let fileContent = "open Mocha\n@@warning(\"-32-34-60-37-109-3-44\")\n\n" + testsContent;
   return await Promises.writeFile(filepath, fileContent);
 }