cleanup

Author: zth

compiler/ext/warnings.ml

@@ -477,9 +477,7 @@ let message = function
       "Ambiguous or-pattern variables under guard;\n\
        %s may match different arguments. (See manual section 8.5)"
       msg
-  | Unused_module s ->
-    (* TODO(actions) Remove module *)
-    "unused module " ^ s ^ "."
+  | Unused_module s -> "unused module " ^ s ^ "."
   | Constraint_on_gadt ->
     "Type constraints do not apply to GADT cases of variant types."
   | Bs_unused_attribute s ->

compiler/ml/cmt_utils.ml

@@ -83,14 +83,24 @@ let emit_possible_actions_from_warning loc w =
   | Unused_module _ ->
     add_possible_action
       {loc; action = RemoveUnusedModule; description = "Remove unused module"}
-  | Unused_pat -> (* TODO: Remove full pattern. *) ()
-  | Unused_argument ->
-    (* TODO(actions) Remove unused argument or prefix with underscore *) ()
   | Unused_rec_flag ->
     add_possible_action
       {loc; action = RemoveRecFlag; description = "Remove rec flag"}
   | Open_shadow_identifier _ | Open_shadow_label_constructor _ ->
     add_possible_action {loc; action = ForceOpen; description = "Force open"}
+    (* 
+    
+    === TODO === 
+    
+    *)
+  | Fragile_literal_pattern ->
+    (* Use explicit pattern matching instead of literal *) ()
+  | Unused_pat -> (* Remove pattern *) ()
+  | Unused_argument -> (* Remove unused argument or prefix with underscore *) ()
+  | Useless_record_with -> (* Remove `...` spread *) ()
+  | Nonoptional_label _ -> (* Add `?` to make argument optional *) ()
+  | Bs_toplevel_expression_unit _ ->
+    (* Assign to let _ = or pipe to ignore() *) ()
   | _ -> ()
 
 let _ =

compiler/ml/env.ml

@@ -1660,7 +1660,6 @@ and store_type ~check id info env =
            if not (ty = "" || ty.[0] = '_') then
              Delayed_checks.add_delayed_check (fun () ->
                  if (not (is_in_signature env)) && not used.cu_positive then
-                   (* TODO(actions) Remove unused constructor *)
                    Location.prerr_warning loc
                      (Warnings.Unused_constructor
                         (c, used.cu_pattern, used.cu_privatize)))))
@@ -1706,7 +1705,6 @@ and store_extension ~check id ext env =
        Hashtbl.add used_constructors k (add_constructor_usage used);
        Delayed_checks.add_delayed_check (fun () ->
            if (not (is_in_signature env)) && not used.cu_positive then
-             (* TODO(actions) Remove unused extension *)
              Location.prerr_warning loc
                (Warnings.Unused_extension
                   (n, ext.ext_is_exception, used.cu_pattern, used.cu_privatize)))));

compiler/ml/typecore.ml

@@ -1405,7 +1405,6 @@ and type_pat_aux ~constrs ~labels ~no_existentials ~mode ~explode ~env sp
     (match sargs with
     | [({ppat_desc = Ppat_constant _} as sp)]
       when Builtin_attributes.warn_on_literal_pattern constr.cstr_attributes ->
-      (* TODO(actions) Use explicit pattern matching instead of literal *)
       Location.prerr_warning sp.ppat_loc Warnings.Fragile_literal_pattern
     | _ -> ());
     if List.length sargs <> constr.cstr_arity then
@@ -2779,7 +2778,6 @@ and type_expect_ ~context ?in_function ?(recarg = Rejected) env sexp ty_expected
     in
     let opt_exp =
       if List.length lid_sexp_list = num_fields then (
-        (* TODO(actions) Remove `...` spread *)
         Location.prerr_warning loc Warnings.Useless_record_with;
         None)
       else opt_exp
@@ -3718,7 +3716,6 @@ and type_application ~context total_app env funct (sargs : sargs) :
           else (sargs, (l, ty, lv) :: omitted, None)
         | Some (l', sarg0, sargs) ->
           if (not optional) && is_optional_loc l' then
-            (* TODO(actions) Add ? to make argument optional *)
             Location.prerr_warning sarg0.pexp_loc
               (Warnings.Nonoptional_label (Printtyp.string_of_label l));
           ( sargs,
@@ -4309,7 +4306,6 @@ let type_expression ~context env sexp =
             | Pexp_apply _ -> Some (return_type, FunctionCall)
             | _ -> Some (return_type, Other)))
      | Tags _ ->
-       (* TODO(actions) Assign to let _ = or pipe to ignore() *)
        Location.prerr_warning sexp.pexp_loc (Bs_toplevel_expression_unit None));
   end_def ();
   if not (is_nonexpansive exp) then generalize_expansive env exp.exp_type;

compiler/ml/typetexp.ml

@@ -731,7 +731,6 @@ let did_you_mean ppf choices : bool * string list =
   match choices () with
   | [] -> (false, [])
   | last :: rev_rest as choices ->
-    (* TODO(actions) Rewrite ident *)
     Format.fprintf ppf "@[<v 2>@,@,@{<info>Hint: Did you mean %s%s%s?@}@]"
       (String.concat ", " (List.rev rev_rest))
       (if rev_rest = [] then "" else " or ")
@@ -778,7 +777,7 @@ let report_error env ppf = function
       Printtyp.longident lid;
     let has_candidate, _ = super_spellcheck ppf Env.fold_types env lid in
     if not has_candidate then
-      (* TODO(actions) Add rec flag *)
+      (* TODO(actions) Add rec flag by first checking the let bindings for matching name *)
       Format.fprintf ppf
         "If you wanted to write a recursive type, don't forget the `rec` in \
          `type rec`@]"