Add @notundefined attribute to Stdlib_Intl_*

mediremi · mediremi · commit 9dccafa04bb2 · 2025-05-13T14:10:02.000+01:00
diff --git a/runtime/Stdlib_Intl_Collator.res b/runtime/Stdlib_Intl_Collator.res
@@ -1,3 +1,4 @@
+@notUndefined
 type t
 
 type usage = [#sort | #search]
diff --git a/runtime/Stdlib_Intl_DateTimeFormat.res b/runtime/Stdlib_Intl_DateTimeFormat.res
@@ -1,3 +1,4 @@
+@notUndefined
 type t
 
 type dateStyle = [#full | #long | #medium | #short]
diff --git a/runtime/Stdlib_Intl_ListFormat.res b/runtime/Stdlib_Intl_ListFormat.res
@@ -1,3 +1,4 @@
+@notUndefined
 type t
 
 type listType = [
diff --git a/runtime/Stdlib_Intl_Locale.res b/runtime/Stdlib_Intl_Locale.res
@@ -1,3 +1,4 @@
+@notUndefined
 type t
 
 type options = {
diff --git a/runtime/Stdlib_Intl_NumberFormat.res b/runtime/Stdlib_Intl_NumberFormat.res
@@ -1,5 +1,6 @@
 module Grouping = Stdlib_Intl_NumberFormat_Grouping
 
+@notUndefined
 type t
 
 /**
@@ -211,7 +212,7 @@ external formatBigIntRangeToParts: (t, ~start: bigint, ~end: bigint) => array<nu
 external formatStringToParts: (t, string) => array<numberFormatRangePart> = "formatToParts"
 
 /**
-  `ignore(numberGrouping)` ignores the provided numberGrouping and returns unit.
+  `ignore(numberFormat)` ignores the provided numberFormat and returns unit.
 
   This helper is useful when you want to discard a value (for example, the result of an operation with side effects)
   without having to store or process it further.
diff --git a/runtime/Stdlib_Intl_NumberFormat_Grouping.res b/runtime/Stdlib_Intl_NumberFormat_Grouping.res
@@ -1,3 +1,4 @@
+@notUndefined
 type t
 
 type parsed = [#bool(bool) | #always | #auto | #min2]
diff --git a/runtime/Stdlib_Intl_PluralRules.res b/runtime/Stdlib_Intl_PluralRules.res
@@ -1,3 +1,4 @@
+@notUndefined
 type t
 
 type localeType = [#cardinal | #ordinal]
diff --git a/runtime/Stdlib_Intl_RelativeTimeFormat.res b/runtime/Stdlib_Intl_RelativeTimeFormat.res
@@ -1,3 +1,4 @@
+@notUndefined
 type t
 
 type numeric = [#always | #auto]
diff --git a/runtime/Stdlib_Intl_Segmenter.res b/runtime/Stdlib_Intl_Segmenter.res
@@ -1,3 +1,4 @@
+@notUndefined
 type t
 
 type granularity = [#grapheme | #word | #sentence]
diff --git a/runtime/Stdlib_Intl_Segments.res b/runtime/Stdlib_Intl_Segments.res
@@ -2,6 +2,7 @@
  A Segments instance is an object that represents the segments of a specific string, subject to the locale and options of its constructing Intl.Segmenter instance.
 https://tc39.es/ecma402/#sec-segments-objects
 */
+@notUndefined
 type t
 
 type segmentData = {
diff --git a/tests/tests/src/core/intl/Core_Intl_NumberFormatTest.mjs b/tests/tests/src/core/intl/Core_Intl_NumberFormatTest.mjs
@@ -1,6 +1,5 @@
 // Generated by ReScript, PLEASE EDIT WITH CARE
 
-import * as Primitive_option from "rescript/lib/es6/Primitive_option.js";
 import * as Stdlib_Intl_NumberFormat_Grouping from "rescript/lib/es6/Stdlib_Intl_NumberFormat_Grouping.js";
 
 console.log("---");
@@ -26,7 +25,7 @@ let roundingFormatter = new Intl.NumberFormat(undefined, {
 });
 
 let groupingFormatter1 = new Intl.NumberFormat(undefined, {
-  useGrouping: Primitive_option.some(true)
+  useGrouping: true
 });
 
 let groupingFormatter2 = new Intl.NumberFormat(undefined, {
diff --git a/tests/tests/src/option_wrapping_test.mjs b/tests/tests/src/option_wrapping_test.mjs
@@ -1,5 +1,6 @@
 // Generated by ReScript, PLEASE EDIT WITH CARE
 
+import * as Stdlib_Lazy from "rescript/lib/es6/Stdlib_Lazy.js";
 import * as Primitive_option from "rescript/lib/es6/Primitive_option.js";
 import * as Stdlib_AsyncIterator from "rescript/lib/es6/Stdlib_AsyncIterator.js";
 
@@ -47,7 +48,31 @@ let x32 = new Map().values();
 
 let x33 = Stdlib_AsyncIterator.make(() => Promise.resolve(Stdlib_AsyncIterator.value(true)));
 
-let x99 = {};
+let x34 = new Intl.ListFormat();
+
+let x35 = new Intl.Segmenter();
+
+let x36 = new Intl.Segmenter().segment("");
+
+let x37 = new Intl.DateTimeFormat();
+
+let x38 = new Intl.NumberFormat();
+
+let x39 = true;
+
+let x40 = new Intl.Collator();
+
+let x41 = new Intl.RelativeTimeFormat();
+
+let x42 = new Intl.PluralRules();
+
+let x43 = new Intl.Locale("en");
+
+let x45 = Promise.resolve(true);
+
+let x47 = {};
+
+let x48 = Stdlib_Lazy.make(() => true);
 
 let x1 = "hello";
 
@@ -66,7 +91,12 @@ let x5 = {
 
 let x12 = "test";
 
-let x98 = /* [] */0;
+let x44 = [
+  1,
+  2
+];
+
+let x46 = /* [] */0;
 
 export {
   x1,
@@ -94,7 +124,20 @@ export {
   x31,
   x32,
   x33,
-  x98,
-  x99,
+  x34,
+  x35,
+  x36,
+  x37,
+  x38,
+  x39,
+  x40,
+  x41,
+  x42,
+  x43,
+  x44,
+  x45,
+  x46,
+  x47,
+  x48,
 }
 /* x20 Not a pure module */
diff --git a/tests/tests/src/option_wrapping_test.res b/tests/tests/src/option_wrapping_test.res
@@ -28,6 +28,19 @@ let x31 = Some(ArrayBuffer.make(0)->DataView.fromBuffer)
 let x32 = Some((Map.make(): Map.t<string, string>)->Map.values)
 let x33 = Some(AsyncIterator.make(_ => AsyncIterator.value(true)->Promise.resolve))
 
-let x97 = Some(Promise.resolve(true))
-let x98 = Some(list{})
-let x99 = Some((Dict.make(): dict<string>))
+let x34 = Some(Intl.ListFormat.make())
+let x35 = Some(Intl.Segmenter.make())
+let x36 = Some(Intl.Segmenter.make()->Intl.Segmenter.segment(""))
+let x37 = Some(Intl.DateTimeFormat.make())
+let x38 = Some(Intl.NumberFormat.make())
+let x39 = Some(Intl.NumberFormat.Grouping.fromBool(true))
+let x40 = Some(Intl.Collator.make())
+let x41 = Some(Intl.RelativeTimeFormat.make())
+let x42 = Some(Intl.PluralRules.make())
+let x43 = Some(Intl.Locale.make("en"))
+
+let x44 = Some((1, 2))
+let x45 = Some(Promise.resolve(true))
+let x46 = Some(list{})
+let x47 = Some((Dict.make(): dict<string>))
+let x48 = Some(Lazy.make(_ => true))

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+@notUndefined`
`1`	`2`	`type t`
`2`	`3`
`3`	`4`	`type usage = [#sort \| #search]`