File tree Expand file tree Collapse file tree 1 file changed +6
-2
lines changed Expand file tree Collapse file tree 1 file changed +6
-2
lines changed Original file line number Diff line number Diff line change @@ -40,7 +40,7 @@ let nl buf =
40
40
- not readable
41
41
*)
42
42
43
- let make_encoding length buf =
43
+ let make_encoding length buf : Ext_buffer.t -> int -> unit =
44
44
let max_range = length lsl 1 + 1 in
45
45
if max_range < = 0xff then begin
46
46
Ext_buffer. add_char buf '1' ;
@@ -90,7 +90,11 @@ let encode (dbs : Bsb_db.t) buf =
90
90
Ext_array.iter dbs (fun x -> encode_single x buf) *)
91
91
92
92
93
- (* TODO: shall we avoid writing such file (checking the digest) *)
93
+ (* shall we avoid writing such file (checking the digest)?
94
+ It is expensive to start scanning the whole code base,
95
+ we should we avoid it in the first place, if we do start scanning,
96
+ this operation seems affordable
97
+ *)
94
98
let write_build_cache ~dir (bs_files : Bsb_db.t ) : string =
95
99
let oc = open_out_bin (Filename. concat dir bsbuild_cache) in
96
100
let buf = Ext_buffer. create 100_000 in
You can’t perform that action at this time.
0 commit comments