filter out bogus

Author: nojaf

lib_dev/process.js

@@ -1,19 +1,8 @@
 import * as child_process from "node:child_process";
 import * as fs from "node:fs/promises";
 import * as path from "node:path";
-import { execPath } from "node:process";
 import { bsc_exe, rescript_legacy_exe } from "#cli/bins";
 
-// On GitHub Actions runners, `npm` is not a native binary but a shell script
-// installed alongside the `node` executable in the hostedtoolcache directory.
-// Spawning it directly by name (`spawn("npm")`) can fail with ENOENT because
-// the PATH in CI sometimes gets polluted with bogus entries (e.g. `/tmp/xfs-*`
-// prepended), causing `execvp` to stop searching before reaching the real npm.
-// To avoid relying on PATH resolution, we resolve `npm` relative to
-// `process.execPath` (the current Node binary) and run it with `shell: true`
-// so the shebang (`#!/usr/bin/env node`) inside the npm script is honoured.
-const npmBin = path.join(path.dirname(execPath), "npm");
-
 /**
  * @typedef {{
  *   throwOnFail?: boolean,
@@ -61,32 +50,22 @@ export function setup(cwd = process.cwd()) {
   async function exec(command, args = [], options = {}) {
     const { throwOnFail = options.stdio === "inherit" } = options;
 
-    if (process.env.CI) {
-      console.log("[exec] PATH =", options.env?.PATH ?? process.env.PATH);
-      console.log("[npm] using", npmBin);
-    }
-
-    const stdoutChunks = [];
-    const stderrChunks = [];
-
-    // build env and clean PATH
+    // Build env
     const env = options.env
       ? { ...process.env, ...options.env }
       : { ...process.env };
-    if (env.PATH) {
-      const parts = env.PATH.split(":").filter(Boolean);
-      const valid = [];
-      for (const p of parts) {
-        try {
-          const stat = await fs.stat(p);
-          if (stat.isDirectory()) valid.push(p);
-        } catch {
-          // ignore non‑existent dirs
-        }
-      }
-      env.PATH = valid.join(":");
+
+    // Clean PATH only in CI: drop bogus /tmp/xfs-* entries
+    if (process.env.CI && env.PATH) {
+      env.PATH = env.PATH.split(":")
+        .filter(p => !p.startsWith("/tmp/xfs-") && p !== "")
+        .join(":");
+      console.log("[exec] cleaned PATH =", env.PATH);
     }
 
+    const stdoutChunks = [];
+    const stderrChunks = [];
+
     const subprocess = child_process.spawn(command, args, {
       cwd,
       shell: process.platform === "win32",