better approach than a new env variable

Author: zth

tests/tools_tests/test.sh

@@ -19,7 +19,7 @@ done
 # Test format-docstrings command
 for file in src/docstrings-format/*.{res,resi}; do
   output="src/expected/$(basename $file).expected"
-  DISABLE_COLOR=true ../../_build/install/default/bin/rescript-tools format-docstrings "$file" --stdout > $output
+  ../../_build/install/default/bin/rescript-tools format-docstrings "$file" --stdout > $output
   # # CI. We use LF, and the CI OCaml fork prints CRLF. Convert.
   if [ "$RUNNER_OS" == "Windows" ]; then
     perl -pi -e 's/\r\n/\n/g' -- $output

tools/bin/main.ml

@@ -54,14 +54,10 @@ let main () =
       logAndExit (Tools.extractDocs ~entryPointFile:path ~debug:false)
     | _ -> logAndExit (Error docHelp))
   | "format-docstrings" :: rest -> (
-    (try
-       match Sys.getenv "DISABLE_COLOR" with
-       | "true" -> Clflags.color := Some Misc.Color.Never
-       | _ -> ()
-     with Not_found -> ());
     match rest with
     | ["-h"] | ["--help"] -> logAndExit (Ok formatDocstringsHelp)
     | [path; "--stdout"] -> (
+      Clflags.color := Some Misc.Color.Never;
       match
         Tools.FormatDocstrings.formatDocstrings ~outputMode:`Stdout
           ~entryPointFile:path