remove record spread

Author: zth

compiler/ml/cmt_utils.ml

@@ -16,6 +16,7 @@ type action_type =
   | RemoveUnusedType
   | RemoveUnusedModule
   | RemoveRecFlag
+  | RemoveRecordSpread
   | ForceOpen
 
 (* TODO: 
@@ -53,6 +54,7 @@ let action_to_string = function
       (Longident.flatten new_ident |> String.concat ".")
   | RemoveRecFlag -> "RemoveRecFlag"
   | ForceOpen -> "ForceOpen"
+  | RemoveRecordSpread -> "RemoveRecordSpread"
 
 let _add_possible_action : (cmt_action -> unit) ref = ref (fun _ -> ())
 let add_possible_action action = !_add_possible_action action
@@ -88,6 +90,9 @@ let emit_possible_actions_from_warning loc w =
       {loc; action = RemoveRecFlag; description = "Remove rec flag"}
   | Open_shadow_identifier _ | Open_shadow_label_constructor _ ->
     add_possible_action {loc; action = ForceOpen; description = "Force open"}
+  | Useless_record_with ->
+    add_possible_action
+      {loc; action = RemoveRecordSpread; description = "Remove `...` spread"}
     (* 
     
     === TODO === 
@@ -97,7 +102,6 @@ let emit_possible_actions_from_warning loc w =
     (* Use explicit pattern matching instead of literal *) ()
   | Unused_pat -> (* Remove pattern *) ()
   | Unused_argument -> (* Remove unused argument or prefix with underscore *) ()
-  | Useless_record_with -> (* Remove `...` spread *) ()
   | Nonoptional_label _ -> (* Add `?` to make argument optional *) ()
   | Bs_toplevel_expression_unit _ ->
     (* Assign to let _ = or pipe to ignore() *) ()

tests/build_tests/actions/expected/Actions_RemoveRecordSpread_applied.res

@@ -0,0 +1,9 @@
+type x = {a: int}
+
+let x = {a: 1}
+
+let f = {a: 1}
+
+/* === AVAILABLE ACTIONS:
+- RemoveRecordSpread - Remove `...` spread
+*/

tests/build_tests/actions/fixtures/Actions_RemoveRecordSpread.res

@@ -0,0 +1,5 @@
+type x = {a: int}
+
+let x = {a: 1}
+
+let f = {...x, a: 1}

tools/src/tools.ml

@@ -1457,6 +1457,12 @@ module Actions = struct
                      if action.loc = expr.pexp_loc then
                        let expr = Ast_mapper.default_mapper.expr mapper expr in
                        match action.action with
+                       | RemoveRecordSpread -> (
+                         match expr with
+                         | {pexp_desc = Pexp_record (fields, Some _)} ->
+                           Some
+                             {expr with pexp_desc = Pexp_record (fields, None)}
+                         | _ -> None)
                        | RewriteIdent {new_ident} -> (
                          match expr with
                          | {pexp_desc = Pexp_ident ident} ->
@@ -1681,7 +1687,8 @@ module Actions = struct
                  | RemoveUnusedType -> List.mem "RemoveUnusedType" filter
                  | RemoveUnusedModule -> List.mem "RemoveUnusedModule" filter
                  | RemoveRecFlag -> List.mem "RemoveRecFlag" filter
-                 | ForceOpen -> List.mem "ForceOpen" filter)
+                 | ForceOpen -> List.mem "ForceOpen" filter
+                 | RemoveRecordSpread -> List.mem "RemoveRecordSpread" filter)
       in
       match applyActionsToFile path possible_actions with
       | Ok applied ->