Skip to content

Commit ad9d8cb

Browse files
authored
Merge pull request #3797 from BuckleScript/fix_3777
fix #3777 a more friendly error message for invalid package name
2 parents 80297bb + be1a14d commit ad9d8cb

File tree

10 files changed

+12
-12
lines changed

10 files changed

+12
-12
lines changed

jscomp/bsb/bsb_theme_init.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ let init_sample_project ~cwd ~theme name =
181181
else
182182
begin
183183
Format.fprintf Format.err_formatter
184-
"@{<error>Invalid package name@} %S.@} The project name must be a valid npm name, thus can't contain upper-case letters, for example."
184+
"@{<error>Invalid package name@} %S@}: the project name must be both a valid npm package name and a valid name as namespace@."
185185
name ;
186186
exit 2
187187
end

jscomp/common/bs_version.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
* You should have received a copy of the GNU Lesser General Public License
2323
* along with this program; if not, write to the Free Software
2424
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
25-
let version = "5.2.0-dev.1"
25+
let version = "5.2.0"
2626
let header =
2727
"// Generated by BUCKLESCRIPT, PLEASE EDIT WITH CARE"
2828
let package_name = "bs-platform"

lib/4.02.3/bsb.ml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ end = struct
5555
* You should have received a copy of the GNU Lesser General Public License
5656
* along with this program; if not, write to the Free Software
5757
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
58-
let version = "5.2.0-dev.1"
58+
let version = "5.2.0"
5959
let header =
6060
"// Generated by BUCKLESCRIPT, PLEASE EDIT WITH CARE"
6161
let package_name = "bs-platform"
@@ -16540,7 +16540,7 @@ let init_sample_project ~cwd ~theme name =
1654016540
else
1654116541
begin
1654216542
Format.fprintf Format.err_formatter
16543-
"@{<error>Invalid package name@} %S.@} The project name must be a valid npm name, thus can't contain upper-case letters, for example."
16543+
"@{<error>Invalid package name@} %S@}: the project name must be both a valid npm package name and a valid name as namespace@."
1654416544
name ;
1654516545
exit 2
1654616546
end

lib/4.02.3/bsdep.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ end = struct
5555
* You should have received a copy of the GNU Lesser General Public License
5656
* along with this program; if not, write to the Free Software
5757
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
58-
let version = "5.2.0-dev.1"
58+
let version = "5.2.0"
5959
let header =
6060
"// Generated by BUCKLESCRIPT, PLEASE EDIT WITH CARE"
6161
let package_name = "bs-platform"

lib/4.02.3/bsppx.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16164,7 +16164,7 @@ end = struct
1616416164
* You should have received a copy of the GNU Lesser General Public License
1616516165
* along with this program; if not, write to the Free Software
1616616166
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
16167-
let version = "5.2.0-dev.1"
16167+
let version = "5.2.0"
1616816168
let header =
1616916169
"// Generated by BUCKLESCRIPT, PLEASE EDIT WITH CARE"
1617016170
let package_name = "bs-platform"

lib/4.02.3/unstable/bsb_native.ml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ end = struct
5555
* You should have received a copy of the GNU Lesser General Public License
5656
* along with this program; if not, write to the Free Software
5757
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
58-
let version = "5.2.0-dev.1"
58+
let version = "5.2.0"
5959
let header =
6060
"// Generated by BUCKLESCRIPT, PLEASE EDIT WITH CARE"
6161
let package_name = "bs-platform"
@@ -16639,7 +16639,7 @@ let init_sample_project ~cwd ~theme name =
1663916639
else
1664016640
begin
1664116641
Format.fprintf Format.err_formatter
16642-
"@{<error>Invalid package name@} %S.@} The project name must be a valid npm name, thus can't contain upper-case letters, for example."
16642+
"@{<error>Invalid package name@} %S@}: the project name must be both a valid npm package name and a valid name as namespace@."
1664316643
name ;
1664416644
exit 2
1664516645
end

lib/4.02.3/unstable/js_compiler.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16071,7 +16071,7 @@ end = struct
1607116071
* You should have received a copy of the GNU Lesser General Public License
1607216072
* along with this program; if not, write to the Free Software
1607316073
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
16074-
let version = "5.2.0-dev.1"
16074+
let version = "5.2.0"
1607516075
let header =
1607616076
"// Generated by BUCKLESCRIPT, PLEASE EDIT WITH CARE"
1607716077
let package_name = "bs-platform"

lib/4.02.3/unstable/native_ppx.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15284,7 +15284,7 @@ end = struct
1528415284
* You should have received a copy of the GNU Lesser General Public License
1528515285
* along with this program; if not, write to the Free Software
1528615286
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
15287-
let version = "5.2.0-dev.1"
15287+
let version = "5.2.0"
1528815288
let header =
1528915289
"// Generated by BUCKLESCRIPT, PLEASE EDIT WITH CARE"
1529015290
let package_name = "bs-platform"

lib/4.02.3/whole_compiler.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5270,7 +5270,7 @@ end = struct
52705270
* You should have received a copy of the GNU Lesser General Public License
52715271
* along with this program; if not, write to the Free Software
52725272
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
5273-
let version = "5.2.0-dev.1"
5273+
let version = "5.2.0"
52745274
let header =
52755275
"// Generated by BUCKLESCRIPT, PLEASE EDIT WITH CARE"
52765276
let package_name = "bs-platform"

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"postinstall": "node scripts/install.js"
3434
},
3535
"name": "bs-platform",
36-
"version": "5.2.0-dev.1",
36+
"version": "5.2.0",
3737
"description": "bucklescript compiler, ocaml standard libary by bucklescript and its required runtime support",
3838
"repository": {
3939
"type": "git",

0 commit comments

Comments
 (0)