Merge pull request #4900 from rescript-lang/fix_4896

fix #4896 `'` not needed be escaped when printed inside double quotes

Author: bobzhang

jscomp/syntax/ast_utf8_string.ml

@@ -61,7 +61,7 @@ let error ~loc error =
    visual input while es5 string 
    does not*)
 
-let rec check_and_transform (loc : int ) buf s byte_offset s_len =
+let rec check_and_transform (loc : int ) (buf : Buffer.t) (s : string) (byte_offset : int) (s_len : int) =
   if byte_offset = s_len then ()
   else 
     let current_char = s.[byte_offset] in 
@@ -71,9 +71,6 @@ let rec check_and_transform (loc : int ) buf s byte_offset s_len =
     | Single 34 ->
       Buffer.add_string buf "\\\"";
       check_and_transform (loc + 1) buf s (byte_offset + 1) s_len
-    | Single 39 -> 
-      Buffer.add_string buf "\\'";
-      check_and_transform (loc + 1) buf s (byte_offset + 1) s_len 
     | Single 10 ->          
       Buffer.add_string buf "\\n";
       check_and_transform (loc + 1) buf s (byte_offset + 1) s_len 

jscomp/syntax/ast_utf8_string_interp.ml

@@ -202,9 +202,6 @@ let rec check_and_transform (loc : int )  s byte_offset ({s_len; buf} as cxt : c
     | Single 34 ->
       Buffer.add_string buf "\\\"";
       check_and_transform (loc + 1)  s (byte_offset + 1) cxt
-    | Single 39 ->
-      Buffer.add_string buf "\\'";
-      check_and_transform (loc + 1)  s (byte_offset + 1) cxt
     | Single 10 ->
 
       Buffer.add_string buf "\\n";

jscomp/test/chn_test.js

@@ -32,7 +32,7 @@ function eq(loc, x, y) {
 
 console.log("你好，\n世界");
 
-console.log("\x3f\u003f\b\t\n\v\f\r\0\"\'");
+console.log("\x3f\u003f\b\t\n\v\f\r\0\"'");
 
 function convert(s) {
   return $$Array.to_list(Array.from(s, (function (x) {
@@ -227,7 +227,7 @@ eq("File \"chn_test.ml\", line 82, characters 5-12", convert(" \b\t\n\v\f\ra"),
       }
     });
 
-eq("File \"chn_test.ml\", line 89, characters 6-13", convert(" \b\t\n\v\f\r\"\'\\\0a"), {
+eq("File \"chn_test.ml\", line 89, characters 6-13", convert(" \b\t\n\v\f\r\"'\\\0a"), {
       hd: 32,
       tl: {
         hd: 8,