Skip to content

Commit c7d29db

Browse files
committed
Not passing vendor_ninja as argument
1 parent bbfae12 commit c7d29db

File tree

3 files changed

+18
-24
lines changed

3 files changed

+18
-24
lines changed

jscomp/main/bsb_main.ml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -86,10 +86,10 @@ let exec_command_then_exit command =
8686
exit (Sys.command command )
8787

8888
(* Execute the underlying ninja build call, then exit (as opposed to keep watching) *)
89-
let ninja_command_exit vendor_ninja ninja_args =
89+
let ninja_command_exit ninja_args =
9090
let ninja_args_len = Array.length ninja_args in
9191
if Ext_sys.is_windows_or_cygwin then
92-
let path_ninja = Filename.quote vendor_ninja in
92+
let path_ninja = Filename.quote Bsb_global_paths.vendor_ninja in
9393
exec_command_then_exit
9494
(if ninja_args_len = 0 then
9595
Ext_string.inter3
@@ -106,7 +106,7 @@ let ninja_command_exit vendor_ninja ninja_args =
106106
if ninja_args_len = 0 then ninja_common_args else
107107
Array.append ninja_common_args ninja_args in
108108
Bsb_log.info_args args ;
109-
Unix.execvp vendor_ninja args
109+
Unix.execvp Bsb_global_paths.vendor_ninja args
110110

111111

112112

@@ -133,16 +133,14 @@ let program_exit () =
133133

134134
(* see discussion #929, if we catch the exception, we don't have stacktrace... *)
135135
let () =
136-
137-
let vendor_ninja = Bsb_global_paths.vendor_ninja in
138136
try begin
139137
match Sys.argv with
140138
| [| _ |] -> (* specialize this path [bsb.exe] which is used in watcher *)
141139
Bsb_ninja_regen.regenerate_ninja
142140
~toplevel_package_specs:None
143141
~forced:false
144142
~cwd:Bsb_global_paths.cwd |> ignore;
145-
ninja_command_exit vendor_ninja [||]
143+
ninja_command_exit [||]
146144

147145
| argv ->
148146
begin
@@ -182,7 +180,7 @@ let () =
182180
[bsb -regen ]
183181
*)
184182
end else if make_world then begin
185-
ninja_command_exit vendor_ninja [||]
183+
ninja_command_exit [||]
186184
end)
187185
end
188186
| `Split (bsb_args,ninja_args)
@@ -198,7 +196,7 @@ let () =
198196
if !make_world then
199197
Bsb_world.make_world_deps Bsb_global_paths.cwd config_opt ninja_args;
200198
if !watch_mode then program_exit ()
201-
else ninja_command_exit vendor_ninja ninja_args
199+
else ninja_command_exit ninja_args
202200
end
203201
end
204202
end

lib/4.02.3/bsb.ml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16959,10 +16959,10 @@ let exec_command_then_exit command =
1695916959
exit (Sys.command command )
1696016960

1696116961
(* Execute the underlying ninja build call, then exit (as opposed to keep watching) *)
16962-
let ninja_command_exit vendor_ninja ninja_args =
16962+
let ninja_command_exit ninja_args =
1696316963
let ninja_args_len = Array.length ninja_args in
1696416964
if Ext_sys.is_windows_or_cygwin then
16965-
let path_ninja = Filename.quote vendor_ninja in
16965+
let path_ninja = Filename.quote Bsb_global_paths.vendor_ninja in
1696616966
exec_command_then_exit
1696716967
(if ninja_args_len = 0 then
1696816968
Ext_string.inter3
@@ -16979,7 +16979,7 @@ let ninja_command_exit vendor_ninja ninja_args =
1697916979
if ninja_args_len = 0 then ninja_common_args else
1698016980
Array.append ninja_common_args ninja_args in
1698116981
Bsb_log.info_args args ;
16982-
Unix.execvp vendor_ninja args
16982+
Unix.execvp Bsb_global_paths.vendor_ninja args
1698316983

1698416984

1698516985

@@ -17006,16 +17006,14 @@ let program_exit () =
1700617006

1700717007
(* see discussion #929, if we catch the exception, we don't have stacktrace... *)
1700817008
let () =
17009-
17010-
let vendor_ninja = Bsb_global_paths.vendor_ninja in
1701117009
try begin
1701217010
match Sys.argv with
1701317011
| [| _ |] -> (* specialize this path [bsb.exe] which is used in watcher *)
1701417012
Bsb_ninja_regen.regenerate_ninja
1701517013
~toplevel_package_specs:None
1701617014
~forced:false
1701717015
~cwd:Bsb_global_paths.cwd |> ignore;
17018-
ninja_command_exit vendor_ninja [||]
17016+
ninja_command_exit [||]
1701917017

1702017018
| argv ->
1702117019
begin
@@ -17055,7 +17053,7 @@ let () =
1705517053
[bsb -regen ]
1705617054
*)
1705717055
end else if make_world then begin
17058-
ninja_command_exit vendor_ninja [||]
17056+
ninja_command_exit [||]
1705917057
end)
1706017058
end
1706117059
| `Split (bsb_args,ninja_args)
@@ -17071,7 +17069,7 @@ let () =
1707117069
if !make_world then
1707217070
Bsb_world.make_world_deps Bsb_global_paths.cwd config_opt ninja_args;
1707317071
if !watch_mode then program_exit ()
17074-
else ninja_command_exit vendor_ninja ninja_args
17072+
else ninja_command_exit ninja_args
1707517073
end
1707617074
end
1707717075
end

lib/4.02.3/unstable/bsb_native.ml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17058,10 +17058,10 @@ let exec_command_then_exit command =
1705817058
exit (Sys.command command )
1705917059

1706017060
(* Execute the underlying ninja build call, then exit (as opposed to keep watching) *)
17061-
let ninja_command_exit vendor_ninja ninja_args =
17061+
let ninja_command_exit ninja_args =
1706217062
let ninja_args_len = Array.length ninja_args in
1706317063
if Ext_sys.is_windows_or_cygwin then
17064-
let path_ninja = Filename.quote vendor_ninja in
17064+
let path_ninja = Filename.quote Bsb_global_paths.vendor_ninja in
1706517065
exec_command_then_exit
1706617066
(if ninja_args_len = 0 then
1706717067
Ext_string.inter3
@@ -17078,7 +17078,7 @@ let ninja_command_exit vendor_ninja ninja_args =
1707817078
if ninja_args_len = 0 then ninja_common_args else
1707917079
Array.append ninja_common_args ninja_args in
1708017080
Bsb_log.info_args args ;
17081-
Unix.execvp vendor_ninja args
17081+
Unix.execvp Bsb_global_paths.vendor_ninja args
1708217082

1708317083

1708417084

@@ -17105,16 +17105,14 @@ let program_exit () =
1710517105

1710617106
(* see discussion #929, if we catch the exception, we don't have stacktrace... *)
1710717107
let () =
17108-
17109-
let vendor_ninja = Bsb_global_paths.vendor_ninja in
1711017108
try begin
1711117109
match Sys.argv with
1711217110
| [| _ |] -> (* specialize this path [bsb.exe] which is used in watcher *)
1711317111
Bsb_ninja_regen.regenerate_ninja
1711417112
~toplevel_package_specs:None
1711517113
~forced:false
1711617114
~cwd:Bsb_global_paths.cwd |> ignore;
17117-
ninja_command_exit vendor_ninja [||]
17115+
ninja_command_exit [||]
1711817116

1711917117
| argv ->
1712017118
begin
@@ -17154,7 +17152,7 @@ let () =
1715417152
[bsb -regen ]
1715517153
*)
1715617154
end else if make_world then begin
17157-
ninja_command_exit vendor_ninja [||]
17155+
ninja_command_exit [||]
1715817156
end)
1715917157
end
1716017158
| `Split (bsb_args,ninja_args)
@@ -17170,7 +17168,7 @@ let () =
1717017168
if !make_world then
1717117169
Bsb_world.make_world_deps Bsb_global_paths.cwd config_opt ninja_args;
1717217170
if !watch_mode then program_exit ()
17173-
else ninja_command_exit vendor_ninja ninja_args
17171+
else ninja_command_exit ninja_args
1717417172
end
1717517173
end
1717617174
end

0 commit comments

Comments
 (0)