Fix remainder of #2539 (#2577)

Author: chenglou

jscomp/others/belt_Set.ml

@@ -29,17 +29,17 @@ module Dict = Belt_SetDict
 module A = Belt_Array
 
 
-type ('key, 'id) id = ('key, 'id) Belt_Id.comparable
-type ('key, 'id ) cmp = ('key, 'id) Belt_Id.cmp
+type ('value, 'id) id = ('value, 'id) Belt_Id.comparable
+type ('value, 'id ) cmp = ('value, 'id) Belt_Id.cmp
 
 module S = struct 
-  type ('k,'id) t = {
-    cmp: ('k, 'id) cmp;
-    data: ('k, 'id) Dict.t;
+  type ('value, 'id) t = {
+    cmp: ('value, 'id) cmp;
+    data: ('value, 'id) Dict.t;
   } [@@bs.deriving abstract]
 end 
 
-type ('k, 'id) t = ('k, 'id) S.t
+type ('value, 'id) t = ('value, 'id) S.t
 
 let ofArray (type value) (type identity) data ~(id : (value,identity) id)  = 
   let module M = (val id ) in

jscomp/others/belt_Set.mli

@@ -73,12 +73,12 @@
    The [union s0 s3] will result in a type error, since their identity mismatch
 *)
 
-(** Specalized when key type is [int], more efficient
+(** Specalized when value type is [int], more efficient
     than the gerneic type, its compare behavior is fixed using the built-in comparison
 *)
 module Int = Belt_SetInt
 
-(** Specalized when key type is [string], more efficient
+(** Specalized when value type is [string], more efficient
     than the gerneic type, its compare behavior is fixed using the built-in comparison
 *)  
 module String = Belt_SetString
@@ -91,16 +91,16 @@ module String = Belt_SetString
 module Dict = Belt_SetDict
 
 
-type ('key,'identity)  t
-(** [('key, 'identity) t]
+type ('value, 'identity) t
+(** [('value, 'identity) t]
 
-    ['key] is the element type
+    ['value] is the element type
 
     ['identity] the identity of the collection
 *)
 
 
-type ('key, 'id) id = ('key, 'id) Belt_Id.comparable
+type ('value, 'id) id = ('value, 'id) Belt_Id.comparable
 (** The identity needed for making a set from scratch
 *)
 
@@ -115,7 +115,7 @@ val make: id:('value, 'id) id -> ('value, 'id) t
 *)
 
 
-val ofArray:  'k array -> id:('k, 'id) id ->  ('k, 'id) t
+val ofArray:  'value array -> id:('value, 'id) id ->  ('value, 'id) t
 (** [ofArray xs ~id]
 
     @example{[
@@ -435,7 +435,7 @@ val checkInvariantInternal: _ t -> unit
     More API will be exposed by needs
 *)
 
-val getData: ('k,'id) t  -> ('k,'id) Belt_SetDict.t
+val getData: ('value, 'id) t  -> ('value, 'id) Belt_SetDict.t
 (** [getData s0]
 
     {b Advanced usage only}
@@ -445,15 +445,15 @@ val getData: ('k,'id) t  -> ('k,'id) Belt_SetDict.t
     without boxing
 *)
 
-val getId: ('k,'id) t  -> ('k,'id) id
+val getId: ('value, 'id) t  -> ('value, 'id) id
 (** [getId s0]
 
     {b Advanced usage only}
     
     @return the identity of [s0]
 *)
 
-val packIdData: id:('k, 'id) id -> data:('k, 'id) Belt_SetDict.t -> ('k, 'id) t
+val packIdData: id:('value, 'id) id -> data:('value, 'id) Belt_SetDict.t -> ('value, 'id) t
 (** [packIdData ~id ~data]
 
     {b Advanced usage only}

jscomp/others/belt_SetInt.mli

@@ -23,8 +23,8 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
 
-(** This module is {!Belt.Set} specialized with key type to be a primitive type.
-    It is more efficient in general, the  API is the same with {!Belt_Set} except its key type is fixed,
+(** This module is {!Belt.Set} specialized with value type to be a primitive type.
+    It is more efficient in general, the  API is the same with {!Belt_Set} except its value type is fixed,
     and identity is not needed(using the built-in one)
 
     {b See} {!Belt.Set}

jscomp/others/belt_SetString.mli

@@ -23,8 +23,8 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
 
-(** This module is {!Belt.Set} specialized with key type to be a primitive type.
-    It is more efficient in general, the  API is the same with {!Belt_Set} except its key type is fixed,
+(** This module is {!Belt.Set} specialized with value type to be a primitive type.
+    It is more efficient in general, the  API is the same with {!Belt_Set} except its value type is fixed,
     and identity is not needed(using the built-in one)
 
     {b See} {!Belt.Set}

jscomp/others/set.cppo.mli

@@ -22,8 +22,8 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
 
-(** This module is {!Belt.Set} specialized with key type to be a primitive type.
-    It is more efficient in general, the  API is the same with {!Belt_Set} except its key type is fixed,
+(** This module is {!Belt.Set} specialized with value type to be a primitive type.
+    It is more efficient in general, the  API is the same with {!Belt_Set} except its value type is fixed,
     and identity is not needed(using the built-in one)
 
     {b See} {!Belt.Set}