specialize string_of_int

Author: bobzhang

jscomp/all.depend

@@ -675,8 +675,8 @@ core/lam_compile_main.cmx : ext/literals.cmx core/lam_util.cmx \
     core/js_exp_make.cmx core/js_dump_program.cmx common/js_config.cmx \
     core/js_cmj_format.cmx core/j.cmx ext/ident_set.cmx ext/ext_string.cmx \
     ext/ext_pervasives.cmx ext/ext_path.cmx ext/ext_namespace.cmx \
-    common/ext_log.cmx ext/ext_list.cmx ext/ext_ident.cmx \
-    ext/ext_filename.cmx ext/ext_char.cmx core/lam_compile_main.cmi
+    common/ext_log.cmx ext/ext_list.cmx ext/ext_filename.cmx ext/ext_char.cmx \
+    core/lam_compile_main.cmi
 core/js_implementation.cmx : core/ocaml_parse.cmx ext/literals.cmx \
     core/lam_compile_main.cmx core/lam_compile_env.cmx common/js_config.cmx \
     ext/ext_string.cmx ext/ext_pervasives.cmx ext/ext_namespace.cmx \

jscomp/core/lam_compile_main.ml

@@ -71,12 +71,12 @@ let compile_group ({filename = file_name; env;} as meta : Lam_stats.t)
      Note the arity of [print_endline] is already analyzed before, 
      so it should be safe
   *)
-  | Single(_, ({name="string_of_int";_} as id),_ ),  "pervasives.ml" ->
+  (* | Single(_, ({name="string_of_int";_} as id),_ ),  "pervasives.ml" ->
     Js_output.of_stmt @@ S.alias_variable id
       ~exp:( 
         let arg = Ext_ident.create "param" in
         E.ocaml_fun [arg] [S.return_stmt (E.int_to_string (E.var arg))]
-      )
+      ) *)
 
   (** Special handling for values in [Sys] *)
   | Single(_, ({name="max_array_length" | "max_string_length";_} as id) ,_ ),  "sys.ml" ->

jscomp/stdlib/pervasives.ml

@@ -244,9 +244,12 @@ let bool_of_string = function
   | "false" -> false
   | _ -> invalid_arg "bool_of_string"
 
+#if BS then   
+external string_of_int : int -> string = "String" [@@bs.val]
+#else
 let string_of_int n =
   format_int "%d" n
-
+#end
 external int_of_string : string -> int = "caml_int_of_string"
 external string_get : string -> int -> char = "%string_safe_get"
 

jscomp/stdlib/pervasives.mli

@@ -568,9 +568,12 @@ val bool_of_string : string -> bool
    Raise [Invalid_argument "bool_of_string"] if the string is not
    ["true"] or ["false"]. *)
 
+#if BS then    
+external string_of_int : int -> string = "String" [@@bs.val]
+#else
 val string_of_int : int -> string
 (** Return the string representation of an integer, in decimal. *)
-
+#end
 external int_of_string : string -> int = "caml_int_of_string"
 (** Convert the given string to an integer.
    The string is read in decimal (by default) or in hexadecimal (if it

jscomp/test/a_filename_test.js

@@ -13,7 +13,7 @@ function eq(loc, x, y) {
   test_id[0] = test_id[0] + 1 | 0;
   suites[0] = /* :: */[
     /* tuple */[
-      loc + (" id " + test_id[0]),
+      loc + (" id " + String(test_id[0])),
       (function () {
           return /* Eq */Block.__(0, [
                     x,

jscomp/test/a_scope_bug.js

@@ -7,7 +7,7 @@ function odd(_z) {
     var z = _z;
     var even = Caml_int32.imul(z, z);
     var a = (even + 4 | 0) + even | 0;
-    console.log("" + a);
+    console.log(String(a));
     _z = 32;
     continue ;
 

jscomp/test/arity_deopt.js

@@ -12,7 +12,7 @@ function eq(loc, x, y) {
   test_id[0] = test_id[0] + 1 | 0;
   suites[0] = /* :: */[
     /* tuple */[
-      loc + (" id " + test_id[0]),
+      loc + (" id " + String(test_id[0])),
       (function () {
           return /* Eq */Block.__(0, [
                     x,

jscomp/test/array_subtle_test.js

@@ -15,7 +15,7 @@ function eq(loc, param) {
   test_id[0] = test_id[0] + 1 | 0;
   suites[0] = /* :: */[
     /* tuple */[
-      loc + (" id " + test_id[0]),
+      loc + (" id " + String(test_id[0])),
       (function () {
           return /* Eq */Block.__(0, [
                     x,

jscomp/test/ast_abstract_test.js

@@ -12,7 +12,7 @@ function eq(loc, x, y) {
   test_id[0] = test_id[0] + 1 | 0;
   suites[0] = /* :: */[
     /* tuple */[
-      loc + (" id " + test_id[0]),
+      loc + (" id " + String(test_id[0])),
       (function () {
           return /* Eq */Block.__(0, [
                     x,

jscomp/test/ast_js_mapper_poly_test.js

@@ -13,7 +13,7 @@ function eq(loc, x, y) {
   test_id[0] = test_id[0] + 1 | 0;
   suites[0] = /* :: */[
     /* tuple */[
-      loc + (" id " + test_id[0]),
+      loc + (" id " + String(test_id[0])),
       (function () {
           return /* Eq */Block.__(0, [
                     x,