Change snakecase to camelcase for prop (#7460)

* Change snakecase to camelcase for prop

* Format test

* Preserve snake case for area labels

* Only unwrap uppercase exotic ident in prop name

* hyphen

Author: nojaf

compiler/core/js_dump.ml

@@ -1154,7 +1154,7 @@ and print_jsx cxt ?(spread_props : J.expression option)
     in
 
     let print_prop n x ctx =
-      let prop_name = Js_dump_property.property_key_string n in
+      let prop_name = Ext_ident.unwrap_uppercase_exotic n in
       P.string f prop_name;
       P.string f "=";
       print_prop_value x ctx

compiler/core/js_dump_property.ml

@@ -81,11 +81,9 @@ let property_access f s =
         | _ -> Js_dump_string.pp_string f s
         | exception _ -> Js_dump_string.pp_string f s)
 
-let property_key_string (s : string) : string =
-  let s = Ext_ident.unwrap_uppercase_exotic s in
-  if obj_property_no_need_quot s then s else Js_dump_string.escape_to_string s
-
 let property_key (s : J.property_name) : string =
   match s with
-  | Lit s -> property_key_string s
+  | Lit s ->
+    let s = Ext_ident.unwrap_uppercase_exotic s in
+    if obj_property_no_need_quot s then s else Js_dump_string.escape_to_string s
   | Symbol_name -> {|[Symbol.for("name")]|}

compiler/core/js_dump_property.mli

@@ -25,5 +25,3 @@
 val property_access : Ext_pp.t -> string -> unit
 
 val property_key : J.property_name -> string
-
-val property_key_string : string -> string

tests/tests/src/jsx_preserve_test.mjs

@@ -203,6 +203,11 @@ let _optional_props = <Jsx_preserve_test$ComponentWithOptionalProps
   element={<div />}
 />;
 
+let _props_with_hyphen = <label
+  aria-label="close sidebar"
+  data-testid="test"
+/>;
+
 export {
   Icon,
   _single_element_child,
@@ -228,5 +233,6 @@ export {
   _large_component,
   ComponentWithOptionalProps,
   _optional_props,
+  _props_with_hyphen,
 }
 /* _single_element_child Not a pure module */

tests/tests/src/jsx_preserve_test.res

@@ -126,3 +126,5 @@ module ComponentWithOptionalProps = {
 }
 
 let _optional_props = <ComponentWithOptionalProps i=1 s="test" element={<div />} />
+
+let _props_with_hyphen = <label ariaLabel={"close sidebar"} dataTestId="test" />