Make Stdlib.Dict more performant

Author: DZakh

lib/es6/Stdlib_Dict.js

@@ -5,22 +5,25 @@ function $$delete$1(dict, string) {
   delete(dict[string]);
 }
 
-function forEach(dict, f) {
-  Object.values(dict).forEach(value => f(value));
-}
+let forEach = ((dict, f) => {
+    for (var key in dict) {
+      f(dict[key]);
+    }
+  });
 
-function forEachWithKey(dict, f) {
-  Object.keys(dict).forEach(key => f(dict[key], key));
-}
+let forEachWithKey = ((dict, f) => {
+    for (var key in dict) {
+      f(dict[key], key);
+    }
+  });
 
-function mapValues(dict, f) {
-  let target = {};
-  Object.keys(dict).forEach(key => {
-    let value = dict[key];
-    target[key] = f(value);
+let mapValues = ((dict, f) => {
+    var target = {};
+    for (var key in dict) {
+      target[key] = f(dict[key]);
+    }
+    return target;
   });
-  return target;
-}
 
 export {
   $$delete$1 as $$delete,

lib/js/Stdlib_Dict.js

@@ -5,22 +5,25 @@ function $$delete$1(dict, string) {
   delete(dict[string]);
 }
 
-function forEach(dict, f) {
-  Object.values(dict).forEach(value => f(value));
-}
+let forEach = ((dict, f) => {
+    for (var key in dict) {
+      f(dict[key]);
+    }
+  });
 
-function forEachWithKey(dict, f) {
-  Object.keys(dict).forEach(key => f(dict[key], key));
-}
+let forEachWithKey = ((dict, f) => {
+    for (var key in dict) {
+      f(dict[key], key);
+    }
+  });
 
-function mapValues(dict, f) {
-  let target = {};
-  Object.keys(dict).forEach(key => {
-    let value = dict[key];
-    target[key] = f(value);
+let mapValues = ((dict, f) => {
+    var target = {};
+    for (var key in dict) {
+      target[key] = f(dict[key]);
+    }
+    return target;
   });
-  return target;
-}
 
 exports.$$delete = $$delete$1;
 exports.forEach = forEach;

runtime/Stdlib_Dict.res

@@ -24,22 +24,31 @@ let delete = (dict, string) => {
 
 @val external copy: (@as(json`{}`) _, dict<'a>) => dict<'a> = "Object.assign"
 
-let forEach = (dict, f) => {
-  dict->valuesToArray->Stdlib_Array.forEach(value => f(value))
-}
-
-@inline
-let forEachWithKey = (dict, f) => {
-  dict->keysToArray->Stdlib_Array.forEach(key => f(dict->getUnsafe(key), key))
-}
-
-let mapValues = (dict, f) => {
-  let target = make()
-  dict->forEachWithKey((value, key) => {
-    target->set(key, f(value))
-  })
-  target
-}
+let forEach: (dict<'a>, 'a => unit) => unit = %raw(`
+  (dict, f) => {
+    for (var key in dict) {
+      f(dict[key]);
+    }
+  }
+`)
+
+let forEachWithKey: (dict<'a>, ('a, string) => unit) => unit = %raw(`
+  (dict, f) => {
+    for (var key in dict) {
+      f(dict[key], key);
+    }
+  }
+`)
+
+let mapValues: (dict<'a>, 'a => 'b) => dict<'b> = %raw(`
+  (dict, f) => {
+    var target = {};
+    for (var key in dict) {
+      target[key] = f(dict[key]);
+    }
+    return target;
+  }
+`)
 
 external has: (dict<'a>, string) => bool = "%dict_has"