Rewatch: check if filename case for interface and implementation matches (#8144)

* Rewatch: check if filename case for interface and implementation matches

* CHANGELOG

* Another case test

Author: cknitt

CHANGELOG.md

@@ -31,6 +31,7 @@
 #### :nail_care: Polish
 
 - Rewatch: enable `--create-sourcedirs` by default (now deprecated when explicitly used). https://github.com/rescript-lang/rescript/pull/8092
+- Rewatch: check if filename case for interface and implementation matches. https://github.com/rescript-lang/rescript/pull/8144
 
 #### :house: Internal
 

rewatch/src/build/packages.rs

@@ -811,6 +811,20 @@ pub fn parse_packages(build_state: &mut BuildState) -> Result<()> {
                     };
                     match source_files.get(&implementation_filename) {
                         None => {
+                            if let Some(implementation_path) = source_files.keys().find(|path| {
+                                let extension = path.extension().and_then(|ext| ext.to_str());
+                                matches!(extension, Some(ext) if helpers::is_implementation_file(ext))
+                                    && helpers::file_path_to_module_name(path, &namespace) == module_name
+                            }) {
+                                let implementation_display =
+                                    implementation_path.to_string_lossy().to_string();
+                                let interface_display = file.to_string_lossy().to_string();
+                                return Err(anyhow!(
+                                    "Implementation and interface have different path names or different cases: `{}` vs `{}`",
+                                    implementation_display,
+                                    interface_display
+                                ));
+                            }
                             println!(
                                 "{} No implementation file found for interface file (skipping): {}",
                                 LINE_CLEAR,

tests/build_tests/case/input.js

@@ -2,17 +2,15 @@ import * as assert from "node:assert";
 import { setup } from "#dev/process";
 import { normalizeNewlines } from "#dev/utils";
 
-const { execBuildLegacy } = setup(import.meta.dirname);
+const { execBuild } = setup(import.meta.dirname);
 
-const { stderr } = await execBuildLegacy();
+const { stderr } = await execBuild();
 
 if (
   ![
-    "Error: Invalid rescript.json: implementation and interface have different path names or different cases src/demo vs src/Demo\n",
+    "Could not initialize build: Implementation and interface have different path names or different cases: `src/demo.res` vs `src/Demo.resi`\n",
     // Windows: path separator
-    "Error: Invalid rescript.json: implementation and interface have different path names or different cases src\\demo vs src\\Demo\n",
-    // Linux: files are parsed in different order
-    "Error: Invalid rescript.json: implementation and interface have different path names or different cases src/Demo vs src/demo\n",
+    "Could not initialize build: Implementation and interface have different path names or different cases: `src\\demo.res` vs `src\\Demo.resi`\n",
   ].includes(normalizeNewlines(stderr))
 ) {
   assert.fail(stderr);

tests/build_tests/case2/input.js

@@ -4,17 +4,15 @@ import * as assert from "node:assert";
 import { setup } from "#dev/process";
 import { normalizeNewlines } from "#dev/utils";
 
-const { execBuildLegacy } = setup(import.meta.dirname);
+const { execBuild } = setup(import.meta.dirname);
 
-const { stderr } = await execBuildLegacy();
+const { stderr } = await execBuild();
 
 if (
   ![
-    "Error: Invalid rescript.json: implementation and interface have different path names or different cases src/X vs src/x\n",
+    "Could not initialize build: Implementation and interface have different path names or different cases: `src/X.res` vs `src/x.resi`\n",
     // Windows: path separator
-    "Error: Invalid rescript.json: implementation and interface have different path names or different cases src\\X vs src\\x\n",
-    // Linux: files are parsed in different order
-    "Error: Invalid rescript.json: implementation and interface have different path names or different cases src/x vs src/X\n",
+    "Could not initialize build: Implementation and interface have different path names or different cases: `src\\X.res` vs `src\\x.resi`\n",
   ].includes(normalizeNewlines(stderr))
 ) {
   assert.fail(stderr);