Merge branch 'master' into jsx-ast-children-loc

Author: nojaf

.github/workflows/ci.yml

@@ -21,6 +21,8 @@ env:
 
 jobs:
   build-compiler:
+    outputs:
+      api-docs-artifact-id: ${{ steps.upload-api-docs.outputs.artifact-id }}
     strategy:
       fail-fast: false
       matrix:
@@ -36,6 +38,7 @@ jobs:
             upload_binaries: true
             # Build the playground compiler and run the benchmarks on the fastest runner
             build_playground: true
+            generate_api_docs: true
             benchmarks: true
             node-target: linux-arm64
             rust-target: aarch64-unknown-linux-musl
@@ -137,7 +140,7 @@ jobs:
         run: |
           cp rewatch/target/${{ matrix.rust-target }}/release/rewatch${{ runner.os == 'Windows' && '.exe' || '' }} rewatch
           mkdir -p rewatch/target/release
-          cp rewatch/target/${{ matrix.rust-target }}/release/rewatch${{ runner.os == 'Windows' && '.exe' || '' }} rewatch/target/release 
+          cp rewatch/target/${{ matrix.rust-target }}/release/rewatch${{ runner.os == 'Windows' && '.exe' || '' }} rewatch/target/release
           ./scripts/copyExes.js --rewatch
         shell: bash
 
@@ -321,13 +324,11 @@ jobs:
         if: steps.ninja-build-cache.outputs.cache-hit != 'true'
         run: node scripts/copyExes.js --ninja
 
-      - name: "Syntax: Run roundtrip tests"
-        if: ${{ runner.os != 'Windows' }}
-        run: opam exec -- make test-syntax-roundtrip
-
-      - name: "Syntax: Run tests (Windows)"
-        if: ${{ runner.os == 'Windows' }}
-        run: opam exec -- make test-syntax
+      - name: "Syntax: Run tests"
+        env:
+          ROUNDTRIP_TEST: ${{ runner.os == 'Windows' && '0' || '1' }}
+        run: ./scripts/test_syntax.sh
+        shell: bash
 
       - name: Build runtime/stdlib with rewatch
         if: ${{ runner.os != 'Windows' }}
@@ -360,7 +361,8 @@ jobs:
         run: make -C tests/gentype_tests/typescript-react-example clean test
 
       - name: Run rewatch tests
-        run: make test-rewatch
+        run: ./rewatch/tests/suite-ci.sh
+        shell: bash
 
       - name: Run syntax benchmarks
         if: matrix.benchmarks
@@ -439,6 +441,18 @@ jobs:
           name: lib-ocaml
           path: lib/ocaml
 
+      - name: Generate API Docs
+        if: ${{ matrix.generate_api_docs }}
+        run: yarn apidocs:generate
+
+      - name: "Upload artifacts: scripts/res/apiDocs"
+        id: upload-api-docs
+        if: ${{ matrix.generate_api_docs }}
+        uses: actions/upload-artifact@v4
+        with:
+          name: api
+          path: scripts/res/apiDocs/
+
   pkg-pr-new:
     needs:
       - build-compiler
@@ -466,6 +480,49 @@ jobs:
         run: |
           yarn dlx pkg-pr-new publish "." "./packages/@rescript/*"
 
+  api-docs:
+    needs:
+      - build-compiler
+    runs-on: ubuntu-24.04-arm
+    steps:
+      - name: Checkout rescript-lang.org
+        uses: actions/checkout@v4
+        with:
+          repository: rescript-lang/rescript-lang.org
+          ssh-key: ${{ secrets.RESCRIPT_LANG_ORG_DEPLOY_KEY }}
+
+      - name: Download artifacts
+        uses: actions/download-artifact@v4
+        with:
+          artifact-ids: ${{ needs.build-compiler.outputs.api-docs-artifact-id }}
+          path: data
+
+      - name: Check if repo is clean
+        id: diffcheck
+        run: |
+          git status
+          if [ -z "$(git status --porcelain)" ]; then
+            echo "clean=true" >> $GITHUB_OUTPUT
+          else
+            echo "clean=false" >> $GITHUB_OUTPUT
+          fi
+
+      - name: Build website
+        if: steps.diffcheck.outputs.clean == 'false'
+        run: |
+          npm ci 
+          npx rescript
+          npm run build
+
+      - name: Commit and push
+        if: ${{ startsWith(github.ref, 'refs/tags/v') }}
+        run: |
+          git config --global user.name "github-actions[bot]"
+          git config --global user.email "[email protected]"
+          git add data/api
+          git commit -m "Update API docs for ${{ github.ref_name }}"
+          git push
+
   test-integration:
     needs:
       - pkg-pr-new
@@ -488,7 +545,8 @@ jobs:
       - name: Use Node.js
         uses: actions/setup-node@v4
         with:
-          node-version-file: .nvmrc
+          # Run integration tests with the oldest supported node version.
+          node-version: 20
 
       - name: Make test directory
         id: tmp-dir
@@ -524,8 +582,8 @@ jobs:
         working-directory: rewatch/testrepo
 
       - name: Run rewatch integration tests
-        # Currently failing on Windows and intermittently on macOS
-        run: make test-rewatch-integration
+        run: ./rewatch/tests/suite-ci.sh node_modules/.bin/rewatch
+        shell: bash
 
   publish:
     needs:

.mcp.json

@@ -0,0 +1,15 @@
+{
+  "mcpServers": {
+    "ocamllsp": {
+      "type": "stdio",
+      "command": "mcp-language-server",
+      "args": [
+        "--workspace",
+        "/Users/shulhi/Dev/rescript/rescript-compiler",
+        "--lsp",
+        "ocamllsp"
+      ],
+      "env": {}
+    }
+  }
+}

.nvmrc

@@ -1 +1 @@
-20
+22

CHANGELOG.md

@@ -10,33 +10,58 @@
 > - :house: [Internal]
 > - :nail_care: [Polish]
 
-# 12.0.0-alpha.14 (Unreleased)
+# 12.0.0-alpha.15 (Unreleased)
+
+#### :bug: Bug fix
+
+- Ignore inferred arity in functions inside `%raw` functions, leaving to `%ffi` the responsibility to check the arity since it gives an error in case of mismatch. https://github.com/rescript-lang/rescript/pull/7542
+- Pass the rewatch exit code through in wrapper script. https://github.com/rescript-lang/rescript/pull/7565
+- Prop punning when types don't match results in I/O error: _none_: No such file or directory. https://github.com/rescript-lang/rescript/pull/7533
+- Pass location to children prop in jsx ppx. https://github.com/rescript-lang/rescript/pull/7540
+
+#### :nail_care: Polish
+
+- Better error message for when trying to await something that is not a promise. https://github.com/rescript-lang/rescript/pull/7561
+
+# 12.0.0-alpha.14
 
 #### :boom: Breaking Change
 
+- `Iterator.forEach` now emits `Iterator.prototype.forEach` call. https://github.com/rescript-lang/rescript/pull/7506
 - Rename functions ending with `Exn` to end with `OrThrow`. The old `Exn` functions are now deprecated:
   - `Bool.fromStringExn` → `Bool.fromStringOrThrow`
   - `BigInt.fromStringExn` → `BigInt.fromStringOrThrow`
   - `JSON.parseExn` → `JSON.parseOrThrow`
   - Changed `BigInt.fromFloat` to return an option rather than throwing an error.
   - Added `BigInt.fromFloatOrThrow`
+  - `Option.getExn` → `Option.getOrThrow`
+  - `Null.getExn` → `Null.getOrThrow`
+  - `Nullable.getExn` → `Nullable.getOrThrow`
+  - `Result.getExn` → `Result.getOrThrow`
+  - `List.getExn` → `List.getOrThrow`
+  - `List.tailExn` → `List.tailOrThrow`
+  - `List.headExn` → `List.headOrThrow`
   - Old functions remain available but are marked as deprecated with guidance to use the new `OrThrow` variants.
+  - https://github.com/rescript-lang/rescript/pull/7518, https://github.com/rescript-lang/rescript/pull/7554
 
 #### :rocket: New Feature
 
 - Add `RegExp.flags`. https://github.com/rescript-lang/rescript/pull/7461
 - Add `Array.findLast`, `Array.findLastWithIndex`, `Array.findLastIndex`, `Array.findLastIndexWithIndex` and `Array.findLastIndexOpt`. https://github.com/rescript-lang/rescript/pull/7503
 - Add `options` argument to `Console.dir`. https://github.com/rescript-lang/rescript/pull/7504
 - Show variant constructor's inline record types on hover. https://github.com/rescript-lang/rescript/pull/7519
+- Add additional `Iterator.prototype` bindings to `runtime/Stdlib_Iterator.res`. https://github.com/rescript-lang/rescript/pull/7506
 
 #### :bug: Bug fix
 
 - `rescript-tools doc` no longer includes shadowed bindings in its output. https://github.com/rescript-lang/rescript/pull/7497
 - Treat `throw` like `raise` in analysis. https://github.com/rescript-lang/rescript/pull/7521
 - Fix `index out of bounds` exception thrown in rare cases by `rescript-editor-analysis.exe codeAction` command. https://github.com/rescript-lang/rescript/pull/7523
 - Don't produce duplicate type definitions for recursive types on hover. https://github.com/rescript-lang/rescript/pull/7524
-- Prop punning when types don't match results in I/O error: _none_: No such file or directory. https://github.com/rescript-lang/rescript/pull/7533
-- Pass location to children prop in jsx ppx. https://github.com/rescript-lang/rescript/pull/7540
+- Prop punning when types don't match results in `I/O error: _none_: No such file or directory`. https://github.com/rescript-lang/rescript/pull/7533
+- Fix partial application with user-defined function types. https://github.com/rescript-lang/rescript/pull/7548
+- Fix doc comment before variant throwing syntax error. https://github.com/rescript-lang/rescript/pull/7535
+- Fix apparent non-determinism in generated code for pattern matching. https://github.com/rescript-lang/rescript/pull/7557
 
 #### :nail_care: Polish
 
@@ -51,11 +76,15 @@
 - In module declarations, accept the invalid syntax `M = {...}` and format it to `M : {...}`. https://github.com/rescript-lang/rescript/pull/7527
 - Improve doc comment formatting to match the style of multiline comments. https://github.com/rescript-lang/rescript/pull/7529
 - Improve error messages around type mismatches for try/catch, if, for, while, and optional record fields + optional function arguments. https://github.com/rescript-lang/rescript/pull/7522
+- Sync reanalyze with the new APIs around exception. https://github.com/rescript-lang/rescript/pull/7536
+- Improve array pattern spread error message. https://github.com/rescript-lang/rescript/pull/7549
+- Sync API docs with rescript-lang.org on release. https://github.com/rescript-lang/rescript/pull/7555
 
 #### :house: Internal
 
 - Refactor the ast for record expressions and patterns. https://github.com/rescript-lang/rescript/pull/7528
 - Editor: add completions from included modules. https://github.com/rescript-lang/rescript/pull/7515
+- Add `-editor-mode` arg to `bsc` for doing special optimizations only relevant to the editor tooling. https://github.com/rescript-lang/rescript/pull/7541
 
 # 12.0.0-alpha.13
 

CLAUDE.md

@@ -0,0 +1,139 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## Project Overview
+
+This is the ReScript compiler repository - a robustly typed language that compiles to efficient and human-readable JavaScript. ReScript is built using OCaml and includes a complete toolchain with compiler, build system, syntax parser, and standard library.
+
+## Build Commands
+
+### Basic Development
+```bash
+# Build compiler and copy executables
+make
+
+# Build in watch mode 
+make watch
+
+# Build everything including standard library
+make lib
+
+# Build artifacts and update artifact list
+make artifacts
+```
+
+### Testing
+```bash
+# Run all tests
+make test
+
+# Run specific test types
+make test-syntax           # Syntax parser tests
+make test-syntax-roundtrip # Roundtrip syntax tests  
+make test-gentype         # GenType tests
+make test-analysis        # Analysis tests
+make test-tools           # Tools tests
+make test-rewatch         # Rewatch tests
+
+# Run single file test
+./cli/bsc.js myTestFile.res
+
+# View parse/typed trees for debugging
+./cli/bsc.js -dparsetree myTestFile.res
+./cli/bsc.js -dtypedtree myTestFile.res
+```
+
+### Code Quality
+```bash
+# Format code
+make format
+
+# Check formatting
+make checkformat
+
+# Lint with Biome
+npm run check
+npm run check:all
+
+# TypeScript type checking  
+npm run typecheck
+```
+
+### Clean Operations
+```bash
+make clean      # Clean OCaml build artifacts
+make clean-all  # Clean everything including Rust/gentype
+```
+
+## Compiler Architecture
+
+The ReScript compiler follows this high-level pipeline:
+
+```
+ReScript Source (.res)
+  ↓ (ReScript Parser - compiler/syntax/)
+Surface Syntax Tree  
+  ↓ (Frontend transformations - compiler/frontend/)
+Surface Syntax Tree
+  ↓ (OCaml Type Checker - compiler/ml/)
+Typedtree
+  ↓ (Lambda compilation - compiler/core/lam_*)
+Lambda IR
+  ↓ (JS compilation - compiler/core/js_*)  
+JS IR
+  ↓ (JS output - compiler/core/js_dump*)
+JavaScript Code
+```
+
+### Key Directories
+
+- **`compiler/syntax/`** - ReScript syntax parser (MIT licensed, separate from main LGPL)
+- **`compiler/frontend/`** - AST transformations, external FFI processing, built-in attributes
+- **`compiler/ml/`** - OCaml compiler infrastructure (type checker, typedtree, etc.)
+- **`compiler/core/`** - Core compilation:
+  - `lam_*` files: Lambda IR compilation and optimization passes
+  - `js_*` files: JavaScript IR and code generation
+- **`compiler/ext/`** - Extended utilities and data structures
+- **`compiler/bsb/`** - Build system implementation
+- **`compiler/gentype/`** - TypeScript generation
+- **`runtime/`** - ReScript standard library (written in ReScript)
+- **`lib/`** - Compiled JavaScript output of standard library
+- **`analysis/`** - Language server and tooling support
+
+### Build System Components
+
+- **`compiler/bsb_exe/`** - Main ReScript build tool entry point
+- **`compiler/bsc/`** - Compiler binary entry point  
+- **`rewatch/`** - File watcher (written in Rust)
+- **`ninja/`** - Vendored Ninja build system
+
+## Development Setup Notes
+
+- Uses OCaml 5.3.0+ with opam for compiler development
+- Uses dune as build system with specific profiles (dev, release, browser)
+- Node.js 20+ required for JavaScript tooling
+- Rust toolchain needed for rewatch file watcher
+- Python ≤3.11 required for building ninja
+
+## Coding Conventions
+
+- **OCaml code**: snake_case (e.g., `to_string`)
+- **ReScript code**: camelCase (e.g., `toString`)
+- Use DCO sign-off for all commits: `Signed-Off-By: Your Name <email>`
+
+## Testing Strategy
+
+- **Mocha tests** (`tests/tests/`) - Runtime library unit tests
+- **Build system tests** (`tests/build_tests/`) - Integration tests  
+- **OUnit tests** (`tests/ounit_tests/`) - Compiler unit tests
+- **Expectation tests** - Plain `.res` files that check compilation output
+- Always include appropriate tests with new features/changes
+
+## Performance Notes
+
+The compiler is designed for fast feedback loops and scales to large codebases. When making changes:
+- Avoid introducing meaningless symbols
+- Maintain readable JavaScript output
+- Consider compilation speed impact
+- Use appropriate optimization passes in the Lambda and JS IRs

CONTRIBUTING.md

@@ -14,7 +14,7 @@ Happy hacking!
 
 > Most of our contributors are working on Apple machines, so all our instructions are currently macOS / Linux centric. Contributions for Windows development welcome!
 
-- [Node.js](https://nodejs.org/) v20.x
+- [Node.js](https://nodejs.org/) v22.x
 - [Yarn CLI](https://yarnpkg.com/getting-started/install) (can be installed with `corepack`, Homebrew, etc)
 - C compiler toolchain (usually installed with `xcode` on Mac)
 - Python <= 3.11 (required to build ninja)