Simplify boolean optimisation

Author: mediremi

compiler/core/lam_pass_remove_alias.ml

@@ -24,27 +24,19 @@
 
 type outcome = Eval_false | Eval_true | Eval_unknown
 
-let rec id_is_for_sure_true_in_boolean (tbl : Lam_stats.ident_tbl) id =
+let id_is_for_sure_true_in_boolean (tbl : Lam_stats.ident_tbl) id =
   match Hash_ident.find_opt tbl id with
-  | Some
-      (Normal_optional
-         ( Lprim {loc = _; primitive = Psome_not_nest; args = [Lvar id']}
-         | Lvar id' )) ->
-    id_is_for_sure_true_in_boolean tbl id'
   | Some
       (Normal_optional
          (Lconst (Const_js_false | Const_js_null | Const_js_undefined _))) ->
     Eval_false
-  | Some (Normal_optional _)
-  | Some (ImmutableBlock _)
-  | Some (MutableBlock _)
-  | Some (Constant (Const_block _ | Const_js_true)) ->
-    Eval_true
+  | Some (Constant Const_js_true) -> Eval_true
   | Some (Constant (Const_int {i})) -> if i = 0l then Eval_false else Eval_true
   | Some (Constant (Const_js_false | Const_js_null | Const_js_undefined _)) ->
     Eval_false
   | Some
-      ( Constant _ | Module _ | FunctionId _ | Exception | Parameter | NA
+      ( Normal_optional _ | ImmutableBlock _ | MutableBlock _ | Constant _
+      | Module _ | FunctionId _ | Exception | Parameter | NA
       | OptionalBlock (_, (Undefined | Null | Null_undefined)) )
   | None ->
     Eval_unknown