Skip to content

Better error message if platform binaries package is not found #7698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025
Merged

Better error message if platform binaries package is not found #7698

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7f9a8e
Better error message if platform binaries package is not found
cknitt Jul 22, 2025
d4c413e
CHANGELOG
cknitt Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions cli/common/bins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,28 @@

const target = `${process.platform}-${process.arch}`;

const supportedPlatforms = [
"darwin-arm64",
"darwin-x64",
"linux-arm64",
"linux-x64",
"win32-x64",
];

/** @type {BinaryModuleExports} */
let mod;
try {
mod = await import(`@rescript/${target}`);
} catch {

if (supportedPlatforms.includes(target)) {
const binPackageName = `@rescript/${target}`;

try {
mod = await import(binPackageName);
} catch {
throw new Error(
`Package ${binPackageName} not found. Make sure the rescript package is installed correctly.`,
);
}
} else {
throw new Error(`Platform ${target} is not supported!`);
}

Expand Down