Skip to content

Removed "rescript legacy" subcommand in favor of separate "rescript-legacy" binary #7928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 30, 2025
Merged

Removed "rescript legacy" subcommand in favor of separate "rescript-legacy" binary #7928

merged 4 commits into from
Sep 30, 2025

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Sep 29, 2025 •
edited
Loading

Removed "rescript legacy" subcommand in favor of separate "rescript-legacy" binary.

This

  • cleans up the rewatch code
  • ensures that the legacy command line handling will stay exactly the same as it was in v11 as it does not need to be forwarded through clap

The information about how to run the legacy build system is now shown at the bottom of the rescript help:

ReScript - Fast, Simple, Fully Typed JavaScript from the Future

Usage: rescript [OPTIONS] <COMMAND>

Commands:
  build          Build the project (default command)
  watch          Build, then start a watcher
  clean          Clean the build artifacts
  format         Formats ReScript files
  compiler-args  This prints the compiler arguments. It expects the path to a rescript file (.res or .resi)
  help           Print this message or the help of the given subcommand(s)

Options:
  -v, --verbose...  Increase logging verbosity
  -q, --quiet...    Decrease logging verbosity
  -h, --help        Print help
  -V, --version     Print version

Notes:
  - If no command is provided, the build command is run by default. See `rescript help build` for more information.
  - For the legacy (pre-v12) build system, run `rescript-legacy` instead.

@cknitt cknitt changed the title Removed "rescript legacy" subcommand in favor of separate "rescript-l… Removed "rescript legacy" subcommand in favor of separate "rescript-legacy" binary Sep 29, 2025
@cknitt cknitt force-pushed the remove-legacy-command branch from 49ec99d to aaf4b05 Compare September 29, 2025 14:30
@cknitt cknitt force-pushed the remove-legacy-command branch from aaf4b05 to dc20b65 Compare September 29, 2025 14:32
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 29, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7928

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7928

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7928

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7928

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7928

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7928

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7928

commit: dc20b65

@cknitt cknitt requested review from Bushuo and nojaf September 29, 2025 15:02
@cknitt cknitt merged commit 57c696b into master Sep 30, 2025
25 checks passed
@cknitt cknitt deleted the remove-legacy-command branch September 30, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nojaf nojaf nojaf approved these changes

@Bushuo Bushuo Awaiting requested review from Bushuo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cknitt @nojaf