⚡ - Iter -> par_iter on package_tree build

build-package-tree      time:   [118.39 ms 120.47 ms 122.68 ms]
                        change: [-52.142% -47.075% -40.879%] (p = 0.00 < 0.05)
                        Performance has improved.

Author: Roland Peelen

benches/base_bench.rs

@@ -1,10 +1,22 @@
 use criterion::{criterion_group, criterion_main, Criterion};
 use rewatch::build;
+use rewatch::package_tree;
+use rewatch::helpers;
 
 use std::fs::File;
 use std::io::prelude::*;
 
 fn criterion_benchmark(c: &mut Criterion) {
+    c.bench_function("build-package-tree", |b| {
+        // Folder for the testrepo
+        let folder = "walnut_monorepo";
+        let project_root = helpers::get_abs_path(folder);
+
+        b.iter(|| {
+            package_tree::make(&project_root);
+        })
+    });
+
     c.bench_function("clean-build-change-build", |b| {
         // Folder for the testrepo
         let folder = "testrepo";

src/package_tree.rs

@@ -29,8 +29,8 @@ impl PartialEq for Package {
 }
 impl Eq for Package {}
 impl Hash for Package {
-    fn hash<H: Hasher>(&self, state: &mut H) {
-        self.name.hash(state);
+    fn hash<H: Hasher>(&self, _state: &mut H) {
+        blake3::hash(&self.name.as_bytes());
     }
 }
 
@@ -70,8 +70,7 @@ fn get_source_dirs(
     if !full_recursive {
         subdirs
             .unwrap_or(vec![])
-            // I don't think we do any io here so par_iter is probably slower than iter
-            .iter()
+            .par_iter()
             .map(|subdir| get_source_dirs(&full_path, subdir.to_owned()))
             .collect::<Vec<AHashSet<(String, bsconfig::PackageSource)>>>()
             .into_iter()
@@ -81,12 +80,6 @@ fn get_source_dirs(
     source_folders
 }
 
-// fn add_bsconfig_package(
-//     map: &'a mut AHashMap<String, Package>,
-//     bsconfig: bsconfig::T,
-// ) -> (&'a mut AHashMap<String, Package>, Vec(String)) {
-// }
-
 fn get_package_dir(package_name: &str, is_root: bool, project_root: &str) -> String {
     if is_root {
         project_root.to_owned()
@@ -125,7 +118,6 @@ fn build_package<'a>(
                 let mut source_folders: AHashSet<(String, bsconfig::PackageSource)> =
                     AHashSet::new();
                 sources
-                    // I don't think we do any IO here so probably faster to just do iter
                     .iter()
                     .map(|source| get_source_dirs(&package_dir, source.to_owned()))
                     .collect::<Vec<AHashSet<(String, bsconfig::PackageSource)>>>()