refactor(takeRecords): removed takeRecords as it didn't fit a good case

Author: Rendez

README.md

@@ -64,10 +64,11 @@ npm install --save intersection-observer
 
 #### Inside your codebase
 ```jsx
+import React, { Component } from 'react';
 import 'intersection-observer'; // adding optional polyfill
 import Observer from '@researchgate/react-intersection-observer';
 
-class Component extends React.Component {
+class TargetComponent extends Component {
     handleIntersection = (event) => {
         if (event.isIntersecting) {
             console.log('I am intersecting ');
@@ -80,7 +81,7 @@ class Component extends React.Component {
         const options = {
             onChange: this.handleIntersection
             root: "#scrolling-container"
-            rootMargin: "0% 0% -25% 0%"
+            rootMargin: "0% 0% -25%"
         };
 
         return (
@@ -176,29 +177,6 @@ Type: `element|component`
 
 Single React component or element that is used as the target to observe.
 
-## Methods
-
-### takeRecords(options?: IntersectionObserverOptions)
-
-Calls all the observer instance's `takeRecords()` methods if no options are passed, and if options are passed triggers only those matching all of the options.
-
-> The `IntersectionObserver` method `takeRecords()` returns an array of `IntersectionObserverEntry` objects, one for each targeted element which has experienced an intersection change since the last time the intersections were checked, either explicitly through a call to this method or implicitly by an automatic call to the observer's callback.
->
-> – [MDN: IntersectionObserver.takeRecords()](https://developer.mozilla.org/en-US/docs/Web/API/IntersectionObserver/takeRecords)
-
-#### [What are the use cases of `takeRecords`?](https://github.com/WICG/IntersectionObserver/issues/133#issuecomment-224368861)
-In cases where you need to synchronously get any `IntersectionObserverEntry` objects that have been generated but not yet delivered.
-
-#### Usage
-```js
-import { takeRecords } from '@researchgate/react-intersection-observer';
-
-takeRecords({
-    root: document.getElementById('#scrolling-container'),
-    rootMargin: '0% 0% -25% 0%',
-});
-```
-
 ## Polyfill
 
 When needing the full spec's support, we highly recommend using the [IntersectionObserver polyfill](https://github.com/WICG/IntersectionObserver/tree/gh-pages/polyfill).

src/IntersectionObserverContainer.js

@@ -45,20 +45,6 @@ export default class IntersectionObserverContainer {
     return null;
   }
 
-  static takeRecords(options) {
-    if (options) {
-      const observer = getPooled(options);
-      if (observer) {
-        observer.takeRecords();
-      }
-    } else {
-      // eslint-disable-next-line no-restricted-syntax
-      for (const observer of storage.keys()) {
-        observer.takeRecords();
-      }
-    }
-  }
-
   static observe(element) {
     let targets;
     if (storage.has(element.observer)) {

src/index.js

@@ -1,5 +1,2 @@
-import IntersectionObserverContainer from './IntersectionObserverContainer';
-
 export { default } from './IntersectionObserver';
 export { parseRootMargin } from './utils';
-export const takeRecords = IntersectionObserverContainer.takeRecords;

test/IntersectionObserverContainer.test.js

@@ -179,40 +179,3 @@ describe('#findElement', () => {
     expect(instance2).toEqual(entry2);
   });
 });
-
-describe('#takeRecords', () => {
-  test('should get called once on the observer retrieved by matching options', () => {
-    const options = { ...defaultOptions, threshold: 1 };
-    const observer = IntersectionObserverContainer.create(noop, options);
-    const element = { target: { nodeType: 1, id: 1 }, observer };
-    IntersectionObserverContainer.observe(element);
-    const spy = jest.spyOn(observer, 'takeRecords');
-    IntersectionObserverContainer.takeRecords(options);
-    IntersectionObserverContainer.takeRecords(defaultOptions);
-    expect(spy).toHaveBeenCalledTimes(1);
-  });
-
-  test('should get called once for all observers not having options argument', () => {
-    const observer1 = IntersectionObserverContainer.create(noop, defaultOptions);
-    const element1 = { target: { nodeType: 1, id: 1 }, observer: observer1 };
-    IntersectionObserverContainer.observe(element1);
-    const options = { ...defaultOptions, threshold: 1 };
-    const observer2 = IntersectionObserverContainer.create(noop, options);
-    const element2 = { target: { nodeType: 1, id: 1 }, observer: observer2 };
-    IntersectionObserverContainer.observe(element2);
-    const spy1 = jest.spyOn(observer1, 'takeRecords');
-    const spy2 = jest.spyOn(observer2, 'takeRecords');
-    IntersectionObserverContainer.takeRecords();
-    expect(storage.size).toEqual(2);
-    expect(spy1).toHaveBeenCalledTimes(1);
-    expect(spy2).toHaveBeenCalledTimes(1);
-  });
-
-  test('never gets called when storage holds no observers', () => {
-    const observer = IntersectionObserverContainer.create(noop, defaultOptions);
-    const spy = jest.spyOn(observer, 'takeRecords');
-    IntersectionObserverContainer.takeRecords();
-    IntersectionObserverContainer.takeRecords(defaultOptions);
-    expect(spy).not.toBeCalled();
-  });
-});