Skip to content

Commit cbeee98

Browse files
authored
feat: address linter feedback for "reset-password" emails (#1983)
1 parent a949804 commit cbeee98

File tree

2 files changed

+23
-12
lines changed

2 files changed

+23
-12
lines changed

apps/demo/emails/reset-password/dropbox-reset-password.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export const DropboxResetPasswordEmail = ({
5252
<Text style={text}>
5353
To keep your account secure, please don&apos;t forward this email
5454
to anyone. See our Help Center for{' '}
55-
<Link style={anchor} href="https://dropbox.com">
55+
<Link style={anchor} href={resetPasswordLink}>
5656
more security tips.
5757
</Link>
5858
</Text>
@@ -66,7 +66,7 @@ export const DropboxResetPasswordEmail = ({
6666

6767
DropboxResetPasswordEmail.PreviewProps = {
6868
userFirstname: 'Alan',
69-
resetPasswordLink: 'https://dropbox.com',
69+
resetPasswordLink: 'https://www.dropbox.com',
7070
} as DropboxResetPasswordEmailProps;
7171

7272
export default DropboxResetPasswordEmail;

apps/demo/emails/reset-password/twitch-reset-password.tsx

Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,12 @@ export const TwitchResetPasswordEmail = ({
3737
<Preview>You updated the password for your Twitch account</Preview>
3838
<Container style={container}>
3939
<Section style={logo}>
40-
<Img width={114} src={`${baseUrl}/static/twitch-logo.png`} />
40+
<Img
41+
width={114}
42+
src={`${baseUrl}/static/twitch-logo.png`}
43+
alt="Twitch"
44+
style={logoImg}
45+
/>
4146
</Section>
4247
<Section style={sectionsBorders}>
4348
<Row>
@@ -55,7 +60,7 @@ export const TwitchResetPasswordEmail = ({
5560
</Text>
5661
<Text style={paragraph}>
5762
However if you did NOT perform this password change, please{' '}
58-
<Link href="#" style={link}>
63+
<Link href="https://www.twitch.tv" style={link}>
5964
reset your account password
6065
</Link>{' '}
6166
immediately.
@@ -64,13 +69,13 @@ export const TwitchResetPasswordEmail = ({
6469
Remember to use a password that is both strong and unique to your
6570
Twitch account. To learn more about how to create a strong and
6671
unique password,{' '}
67-
<Link href="#" style={link}>
72+
<Link href="https://www.twitch.tv" style={link}>
6873
click here.
6974
</Link>
7075
</Text>
7176
<Text style={paragraph}>
7277
Still have questions? Please contact{' '}
73-
<Link href="#" style={link}>
78+
<Link href="https://www.twitch.tv" style={link}>
7479
Twitch Support
7580
</Link>
7681
</Text>
@@ -85,10 +90,16 @@ export const TwitchResetPasswordEmail = ({
8590
<Section style={footer}>
8691
<Row>
8792
<Column align="right" style={{ width: '50%', paddingRight: '8px' }}>
88-
<Img src={`${baseUrl}/static/twitch-icon-twitter.png`} />
93+
<Img
94+
src={`${baseUrl}/static/twitch-icon-twitter.png`}
95+
alt="Twitter"
96+
/>
8997
</Column>
9098
<Column align="left" style={{ width: '50%', paddingLeft: '8px' }}>
91-
<Img src={`${baseUrl}/static/twitch-icon-facebook.png`} />
99+
<Img
100+
src={`${baseUrl}/static/twitch-icon-facebook.png`}
101+
alt="Facebook"
102+
/>
92103
</Column>
93104
</Row>
94105
<Row>
@@ -138,15 +149,15 @@ const content = {
138149
};
139150

140151
const logo = {
141-
display: 'flex',
142-
justifyContent: 'center',
143-
alingItems: 'center',
144152
padding: 30,
145153
};
146154

155+
const logoImg = {
156+
margin: '0 auto',
157+
};
158+
147159
const sectionsBorders = {
148160
width: '100%',
149-
display: 'flex',
150161
};
151162

152163
const sectionBorder = {

0 commit comments

Comments
 (0)