feat: update types to allow type narrowing#535
Merged
Conversation
joaopcm
approved these changes
Jun 13, 2025
|
Should changing types be a major bump on semver as it causes breaking code? Works perfectly fine on 4.6 but breaks on 4.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #356
previously we had the response schemas defining both
dataanderrorto be either the value or null. but as correctly pointed in the issue, we always have either/orby updating the type definitions to something like:
we can leverage TypeScript type narrowing in the code and have better types 🎉
note the null in here:

much better:
