Add draft flag to release bundle create command (jfrog#352)

Author: jongler

cliutils/flagkit/flags.go

@@ -490,6 +490,7 @@ const (
 	lcDeleteProperties       = lifecyclePrefix + DeleteProperty
 	SourceTypeReleaseBundles = "source-type-release-bundles"
 	SourceTypeBuilds         = "source-type-builds"
+	Draft                    = "draft"
 )
 
 var commandFlags = map[string][]string{
@@ -515,7 +516,7 @@ var commandFlags = map[string][]string{
 	},
 	cmddefs.ReleaseBundleCreate: {
 		platformUrl, user, password, accessToken, serverId, lcSigningKey, lcSync, lcProject, lcBuilds, lcReleaseBundles,
-		specFlag, specVars, BuildName, BuildNumber, SourceTypeReleaseBundles, SourceTypeBuilds,
+		specFlag, specVars, BuildName, BuildNumber, SourceTypeReleaseBundles, SourceTypeBuilds, Draft,
 	},
 	cmddefs.ReleaseBundlePromote: {
 		platformUrl, user, password, accessToken, serverId, lcSigningKey, lcSync, lcProject, lcIncludeRepos,
@@ -1103,6 +1104,7 @@ var flagsMap = map[string]components.Flag{
 	lcDeleteProperties:       components.NewStringFlag(DeleteProperty, "Properties to be deleted on the of Manifest Release Bundle version.", components.SetMandatoryFalse()),
 	SourceTypeReleaseBundles: components.NewStringFlag(SourceTypeReleaseBundles, "List of semicolon-seperated(;) release bundles in the form of 'name=releaseBundleName1, version=version1; name=releaseBundleName2, version=version2' to be included in the new bundle.", components.SetMandatoryFalse()),
 	SourceTypeBuilds:         components.NewStringFlag(SourceTypeBuilds, "List of semicolon-separated(;) builds in the form of 'name=buildName1, id=runID1, include-deps=true; name=buildName2, id=runID2' to be included in the new bundle.", components.SetMandatoryFalse()),
+	Draft:                    components.NewBoolFlag(Draft, "Set to true to create the release bundle as a draft. A draft release bundle can be updated and finalized later.", components.WithBoolDefaultValueFalse()),
 }
 
 func GetCommandFlags(cmdKey string) []components.Flag {

go.mod

@@ -10,7 +10,7 @@ require (
 	github.com/jfrog/build-info-go v1.13.1-0.20260119231731-3cc4a0771bbd
 	github.com/jfrog/gofrog v1.7.6
 	github.com/jfrog/jfrog-cli-core/v2 v2.60.1-0.20260106204841-744f3f71817b
-	github.com/jfrog/jfrog-client-go v1.55.1-0.20251230061734-d954605bdb23
+	github.com/jfrog/jfrog-client-go v1.55.1-0.20260121110006-56e09db08899
 	github.com/pkg/errors v0.9.1
 	github.com/spf13/viper v1.21.0
 	github.com/stretchr/testify v1.11.1

go.sum

@@ -168,8 +168,8 @@ github.com/jfrog/gofrog v1.7.6 h1:QmfAiRzVyaI7JYGsB7cxfAJePAZTzFz0gRWZSE27c6s=
 github.com/jfrog/gofrog v1.7.6/go.mod h1:ntr1txqNOZtHplmaNd7rS4f8jpA5Apx8em70oYEe7+4=
 github.com/jfrog/jfrog-cli-core/v2 v2.60.1-0.20260106204841-744f3f71817b h1:gGGmYXuYvcNns1BnLQI13lC+pgMxrmenx+ramtolQuA=
 github.com/jfrog/jfrog-cli-core/v2 v2.60.1-0.20260106204841-744f3f71817b/go.mod h1:+Hnaikp/xCSPD/q7txxRy4Zc0wzjW/usrCSf+6uONSQ=
-github.com/jfrog/jfrog-client-go v1.55.1-0.20251230061734-d954605bdb23 h1:tL4NUrnSiFN6MeK27z96ehiKXhYZDY2DyH95ogNRHrY=
-github.com/jfrog/jfrog-client-go v1.55.1-0.20251230061734-d954605bdb23/go.mod h1:sCE06+GngPoyrGO0c+vmhgMoVSP83UMNiZnIuNPzU8U=
+github.com/jfrog/jfrog-client-go v1.55.1-0.20260121110006-56e09db08899 h1:b6DzkI3qCVUHiErnFDajICW6k1RAuXVe69AsGq2AunE=
+github.com/jfrog/jfrog-client-go v1.55.1-0.20260121110006-56e09db08899/go.mod h1:sCE06+GngPoyrGO0c+vmhgMoVSP83UMNiZnIuNPzU8U=
 github.com/kevinburke/ssh_config v1.2.0 h1:x584FjTGwHzMwvHx18PXxbBVzfnxogHaAReU4gf13a4=
 github.com/kevinburke/ssh_config v1.2.0/go.mod h1:CT57kijsi8u/K/BOFA39wgDQJ9CxiF4nAY/ojJ6r6mM=
 github.com/klauspost/compress v1.4.1/go.mod h1:RyIbtBH6LamlWaDj8nUwkbUhJ87Yi3uG0guNDohfE1A=

lifecycle/cli.go

@@ -3,12 +3,13 @@ package lifecycle
 import (
 	"errors"
 	"fmt"
-	"github.com/jfrog/jfrog-cli-artifactory/artifactory/cli"
-	rbsearch "github.com/jfrog/jfrog-cli-artifactory/lifecycle/docs/rbsearch"
 	"os"
 	"strconv"
 	"strings"
 
+	"github.com/jfrog/jfrog-cli-artifactory/artifactory/cli"
+	rbsearch "github.com/jfrog/jfrog-cli-artifactory/lifecycle/docs/rbsearch"
+
 	"github.com/jfrog/jfrog-cli-artifactory/cliutils/cmddefs"
 	"github.com/jfrog/jfrog-cli-artifactory/cliutils/distribution"
 	"github.com/jfrog/jfrog-cli-artifactory/cliutils/flagkit"
@@ -230,7 +231,7 @@ func create(c *components.Context) (err error) {
 	}
 	createCmd := lifecycle.NewReleaseBundleCreateCommand().SetServerDetails(lcDetails).SetReleaseBundleName(c.GetArgumentAt(0)).
 		SetReleaseBundleVersion(c.GetArgumentAt(1)).SetSigningKeyName(c.GetStringFlagValue(flagkit.SigningKey)).
-		SetSync(c.GetBoolFlagValue(flagkit.Sync)).
+		SetSync(c.GetBoolFlagValue(flagkit.Sync)).SetDraft(c.GetBoolFlagValue(flagkit.Draft)).
 		SetReleaseBundleProject(pluginsCommon.GetProject(c)).SetSpec(creationSpec).
 		SetBuildsSpecPath(c.GetStringFlagValue(flagkit.Builds)).SetReleaseBundlesSpecPath(c.GetStringFlagValue(flagkit.ReleaseBundles))
 

lifecycle/cli_test.go

@@ -2,15 +2,16 @@ package lifecycle
 
 import (
 	"bytes"
+	"path/filepath"
+	"strings"
+	"testing"
+
 	"github.com/jfrog/jfrog-cli-artifactory/cliutils/flagkit"
 	pluginsCommon "github.com/jfrog/jfrog-cli-core/v2/plugins/common"
 	"github.com/jfrog/jfrog-cli-core/v2/plugins/components"
 	"github.com/jfrog/jfrog-cli-core/v2/utils/coreutils"
 	clientTestUtils "github.com/jfrog/jfrog-client-go/utils/tests"
 	"github.com/stretchr/testify/assert"
-	"path/filepath"
-	"strings"
-	"testing"
 )
 
 func TestValidateCreateReleaseBundleContext(t *testing.T) {
@@ -35,6 +36,11 @@ func TestValidateCreateReleaseBundleContext(t *testing.T) {
 		{"spec without signing key", []string{"name", "version", "env"}, []string{"spec=/path/to/file"}, true},
 		{"spec correct", []string{"name", "version"}, []string{
 			"spec=/path/to/file", flagkit.SigningKey + "=key"}, false},
+		// Draft flag tests - draft flag should not affect validation
+		{"spec with draft flag", []string{"name", "version"}, []string{
+			"spec=/path/to/file", flagkit.SigningKey + "=key"}, false},
+		{"builds with draft flag", []string{"name", "version"}, []string{
+			flagkit.Builds + "=/path/to/file", flagkit.SigningKey + "=key"}, false},
 	}
 
 	for _, test := range testRuns {
@@ -151,3 +157,35 @@ func CreateContext(t *testing.T, testStringFlags, testArgs []string, testBoolFla
 	}
 	return ctx, &bytes.Buffer{}
 }
+
+func TestDraftFlagReading(t *testing.T) {
+	testRuns := []struct {
+		name          string
+		boolFlags     map[string]bool
+		expectedDraft bool
+	}{
+		{
+			name:          "draft flag not set",
+			boolFlags:     nil,
+			expectedDraft: false,
+		},
+		{
+			name:          "draft flag set to true",
+			boolFlags:     map[string]bool{flagkit.Draft: true},
+			expectedDraft: true,
+		},
+		{
+			name:          "draft flag set to false",
+			boolFlags:     map[string]bool{flagkit.Draft: false},
+			expectedDraft: false,
+		},
+	}
+
+	for _, test := range testRuns {
+		t.Run(test.name, func(t *testing.T) {
+			context, _ := CreateContext(t, []string{}, []string{}, test.boolFlags)
+			draftValue := context.GetBoolFlagValue(flagkit.Draft)
+			assert.Equal(t, test.expectedDraft, draftValue)
+		})
+	}
+}

lifecycle/commands/createcommon.go

@@ -34,6 +34,7 @@ type ReleaseBundleCreateCommand struct {
 	releaseBundleCmd
 	signingKeyName string
 	spec           *spec.SpecFiles
+	draft          bool
 	// Backward compatibility:
 	buildsSpecPath         string
 	releaseBundlesSpecPath string
@@ -81,6 +82,11 @@ func (rbc *ReleaseBundleCreateCommand) SetSpec(spec *spec.SpecFiles) *ReleaseBun
 	return rbc
 }
 
+func (rbc *ReleaseBundleCreateCommand) SetDraft(draft bool) *ReleaseBundleCreateCommand {
+	rbc.draft = draft
+	return rbc
+}
+
 // Deprecated
 func (rbc *ReleaseBundleCreateCommand) SetBuildsSpecPath(buildsSpecPath string) *ReleaseBundleCreateCommand {
 	rbc.buildsSpecPath = buildsSpecPath
@@ -389,7 +395,7 @@ func (rbc *ReleaseBundleCreateCommand) multiSourcesDefinedFromSpec() ([]services
 func (rbc *ReleaseBundleCreateCommand) createFromMultipleSources(servicesManager *lifecycle.LifecycleServicesManager,
 	rbDetails services.ReleaseBundleDetails, queryParams services.CommonOptionalQueryParams,
 	sources []services.RbSource) (response []byte, err error) {
-	return servicesManager.CreateReleaseBundlesFromMultipleSources(rbDetails, queryParams, rbc.signingKeyName, sources)
+	return servicesManager.CreateReleaseBundlesFromMultipleSourcesDraft(rbDetails, queryParams, rbc.signingKeyName, sources, rbc.draft)
 }
 
 func (rbc *ReleaseBundleCreateCommand) createAqlQueryFromSpec() (aql string) {

lifecycle/commands/createfromaql.go

@@ -8,5 +8,5 @@ import (
 func (rbc *ReleaseBundleCreateCommand) createFromAql(servicesManager *lifecycle.LifecycleServicesManager,
 	rbDetails services.ReleaseBundleDetails, queryParams services.CommonOptionalQueryParams) error {
 	aqlQuery := rbc.createAqlQueryFromSpec()
-	return servicesManager.CreateReleaseBundleFromAql(rbDetails, queryParams, rbc.signingKeyName, aqlQuery)
+	return servicesManager.CreateReleaseBundleFromAqlDraft(rbDetails, queryParams, rbc.signingKeyName, aqlQuery, rbc.draft)
 }

lifecycle/commands/createfromartifacts.go

@@ -19,7 +19,7 @@ func (rbc *ReleaseBundleCreateCommand) createFromArtifacts(lcServicesManager *li
 		return err
 	}
 
-	return lcServicesManager.CreateReleaseBundleFromArtifacts(rbDetails, queryParams, rbc.signingKeyName, artifactsSource)
+	return lcServicesManager.CreateReleaseBundleFromArtifactsDraft(rbDetails, queryParams, rbc.signingKeyName, artifactsSource, rbc.draft)
 }
 
 func (rbc *ReleaseBundleCreateCommand) getArtifactFilesFromSpec() []spec.File {

lifecycle/commands/createfrombuilds.go

@@ -25,7 +25,7 @@ func (rbc *ReleaseBundleCreateCommand) createFromBuilds(servicesManager *lifecyc
 		return errorutils.CheckErrorf("at least one build is expected in order to create a release bundle from builds")
 	}
 
-	return servicesManager.CreateReleaseBundleFromBuilds(rbDetails, queryParams, rbc.signingKeyName, buildsSource)
+	return servicesManager.CreateReleaseBundleFromBuildsDraft(rbDetails, queryParams, rbc.signingKeyName, buildsSource, rbc.draft)
 }
 
 func (rbc *ReleaseBundleCreateCommand) createBuildSourceFromSpec() (buildsSource services.CreateFromBuildsSource, err error) {

lifecycle/commands/createfrombundles.go

@@ -23,7 +23,7 @@ func (rbc *ReleaseBundleCreateCommand) createFromReleaseBundles(servicesManager
 		return errorutils.CheckErrorf("at least one release bundle is expected in order to create a release bundle from release bundles")
 	}
 
-	return servicesManager.CreateReleaseBundleFromBundles(rbDetails, queryParams, rbc.signingKeyName, releaseBundlesSource)
+	return servicesManager.CreateReleaseBundleFromBundlesDraft(rbDetails, queryParams, rbc.signingKeyName, releaseBundlesSource, rbc.draft)
 }
 
 func (rbc *ReleaseBundleCreateCommand) createReleaseBundleSourceFromSpec() (services.CreateFromReleaseBundlesSource, error) {