remvoed unused methods and tests

Author: reshmifrog

artifactory/commands/conan/artifacts.go

@@ -214,7 +214,7 @@ func (bps *BuildPropertySetter) SetProperties(artifacts []entities.Artifact) err
 	timestamp := strconv.FormatInt(time.Now().UnixMilli(), 10)
 	props := bps.formatBuildProperties(timestamp)
 
-	_, err = servicesManager.SetProps(services.PropsParams{Reader: reader, Props: props})
+	_, err = servicesManager.SetProps(services.PropsParams{Reader: reader, Props: props, UseDebugLogs: true, IsRecursive: true})
 	if err != nil {
 		return fmt.Errorf("set properties: %w", err)
 	}

artifactory/commands/conan/artifacts_test.go

@@ -149,56 +149,6 @@ func TestBuildArtifactQuery(t *testing.T) {
 	}
 }
 
-func TestClassifyArtifactType(t *testing.T) {
-	tests := []struct {
-		name     string
-		filename string
-		expected string
-	}{
-		{
-			name:     "Conan recipe file",
-			filename: "conanfile.py",
-			expected: "conan-recipe",
-		},
-		{
-			name:     "Conan manifest file",
-			filename: "conanmanifest.txt",
-			expected: "conan-manifest",
-		},
-		{
-			name:     "Conan info file",
-			filename: "conaninfo.txt",
-			expected: "conan-info",
-		},
-		{
-			name:     "Conan sources archive",
-			filename: "conan_sources.tgz",
-			expected: "conan-package",
-		},
-		{
-			name:     "Conan package archive",
-			filename: "conan_package.tgz",
-			expected: "conan-package",
-		},
-		{
-			name:     "Unknown file type",
-			filename: "readme.md",
-			expected: "conan-artifact",
-		},
-		{
-			name:     "Header file",
-			filename: "mylib.h",
-			expected: "conan-artifact",
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			result := classifyArtifactType(tt.filename)
-			assert.Equal(t, tt.expected, result)
-		})
-	}
-}
 
 func TestBuildPropertySetter_FormatBuildProperties(t *testing.T) {
 	tests := []struct {

artifactory/commands/conan/command_test.go

@@ -121,15 +121,6 @@ func TestConanCommand_ChainedSetters(t *testing.T) {
 	assert.Equal(t, serverDetails, cmd.serverDetails)
 }
 
-func TestNewDependencyCollector(t *testing.T) {
-	workingDir := "/test/path"
-	
-	collector := NewDependencyCollector(workingDir, nil)
-	
-	assert.NotNil(t, collector)
-	assert.Equal(t, workingDir, collector.workingDir)
-	assert.Nil(t, collector.buildConfiguration)
-}
 
 
 

artifactory/commands/conan/login_test.go

@@ -213,7 +213,7 @@ func TestExtractCredentials(t *testing.T) {
 			serverDetails: &config.ServerDetails{
 				AccessToken: "my-access-token",
 			},
-			expectedUsername: "token",
+			expectedUsername: "admin", // Defaults to "admin" when no user specified
 			expectedPassword: "my-access-token",
 			expectError:      false,
 		},
@@ -228,14 +228,14 @@ func TestExtractCredentials(t *testing.T) {
 			expectError:      false,
 		},
 		{
-			name: "Prefer access token over password",
+			name: "Prefer password over access token",
 			serverDetails: &config.ServerDetails{
 				User:        "myuser",
 				Password:    "mypassword",
 				AccessToken: "my-access-token",
 			},
 			expectedUsername: "myuser",
-			expectedPassword: "my-access-token",
+			expectedPassword: "mypassword", // Password is preferred for Conan (API keys work more reliably)
 			expectError:      false,
 		},
 		{

artifactory/commands/conan/upload_test.go

@@ -114,46 +114,6 @@ Upload completed in 3s
 	}
 }
 
-func TestUploadProcessor_ParseUploadPattern(t *testing.T) {
-	tests := []struct {
-		name     string
-		lines    []string
-		expected string
-	}{
-		{
-			name: "Standard uploading recipe line",
-			lines: []string{
-				"simplelib/1.0.0: Uploading recipe 'simplelib/1.0.0#86deb56ab95f8fe27d07debf8a6ee3f9' (1.6KB)",
-			},
-			expected: "simplelib/1.0.0",
-		},
-		{
-			name: "Multiple lines with uploading recipe",
-			lines: []string{
-				"Some other line",
-				"mypackage/2.0.0: Uploading recipe 'mypackage/2.0.0#abc123' (2KB)",
-				"Another line",
-			},
-			expected: "mypackage/2.0.0",
-		},
-		{
-			name: "No uploading recipe line",
-			lines: []string{
-				"Some output",
-				"No recipe here",
-			},
-			expected: "",
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			processor := &UploadProcessor{}
-			result := processor.parseUploadPattern(tt.lines)
-			assert.Equal(t, tt.expected, result)
-		})
-	}
-}
 
 func TestNewUploadProcessor(t *testing.T) {
 	workingDir := "/test/path"
@@ -166,15 +126,6 @@ func TestNewUploadProcessor(t *testing.T) {
 	assert.Nil(t, processor.serverDetails)
 }
 
-func TestNewFlexPackCollector(t *testing.T) {
-	workingDir := "/test/path"
-	
-	collector, err := NewFlexPackCollector(workingDir)
-	
-	assert.NoError(t, err)
-	assert.NotNil(t, collector)
-	assert.Equal(t, workingDir, collector.config.WorkingDirectory)
-}