Skip to content

Commit 826f22f

Browse files
authored
Replaced the outdated electron-devtools-assembler with electron-devtools-installer (#1474)
1 parent 91530d1 commit 826f22f

File tree

3 files changed

+20
-25
lines changed

3 files changed

+20
-25
lines changed

desktop-app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@
129129
"detect-port": "^1.3.0",
130130
"electron": "40.6.1",
131131
"electron-builder": "^26.0.12",
132-
"electron-devtools-assembler": "^1.2.0",
132+
"electron-devtools-installer": "^4.0.0",
133133
"electronmon": "^2.0.2",
134134
"eslint": "^8.36.0",
135135
"eslint-config-prettier": "^9.1.0",

desktop-app/src/main/main.ts

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -61,26 +61,24 @@ if (isDebug) {
6161
}
6262

6363
const installExtensions = async () => {
64-
const installer = require('electron-devtools-assembler');
64+
const installer = require('electron-devtools-installer');
65+
const {
66+
REACT_DEVELOPER_TOOLS,
67+
REDUX_DEVTOOLS,
68+
EMBER_INSPECTOR,
69+
VUEJS_DEVTOOLS,
70+
APOLLO_DEVELOPER_TOOLS,
71+
} = installer;
6572
const forceDownload = !!process.env.UPGRADE_EXTENSIONS;
6673
const extensions = [
67-
'REACT_DEVELOPER_TOOLS',
68-
'REDUX_DEVTOOLS',
69-
'EMBER_INSPECTOR',
70-
'BACKBONE_DEBUGGER',
71-
'JQUERY_DEBUGGER',
72-
// 'ANGULAR_DEVTOOLS',
73-
'VUEJS_DEVTOOLS',
74-
'MOBX_DEVTOOLS',
75-
'APOLLO_DEVELOPER_TOOLS',
74+
REACT_DEVELOPER_TOOLS,
75+
REDUX_DEVTOOLS,
76+
EMBER_INSPECTOR,
77+
VUEJS_DEVTOOLS,
78+
APOLLO_DEVELOPER_TOOLS,
7679
];
7780

78-
return installer
79-
.default(
80-
extensions.map((name) => installer[name]),
81-
forceDownload
82-
)
83-
.catch(console.log);
81+
return installer.default(extensions, forceDownload).catch(console.log);
8482
};
8583

8684
const createWindow = async () => {

desktop-app/yarn.lock

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5468,14 +5468,11 @@ electron-debug@^3.2.0:
54685468
electron-is-dev "^1.1.0"
54695469
electron-localshortcut "^3.1.0"
54705470

5471-
electron-devtools-assembler@^1.2.0:
5472-
version "1.2.0"
5473-
resolved "https://registry.yarnpkg.com/electron-devtools-assembler/-/electron-devtools-assembler-1.2.0.tgz#d342af3dd6fcf54a298d40f23266c45c4456767f"
5474-
integrity sha512-5G45lxG1xrpNtLAaVnV9fj9R05lXir3IMaXu3mRteiM2vTWBk3hFaZ48fRX89DI+W7EgBQYT2bIecnPj8lRseg==
5471+
electron-devtools-installer@^4.0.0:
5472+
version "4.0.0"
5473+
resolved "https://registry.yarnpkg.com/electron-devtools-installer/-/electron-devtools-installer-4.0.0.tgz#6556a6a326cddea18194cb6d97d85c8ae329dedf"
5474+
integrity sha512-9Tntu/jtfSn0n6N/ZI6IdvRqXpDyLQiDuuIbsBI+dL+1Ef7C8J2JwByw58P3TJiNeuqyV3ZkphpNWuZK5iSY2w==
54755475
dependencies:
5476-
rimraf "^3.0.2"
5477-
semver "^7.2.1"
5478-
tslib "^2.1.0"
54795476
unzip-crx-3 "^0.2.0"
54805477

54815478
electron-is-accelerator@^0.1.0:
@@ -11637,7 +11634,7 @@ semver@^6.2.0, semver@^6.3.1:
1163711634
resolved "https://registry.yarnpkg.com/semver/-/semver-6.3.1.tgz#556d2ef8689146e46dcea4bfdd095f3434dffcb4"
1163811635
integrity sha512-BR7VvDCVHO+q2xBEWskxS6DJE1qRnb7DxzUrogb71CWoSficBxYsiAGd+Kl0mmq/MprG9yArRkyrQxTO6XjMzA==
1163911636

11640-
semver@^7.2.1, semver@^7.3.2, semver@^7.3.4, semver@^7.3.5, semver@^7.3.7, semver@^7.5.3, semver@^7.5.4, semver@^7.6.3, semver@^7.7.1, semver@~7.7.3:
11637+
semver@^7.3.2, semver@^7.3.4, semver@^7.3.5, semver@^7.3.7, semver@^7.5.3, semver@^7.5.4, semver@^7.6.3, semver@^7.7.1, semver@~7.7.3:
1164111638
version "7.7.4"
1164211639
resolved "https://registry.yarnpkg.com/semver/-/semver-7.7.4.tgz#28464e36060e991fa7a11d0279d2d3f3b57a7e8a"
1164311640
integrity sha512-vFKC2IEtQnVhpT78h1Yp8wzwrf8CM+MzKMHGJZfBtzhZNycRFnXsHk6E5TxIkkMsgNS7mdX3AGB7x2QM2di4lA==

0 commit comments

Comments
 (0)