fix up an issue where if a job managed to have a timestamp of 0, it would cause the scheduler worker to get stuck in an infinite loop

Chris Boulton · Chris Boulton · commit 2f7aae9c51b8 · 2012-05-04T14:07:06.000+10:00
diff --git a/lib/ResqueScheduler/Worker.php b/lib/ResqueScheduler/Worker.php
@@ -3,7 +3,7 @@
  * ResqueScheduler worker to handle scheduling of delayed tasks.
  *
  * @package		ResqueScheduler
- * @author		Chris Boulton <chris.boulton@interspire.com>
+ * @author		Chris Boulton <chris@bigcommerce.com>
  * @copyright	(c) 2012 Chris Boulton
  * @license		http://www.opensource.org/licenses/mit-license.php
  */
@@ -55,7 +55,7 @@ public function work($interval = null)
 	 */
 	public function handleDelayedItems($timestamp = null)
 	{
-		while ($timestamp = ResqueScheduler::nextDelayedTimestamp($timestamp)) {
+		while (($timestamp = ResqueScheduler::nextDelayedTimestamp($timestamp)) !== false) {
 			$this->updateProcLine('Processing Delayed Items');
 			$this->enqueueDelayedItemsForTimestamp($timestamp);
 		}

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`* ResqueScheduler worker to handle scheduling of delayed tasks.`
`4`	`4`	`*`
`5`	`5`	`* @package ResqueScheduler`
`6`		`- * @author Chris Boulton <chris.boulton@interspire.com>`
	`6`	`+ * @author Chris Boulton <chris@bigcommerce.com>`
`7`	`7`	`* @copyright (c) 2012 Chris Boulton`
`8`	`8`	`* @license http://www.opensource.org/licenses/mit-license.php`
`9`	`9`	`*/`
`@@ -55,7 +55,7 @@ public function work($interval = null)`
`55`	`55`	`*/`
`56`	`56`	`public function handleDelayedItems($timestamp = null)`
`57`	`57`	`{`
`58`		`- while ($timestamp = ResqueScheduler::nextDelayedTimestamp($timestamp)) {`
	`58`	`+ while (($timestamp = ResqueScheduler::nextDelayedTimestamp($timestamp)) !== false) {`
`59`	`59`	`$this->updateProcLine('Processing Delayed Items');`
`60`	`60`	`$this->enqueueDelayedItemsForTimestamp($timestamp);`
`61`	`61`	`}`