Unit tests should not be directly accessing payload[args] now that we have getArguments()

Chris Boulton · Chris Boulton · commit 700af834b4e0 · 2011-09-16T15:30:36.000+10:00
diff --git a/test/Resque/Tests/JobTest.php b/test/Resque/Tests/JobTest.php
@@ -65,7 +65,7 @@ public function testQueuedJobReturnsExactSamePassedInArguments()
 		Resque::enqueue('jobs', 'Test_Job', $args);
 		$job = Resque_Job::reserve('jobs');
 
-		$this->assertEquals($args, $job->payload['args']);
+		$this->assertEquals($args, $job->getArguments());
 	}
 
 	public function testAfterJobIsReservedItIsRemoved()
@@ -97,7 +97,7 @@ public function testRecreatedJobMatchesExistingJob()
 
 		$newJob = Resque_Job::reserve('jobs');
 		$this->assertEquals($job->payload['class'], $newJob->payload['class']);
-		$this->assertEquals($job->payload['args'], $newJob->payload['args']);
+		$this->assertEquals($job->payload['args'], $newJob->getArguments());
 	}
 
 	public function testFailedJobExceptionsAreCaught()

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ public function testQueuedJobReturnsExactSamePassedInArguments()`
`65`	`65`	`Resque::enqueue('jobs', 'Test_Job', $args);`
`66`	`66`	`$job = Resque_Job::reserve('jobs');`
`67`	`67`
`68`		`- $this->assertEquals($args, $job->payload['args']);`
	`68`	`+ $this->assertEquals($args, $job->getArguments());`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`public function testAfterJobIsReservedItIsRemoved()`
`@@ -97,7 +97,7 @@ public function testRecreatedJobMatchesExistingJob()`
`97`	`97`
`98`	`98`	`$newJob = Resque_Job::reserve('jobs');`
`99`	`99`	`$this->assertEquals($job->payload['class'], $newJob->payload['class']);`
`100`		`- $this->assertEquals($job->payload['args'], $newJob->payload['args']);`
	`100`	`+ $this->assertEquals($job->payload['args'], $newJob->getArguments());`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`public function testFailedJobExceptionsAreCaught()`