Skip to content

Should quit_excess_workers_for() respect TERM_CHILD setting? #172

@iceberg901

Description

@iceberg901

Is it necessary to send a different signal in quit_excess_workers_for when TERM_CHILD=1 is set to ensure clean shutdown of workers under Heroku signal handling conditions? Currently it always sends QUIT

    def quit_excess_workers_for(queues)
      delta = -worker_delta_for(queues)
      pids_for(queues)[0...delta].each do |pid|
        Process.kill("QUIT", pid)
      end
    end

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions