-
Notifications
You must be signed in to change notification settings - Fork 13
Closed
Labels
enhancementNew feature or requestNew feature or requestpolicyHow things should behaveHow things should behave
Description
Issues found on submodule validation pipelines after a merge inside framework #368
New implementation of validation pipelines have been proposed by triggering submodule pipelines from framework, however it requires to change the logic in the actions:
- Now submodule pipeline only triggers framework pipeline to avoid concurrency.
- Although submodule pipeline is integrated inside the corresponding submodule it is only triggered from framework upon PR (on workflow cal), however it can also be triggered on workflow dispatch (manually).
- Please check Adding submodule validation inside frameworkย #371 and Separating framework and rawlib validation in different filesย rawlib#96 for more details on the implementation.
We should decide which submodules have to be integrated inside framewok validation pipeline:
- https://github.com/rest-for-physics/rawlib
- https://github.com/rest-for-physics/geant4lib
- https://github.com/rest-for-physics/detectorlib
- https://github.com/rest-for-physics/connectorslib
- https://github.com/rest-for-physics/tracklib
- https://github.com/rest-for-physics/legacylib
- https://github.com/rest-for-physics/axionlib
- https://github.com/rest-for-physics/wimplib
https://github.com/rest-for-physics/restG4restG4 cannot be implemented due to concurrency issues, further changes are needed to implement this pipeline inside master
@jgalan and @lobis, let me know what do you think so I can proceed with the changes in the different submodules
jgalanlobis
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestpolicyHow things should behaveHow things should behave